Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#OBS-I116: Dataset CRUD apis test fixes #202

Merged
merged 10 commits into from
Jul 23, 2024
Merged

Conversation

JeraldJF
Copy link

@JeraldJF JeraldJF commented Jul 14, 2024

Description
Fixes:

  1. On check for dataset exists, if not exists the dataset.id is null so its replaced by datasetId
  2. api_version must be fetched from the datasets, as there are checks on api_version in the line 40.
  3. Replaced _.map with for of as maps do not support async calls.
  4. Check for isEmpty for denorm fields and transformations as both can be empty array.
  5. Modifying datafields with the transformations on it.
  6. entry_topic column added to Dataset models.

@SanthoshVasabhaktula SanthoshVasabhaktula merged commit 7be5998 into v2-apis Jul 23, 2024
1 check failed
@SanthoshVasabhaktula SanthoshVasabhaktula deleted the v2-apis-test branch July 23, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants