Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#OBS-I165: Dataset audit using user token #242

Merged
merged 290 commits into from
Sep 16, 2024
Merged

#OBS-I165: Dataset audit using user token #242

merged 290 commits into from
Sep 16, 2024

Conversation

Rakshitha-D
Copy link

No description provided.

JeraldJF and others added 30 commits July 15, 2024 18:07
@JeraldJF
#OBS-I116: Dataset create api fixes
781c8af
@SanthoshVasabhaktula
Merge pull request #204 from Sanketika-Obsrv/v2-apis-create
fd74dc1 
#OBS-I116: Dataset create api fixes
@JeraldJF
Merge remote-tracking branch 'origin/v2-apis' into v2-apis-test
4560b71
@JeraldJF
#OBS-I116: Dataset ingestion spec generation fix
00ac3cb
@yashashkumar
#OBS-I126: updated swagger documentation
a12fd98
@yashashkumar
#OBS-I126: updated postman collection
edc2ca2
@yashashkumar
#OBS-I126: updated postman collection
367c843
@HarishGangula
Merge pull request #205 from Sanketika-Obsrv/swagger-documentation
d71b680 
Swagger documentation
@JeraldJF
#OBS-I116: fix: entry topic column in datasets model
efbc3ae
@HarishGangula
#OBS-I58 feat: Minio cloud store support
aaaaca7 
- Added endpoint. as optional config to support the minio
@HarishGangula
Merge pull request #206 from Sanketika-Obsrv/minio-blob-support
b9d8176 
#OBS-I58 feat: Minio cloud store support
@yashashkumar
#OBS-I126: added dataset read, list, update api's documentation and u…
6c86ba0 
…pdated collection
@JeraldJF
#OBS-I116: feat: Dataschema api implementation v2
98045bd
@JeraldJF
#OBS-I116: feat: Schema validation fix
72b67b5
@HarishGangula
Merge pull request #208 from Sanketika-Obsrv/v2-apis-dataschema
37a1d1f 
#OBS-I116: feat: Dataschema api implementation v2
@yashashkumar
#OBS-I126: swagger doc updated
9703899
@JeraldJF
Merge remote-tracking branch 'origin/v2-apis' into v2-apis-test-case
012a068
@JeraldJF
Merge remote-tracking branch 'origin/v2-apis-test' into v2-apis-test-…
90f049f 
…case
@JeraldJF
#OBS-I116: Dataset update api test cases
80ac93d
@JeraldJF
#OBS-I116: fix: linting fixes
8d284ec
@JeraldJF
#OBS-I116: lint fixes
0e1b392
@JeraldJF
#OBS-I116: Dataset status transition test cases
d206d87
@yashashkumar
#OBS-I126 : added multiple requests example
da4928c
@yashashkumar
#OBS-I126 : updated order
2c6baa1
@yashashkumar
#OBS-I126 : updated server url
636c7dd
@HarishGangula
Merge pull request #207 from Sanketika-Obsrv/swagger-documentation
e5b5900 
#OBS-I126: updated swagger doc
@SurabhiAngadi
#OBS-I21: feat: dataset publish changes for connectors
c8ef5e1
@SanthoshVasabhaktula
Merge pull request #202 from Sanketika-Obsrv/v2-apis-test
7be5998 
#OBS-I116: Dataset CRUD apis test fixes
@JeraldJF
Merge remote-tracking branch 'origin/v2-apis' into v2-apis-test-case
f85cccc
@HarishGangula
Merge branch 'v2-apis' into #l1-Dataset-Health
7ab6a4a
@Rakshitha-D
#OBS-I165: added userRole for data copy api
27c0940
@Rakshitha-D
#OBS-I165: added userRole for dataset Update
dde0858
@Rakshitha-D
#OBS-I165: added userRole for dataset Import
8e94695
@Rakshitha-D
#OBS-I165: added userRole for dataset status transition
7556358
@Rakshitha-D
#OBS-I165: modified Dataset Service to update the userRoles
40987b3
@Rakshitha-D
#OBS-I165: Merge branch v2_dataset_audit into dataset-audit
58342b6
@Rakshitha-D
#OBS-I165: added permission for queryTemplateUpdate api
e013c29
@Rakshitha-D
#OBS-I165: added userRole for query template create and update
a88f30c
@Rakshitha-D
#OBS-I165: added userRole for alerts api
c48efd7
@Rakshitha-D
#OBS-I165: added userRole for notifications api
5e49317
@Rakshitha-D
#OBS-I165: added userRole for silences api
428db1b
@Rakshitha-D
#OBS-I165: corrections userRole access in notification
e76e473
@Rakshitha-D
#OBS-I165: added operations_admin role and updated permissions
9096b75
@Rakshitha-D
#OBS-I165: added rbac middleware for alert routers
45adebe
@Rakshitha-D
#OBS-I165: modified the user permissions into a json object
02bd46b
@Rakshitha-D
#OBS-I165: removed unused code
998a846
HarishGangula
HarishGangula requested changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@HarishGangula HarishGangula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Handle the RBAC disabled scenario
  2. Update the created by and updated by with user id instead of role

api-service/src/services/telemetry.ts Outdated
id: "SYSTEM",
type: "User"
id: userInfo?.id || "SYSTEM",
type: userInfo?.roles[0] || "User",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is always user

@HarishGangula HarishGangula merged commit 593cae6 into 1.1-RC Sep 16, 2024
1 check passed
@HarishGangula HarishGangula deleted the dataset-audit branch September 16, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarishGangula HarishGangula HarishGangula approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Rakshitha-D @HarishGangula @JeraldJF @SanthoshVasabhaktula @yashashkumar @SurabhiAngadi @ravismula @anandp504 @AniketSaki