Skip to content
This repository has been archived by the owner on Dec 19, 2023. It is now read-only.

replace dokkaFatJar with dokkaRuntime #338

Closed
wants to merge 1 commit into from

Conversation

unlimitedsola
Copy link

@unlimitedsola unlimitedsola commented Jul 2, 2019

@jmisur jmisur requested a review from fbenz July 3, 2019 12:58
Copy link
Contributor

@fbenz fbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the FAQ, one has to change the way the fat jar is included when migrating to the not yet released version 0.9.19: https://github.com/Kotlin/dokka/wiki/FAQ#migrating-from-older-versions-to-0919
The FAQ does not mention removing the far JAR entirely. So bu just looking at the FAQ, I can not judge whether this is the right thing to do. Is there any other source (e.g. a commit/PR) that shows that this should be done?

@unlimitedsola
Copy link
Author

@fbenz sorry I didn't check the version, but one thing I did encounter is when I have multiple dokka task, there's an issue with dokkaFatJar configuration. you can check the issue link: Kotlin/dokka#462

@unlimitedsola
Copy link
Author

One more thing worth noting is, even though that migration guide says it's for 0.9.19, but the example configuration in their README file uses dokkaRuntime for 0.9.18 (https://github.com/Kotlin/dokka/blob/master/README.md)

So my opinion would be it's fine to follow the documented example

@fbenz
Copy link
Contributor

fbenz commented Apr 13, 2020

This change is done as part of the upgrade to Dokka 0.10.1, see #385

@fbenz fbenz closed this Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants