From 394d072c0abe575ef6879b94453bf56b48523c88 Mon Sep 17 00:00:00 2001 From: realmaxbuster <83876193+realmaxbuster@users.noreply.github.com> Date: Thu, 6 Jan 2022 00:06:54 -0800 Subject: [PATCH] Fix ShapeFactory cube : Reversed front/back vertices (#272) --- .../ar/sceneform/rendering/ShapeFactory.java | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/core/src/main/java/com/google/ar/sceneform/rendering/ShapeFactory.java b/core/src/main/java/com/google/ar/sceneform/rendering/ShapeFactory.java index d852c0d0..b00d1f55 100644 --- a/core/src/main/java/com/google/ar/sceneform/rendering/ShapeFactory.java +++ b/core/src/main/java/com/google/ar/sceneform/rendering/ShapeFactory.java @@ -67,16 +67,16 @@ public static ModelRenderable makeCube(Vector3 size, Vector3 center, Material ma Vertex.builder().setPosition(p4).setNormal(left).setUvCoordinate(uv11).build(), Vertex.builder().setPosition(p0).setNormal(left).setUvCoordinate(uv10).build(), Vertex.builder().setPosition(p3).setNormal(left).setUvCoordinate(uv00).build(), - // Front - Vertex.builder().setPosition(p4).setNormal(front).setUvCoordinate(uv01).build(), - Vertex.builder().setPosition(p5).setNormal(front).setUvCoordinate(uv11).build(), - Vertex.builder().setPosition(p1).setNormal(front).setUvCoordinate(uv10).build(), - Vertex.builder().setPosition(p0).setNormal(front).setUvCoordinate(uv00).build(), // Back - Vertex.builder().setPosition(p6).setNormal(back).setUvCoordinate(uv01).build(), - Vertex.builder().setPosition(p7).setNormal(back).setUvCoordinate(uv11).build(), - Vertex.builder().setPosition(p3).setNormal(back).setUvCoordinate(uv10).build(), - Vertex.builder().setPosition(p2).setNormal(back).setUvCoordinate(uv00).build(), + Vertex.builder().setPosition(p4).setNormal(back).setUvCoordinate(uv01).build(), + Vertex.builder().setPosition(p5).setNormal(back).setUvCoordinate(uv11).build(), + Vertex.builder().setPosition(p1).setNormal(back).setUvCoordinate(uv10).build(), + Vertex.builder().setPosition(p0).setNormal(back).setUvCoordinate(uv00).build(), + // Front + Vertex.builder().setPosition(p6).setNormal(front).setUvCoordinate(uv01).build(), + Vertex.builder().setPosition(p7).setNormal(front).setUvCoordinate(uv11).build(), + Vertex.builder().setPosition(p3).setNormal(front).setUvCoordinate(uv10).build(), + Vertex.builder().setPosition(p2).setNormal(front).setUvCoordinate(uv00).build(), // Right Vertex.builder().setPosition(p5).setNormal(right).setUvCoordinate(uv01).build(), Vertex.builder().setPosition(p6).setNormal(right).setUvCoordinate(uv11).build(),