From 73fc6e4d479715fa22dd947574b9541de382c69b Mon Sep 17 00:00:00 2001 From: motm32 Date: Fri, 7 Oct 2022 11:35:20 -0700 Subject: [PATCH 1/5] Add dynamic concurrency in host schema --- src/schemas/json/host.json | 16 ++++++++++++++++ src/test/host/host.v2.json | 4 ++++ 2 files changed, 20 insertions(+) diff --git a/src/schemas/json/host.json b/src/schemas/json/host.json index 938e14fa2ec..f78d5965da3 100644 --- a/src/schemas/json/host.json +++ b/src/schemas/json/host.json @@ -1365,6 +1365,22 @@ } } ], + "concurrency": { + "description": "Configuration settings for dynamic concurrency", + "type": "object", + "properties": { + "dynamicConcurrencyEnabled": { + "description": "Enables or disables dynamic concurrency for function apps.", + "type": "boolean", + "default": true + }, + "snapshotPersistenceEnabled" : { + "description": "Enables or disables the learned concurrency values persisting in storage.", + "type": "boolean", + "default": true + } + } + }, "additionalProperties": false } }, diff --git a/src/test/host/host.v2.json b/src/test/host/host.v2.json index beb577c766d..4124b26c785 100644 --- a/src/test/host/host.v2.json +++ b/src/test/host/host.v2.json @@ -3,6 +3,10 @@ "batchSize": 1000, "flushTimeout": "00:00:30" }, + "concurrency": { + "dynamicConcurrencyEnabled": true, + "snapshotPersistenceEnabled": true + }, "extensionBundle": { "id": "Microsoft.Azure.Functions.ExtensionBundle", "version": "[1.*, 2.0.0)" From c09425be0f3d334a8ef0ce7756876e166e17ac9d Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri, 7 Oct 2022 18:41:49 +0000 Subject: [PATCH 2/5] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- src/schemas/json/host.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/schemas/json/host.json b/src/schemas/json/host.json index f78d5965da3..ac3cdcbb173 100644 --- a/src/schemas/json/host.json +++ b/src/schemas/json/host.json @@ -1374,9 +1374,9 @@ "type": "boolean", "default": true }, - "snapshotPersistenceEnabled" : { + "snapshotPersistenceEnabled": { "description": "Enables or disables the learned concurrency values persisting in storage.", - "type": "boolean", + "type": "boolean", "default": true } } From 7ab677788465affbe3fc8a67d178830bded3b80b Mon Sep 17 00:00:00 2001 From: Megan Mott <59709511+motm32@users.noreply.github.com> Date: Mon, 10 Oct 2022 14:18:41 -0700 Subject: [PATCH 3/5] Add concurrency to properties --- src/schemas/json/host.json | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/src/schemas/json/host.json b/src/schemas/json/host.json index ac3cdcbb173..a6577143416 100644 --- a/src/schemas/json/host.json +++ b/src/schemas/json/host.json @@ -1345,6 +1345,22 @@ "additionalProperties": false } } + }, + "concurrency": { + "description": "Configuration settings for dynamic concurrency", + "type": "object", + "properties": { + "dynamicConcurrencyEnabled": { + "description": "Enables or disables dynamic concurrency for function apps.", + "type": "boolean", + "default": true + }, + "snapshotPersistenceEnabled": { + "description": "Enables or disables the learned concurrency values persisting in storage.", + "type": "boolean", + "default": true + } + } } }, "required": ["version"], @@ -1365,22 +1381,6 @@ } } ], - "concurrency": { - "description": "Configuration settings for dynamic concurrency", - "type": "object", - "properties": { - "dynamicConcurrencyEnabled": { - "description": "Enables or disables dynamic concurrency for function apps.", - "type": "boolean", - "default": true - }, - "snapshotPersistenceEnabled": { - "description": "Enables or disables the learned concurrency values persisting in storage.", - "type": "boolean", - "default": true - } - } - }, "additionalProperties": false } }, From 4d83bcde22c671e594277a158086b9b9030afb83 Mon Sep 17 00:00:00 2001 From: Megan Mott <59709511+motm32@users.noreply.github.com> Date: Tue, 11 Oct 2022 10:21:44 -0700 Subject: [PATCH 4/5] Add additionalProperties = false --- src/schemas/json/host.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/schemas/json/host.json b/src/schemas/json/host.json index a6577143416..32c91e2d8f5 100644 --- a/src/schemas/json/host.json +++ b/src/schemas/json/host.json @@ -1360,7 +1360,8 @@ "type": "boolean", "default": true } - } + }, + "additionalProperties": false } }, "required": ["version"], From 6baa5b6ff99f7d879f42deccc3f7a8951dbe864e Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Tue, 11 Oct 2022 17:22:09 +0000 Subject: [PATCH 5/5] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- src/schemas/json/host.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/schemas/json/host.json b/src/schemas/json/host.json index 32c91e2d8f5..23db15baf00 100644 --- a/src/schemas/json/host.json +++ b/src/schemas/json/host.json @@ -1360,7 +1360,7 @@ "type": "boolean", "default": true } - }, + }, "additionalProperties": false } },