Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(py-sdk): fix python package names #1486

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

cchndl
Copy link
Contributor

@cchndl cchndl commented Nov 6, 2024

Python package names are not allowed to contain '-', which is a syntax error. Replace with '_'.

Description

The package names in Python shouldn't contain hyphens, as this is a syntax error.

Replacing with underscore fixes this, but the drawback is that now project and package names differ. This is fine but not recommended. But whether only the pacakge name should be changed or you also modify the project names on Pypi is your call.

Motivation

Both Python sdk are not usable as the import fails with a syntax error.

Changes:

  • rename Python sdk package names

Tests included

  • Included for each change/fix?
  • Passing?

Documentation

  • swagger documentation updated (required for API changes)
  • official documentation updated

official documentation info

Python package names are not allowed to contain '-', which is a syntax
error. Replace with '_'.
@Junjiequan
Copy link
Contributor

Thanks for the fix.
I've just included a small change so that package name is consistent with project name to avoid confusion.

@Junjiequan Junjiequan changed the title ci (py-sdk): fix python package names ci(py-sdk): fix python package names Nov 7, 2024
@Junjiequan Junjiequan merged commit 8e26958 into SciCatProject:master Nov 7, 2024
8 of 9 checks passed
@cchndl cchndl deleted the pypkgnames branch November 8, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants