chore: auto-merge dependabot patch versions #778
Conversation
| steps: | ||
| - uses: actions/checkout@v4 | ||
| ## https://github.com/ahmadnassri/action-dependabot-auto-merge | ||
| - uses: ahmadnassri/action-dependabot-auto-merge@v2 |
There was a problem hiding this comment.
instead of using an intransparent third-party action, check https://github.com/SciCatProject/frontend/pull/1216/files#diff-2fe48d1021006468ac63263583b5db615dd5e63a39ebff862cc4e2f06b59caa1
its just 3 or 4 lines more without, and we have much more control.
There was a problem hiding this comment.
I agree with @bpedersen2. Con we try the other solution?
There was a problem hiding this comment.
With that solution it seems like we need to enable auto-merge, I'm not sure if that's a good idea.
Most importantly, it doesn't check whether all the tests are passing or not..
I need to test the script further
There was a problem hiding this comment.
My version just sets automerge per pull-request if it is coming from dependabot. So changes get merge if tests pass.
There was a problem hiding this comment.
I see, enable auto merge will check if all the requirements passed. Then we just need to include an PR approved flow it should work, because with current merge rule at least 1 approval is required
| steps: | ||
| - uses: actions/checkout@v4 | ||
| ## https://github.com/ahmadnassri/action-dependabot-auto-merge | ||
| - uses: ahmadnassri/action-dependabot-auto-merge@v2 |
There was a problem hiding this comment.
I agree with @bpedersen2. Con we try the other solution?
nitrosx
deleted the
SWAP-3518-scicat-be-automate-merge-for-dependabot-pr
branch
Description
Added new workflow to auto merge dependabot package version bump PR when all checks pass.
Solves #762
The logic of
Dependabot auto-mergeworkflow are:auto-merge prerequisite configuration can be done in Settings > Branches > Edit or Add rule
Tests included/Docs Updated?