Skip to content

Conversation

@iceljc
Copy link
Collaborator

@iceljc iceljc commented Apr 11, 2025

PR Type

Enhancement, Tests


Description

  • Fixed typo in IRealtimeHook interface method name.

  • Updated RealtimeHub to use corrected method name.

  • Enhanced ServiceBuilder to support user secrets with optional assembly parameter.

  • Updated test project to utilize user secrets and pass assembly parameter.


Changes walkthrough 📝

Relevant files
Bug fix
IRealtimeHook.cs
Corrected method name in `IRealtimeHook` interface             

src/Infrastructure/BotSharp.Abstraction/Realtime/IRealtimeHook.cs

  • Fixed typo in method name from OnModeReady to OnModelReady.
+1/-1     
RealtimeHub.cs
Updated `RealtimeHub` to use corrected method name             

src/Infrastructure/BotSharp.Core.Realtime/Services/RealtimeHub.cs

  • Updated method call to use corrected OnModelReady name.
  • Removed redundant call to OnModeReady.
  • +1/-2     
    Enhancement
    ServiceBuilder.cs
    Enhanced `ServiceBuilder` to support user secrets               

    src/Infrastructure/BotSharp.OpenAPI/ServiceBuilder.cs

  • Added optional Assembly parameter to CreateHostBuilder.
  • Enabled user secrets configuration if Assembly is provided.
  • +11/-4   
    Tests
    Program.cs
    Updated test program to pass assembly parameter                   

    tests/BotSharp.Test.RealtimeVoice/Program.cs

  • Updated CreateHostBuilder call to pass Assembly.GetExecutingAssembly.
  • +2/-1     
    Configuration changes
    BotSharp.Test.RealtimeVoice.csproj
    Enabled user secrets in test project                                         

    tests/BotSharp.Test.RealtimeVoice/BotSharp.Test.RealtimeVoice.csproj

    • Added UserSecretsId for user secrets support.
    +1/-0     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @iceljc iceljc merged commit c52e749 into SciSharp:master Apr 11, 2025
    0 of 4 checks passed
    @qodo-code-review
    Copy link

    Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 PR contains tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Method Naming

    The PR fixes a typo in the interface method name from 'OnModeReady' to 'OnModelReady', but there's still a method call to '_conn.OnModelReady()' which should be reviewed to ensure naming consistency throughout the codebase.

    var data = _conn.OnModelReady();
    await responseToUser(data);

    @qodo-code-review
    Copy link

    Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    1 participant