-
Notifications
You must be signed in to change notification settings - Fork 298
Implement dataless cubes #6253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement dataless cubes #6253
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6253 +/- ##
==========================================
- Coverage 89.87% 89.77% -0.11%
==========================================
Files 90 90
Lines 23450 23523 +73
Branches 4361 4390 +29
==========================================
+ Hits 21076 21118 +42
- Misses 1646 1662 +16
- Partials 728 743 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit 6ed270d.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
bjlittle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments to service ...
We're getting there 👍
Closes #4447.
I plan to do this in four stages:
data is Nonewhen handed a shape value, and can essentially round-trip removing and adding data. This shouldn't break existing tests. 71c7ae8DataManagermethods all make sense and work withNonedata.DataManager.copy()is an example of a method that won't make sense withNonedata.