Skip to content

Conversation

@ESadek-MO
Copy link
Contributor

@ESadek-MO ESadek-MO commented Dec 11, 2024

Closes #4447.

I plan to do this in four stages:

  • Ensure that cubes can handle data is None when handed a shape value, and can essentially round-trip removing and adding data. This shouldn't break existing tests. 71c7ae8
  • Create new tests for the above. b2fb2f8
  • Ensure that all DataManager methods all make sense and work with None data. DataManager.copy() is an example of a method that won't make sense with None data.
  • Create new tests for the above.

@ESadek-MO ESadek-MO marked this pull request as draft December 11, 2024 11:36
@codecov
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 71.29630% with 31 lines in your changes missing coverage. Please review.

Project coverage is 89.77%. Comparing base (bb1b196) to head (ef5a2b0).
Report is 88 commits behind head on main.

Files with missing lines Patch % Lines
lib/iris/cube.py 32.14% 9 Missing and 10 partials ⚠️
lib/iris/_merge.py 0.00% 2 Missing and 2 partials ⚠️
lib/iris/_concatenate.py 60.00% 1 Missing and 1 partial ⚠️
lib/iris/_data_manager.py 96.77% 1 Missing and 1 partial ⚠️
lib/iris/_lazy_data.py 50.00% 1 Missing and 1 partial ⚠️
lib/iris/exceptions.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6253      +/-   ##
==========================================
- Coverage   89.87%   89.77%   -0.11%     
==========================================
  Files          90       90              
  Lines       23450    23523      +73     
  Branches     4361     4390      +29     
==========================================
+ Hits        21076    21118      +42     
- Misses       1646     1662      +16     
- Partials      728      743      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments to service ...

We're getting there 👍

@bjlittle bjlittle self-requested a review February 26, 2025 11:29
@bjlittle bjlittle merged commit d103230 into SciTools:main Feb 26, 2025
21 checks passed
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: 🏁 Done

Development

Successfully merging this pull request may close these issues.

A Dataless Cube

4 participants