Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Apply several fixes #39

Merged
merged 6 commits into from
Feb 21, 2024
Merged

fix: Apply several fixes #39

merged 6 commits into from
Feb 21, 2024

Conversation

chawyehsu
Copy link
Member

@chawyehsu chawyehsu commented Feb 19, 2024 •
edited
Loading

  1. Change to use powershell shell for jobs execution
  2. Support nested bucket structure
  3. Add pull_request_target event trigger
    • manifest validation to pull-requests from fork are now functional
    • not a breaking change, but downstream bucket repos may need update their workflow (change pull_request to pull_request_target in .github\workflows\pull_request.yml) to adopt this improvement

@chawyehsu chawyehsu requested a review from a team as a code owner February 19, 2024 06:55
@chawyehsu
Copy link
Member Author

No reviews but I'm merging this much-needed PR soon

@chawyehsu chawyehsu merged commit 9fa5cad into ScoopInstaller:main Feb 21, 2024
chawyehsu added a commit to chawyehsu/dorado that referenced this pull request Feb 21, 2024
@chawyehsu
chore(ci): switch to pull_request_target trigger
b55e9fe 
benefit from ScoopInstaller/GithubActions#39
chawyehsu added a commit to ScoopInstaller/Tests that referenced this pull request Feb 21, 2024
@chawyehsu
chore(ci): switch to pull_request_target trigger
0a9dc49 
benefit from ScoopInstaller/GithubActions#39
@chawyehsu chawyehsu mentioned this pull request Feb 21, 2024
Closed
1 task
chawyehsu added a commit to ScoopInstaller/Extras that referenced this pull request Feb 21, 2024
@chawyehsu
chore(ci): switch to pull_request_target trigger
576cc06 
benefit from ScoopInstaller/GithubActions#39
chawyehsu added a commit to ScoopInstaller/Main that referenced this pull request Feb 21, 2024
@chawyehsu
chore(ci): switch to pull_request_target trigger
c1b0dbc 
benefit from ScoopInstaller/GithubActions#39
chawyehsu added a commit to ScoopInstaller/Versions that referenced this pull request Feb 21, 2024
@chawyehsu
chore(ci): switch to pull_request_target trigger
4b7ef69 
benefit from ScoopInstaller/GithubActions#39
chawyehsu added a commit to ScoopInstaller/Java that referenced this pull request Feb 21, 2024
@chawyehsu
chore(ci): switch to pull_request_target trigger
8ae8645 
benefit from ScoopInstaller/GithubActions#39
DoveBoy added a commit to DoveBoy/Apps that referenced this pull request Feb 21, 2024
@DoveBoy
chore(ci): switch to pull_request_target trigger
190bd0a 
benefit from ScoopInstaller/GithubActions#39
chawyehsu referenced this pull request in repology/repology-updater Feb 21, 2024
@AMDmi3
Disable scoop until proper QA and json validation is introduced
48f3d4c 
Related: ScoopInstaller/GithubActions#38
chawyehsu added a commit to ScoopInstaller/Nonportable that referenced this pull request Feb 21, 2024
@chawyehsu
chore(ci): switch to pull_request_target trigger
d6169f2 
benefit from ScoopInstaller/GithubActions#39
chawyehsu added a commit to ScoopInstaller/BucketTemplate that referenced this pull request Feb 21, 2024
@chawyehsu
chore(ci): switch to pull_request_target trigger
c22d95a 
benefit from ScoopInstaller/GithubActions#39
@chawyehsu chawyehsu mentioned this pull request Feb 23, 2024
Merged
1 task
Calinou pushed a commit to Calinou/scoop-games that referenced this pull request Feb 23, 2024
@chawyehsu
chore(ci): Switch to pull_request_target trigger (#1096)
f1963b2 
benefit from ScoopInstaller/GithubActions#39
brian6932 pushed a commit to brian6932/dank-scoop that referenced this pull request Feb 24, 2024
@chawyehsu @brian6932
chore(ci): switch to pull_request_target trigger
66c0872 
benefit from ScoopInstaller/GithubActions#39
qwerty12 pushed a commit to qwerty12/scoop-alts that referenced this pull request Mar 9, 2024
@chawyehsu @qwerty12
chore(ci): switch to pull_request_target trigger
4b07269 
benefit from ScoopInstaller/GithubActions#39

Signed-off-by: Faheem Pervez <trippin1@gmail.com>
@nithinphilips nithinphilips mentioned this pull request Mar 20, 2024
Merged
1 task
404NetworkError pushed a commit to 404NetworkError/scoop-bucket that referenced this pull request Mar 23, 2024
@chawyehsu @404NetworkError
chore(ci): switch to pull_request_target trigger
58dba7c 
benefit from ScoopInstaller/GithubActions#39
ccyykkcyk pushed a commit to ccyykkcyk/scoop that referenced this pull request Mar 24, 2024
@chawyehsu @ccyykkcyk
chore(ci): switch to pull_request_target trigger
be226e0 
benefit from ScoopInstaller/GithubActions#39
MMKubicki added a commit to MMKubicki/ScoopBucket that referenced this pull request Apr 5, 2024
@MMKubicki
chore(ci): switch to pull_request_target trigger
5954756 
benefit from ScoopInstaller/GithubActions#39
ref ScoopInstaller/BucketTemplate@c22d95a
LucasOe pushed a commit to LucasOe/scoop-lucasoe that referenced this pull request Apr 23, 2024
@chawyehsu @LucasOe
chore(ci): switch to pull_request_target trigger
bdfd619 
benefit from ScoopInstaller/GithubActions#39
LucasOe pushed a commit to LucasOe/scoop-lucasoe that referenced this pull request Oct 10, 2024
@chawyehsu @LucasOe
chore(ci): switch to pull_request_target trigger
601bf7b 
benefit from ScoopInstaller/GithubActions#39
@xrgzs xrgzs mentioned this pull request Nov 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chawyehsu