Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(buckets): Don't check remote URL of non-git buckets #4923

Merged
merged 2 commits into from
May 15, 2022
Merged

fix(buckets): Don't check remote URL of non-git buckets #4923

merged 2 commits into from
May 15, 2022

Conversation

niheaven
Copy link
Member

Description

  1. Add missing 'main' repo URL in scoop update when user first install scoop and 'main' is extracted from zip archive.
  2. Skip checking remote URL when bucket is a non-git local one.

Motivation and Context

Closes #4917

Relates to #4814

How Has This Been Tested?

All tests passed, and all bugs in original post have been corrected.

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@niheaven niheaven merged commit a2600b1 into develop May 15, 2022
@niheaven niheaven deleted the fix-convert-uri branch May 15, 2022 07:49
@ikappaki ikappaki mentioned this pull request May 21, 2022
Closed
@niheaven niheaven mentioned this pull request Jun 1, 2022
Merged
@niheaven niheaven mentioned this pull request Jun 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashil2000 rashil2000 rashil2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niheaven @rashil2000