From a47946f56e87320a8360edbc5f9140883b493b39 Mon Sep 17 00:00:00 2001
From: Hua Huang <hua.huang@seagate.com>
Date: Thu, 16 Jun 2022 07:37:51 -0600
Subject: [PATCH] fix Codacy warnings.

Signed-off-by: Hua Huang <hua.huang@seagate.com>
---
 m0t1fs/linux_kernel/st/m0t1fs_common_inc.sh |  2 +-
 motr/st/utils/motr_io_small_disks.sh        | 17 ++++++++---------
 2 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/m0t1fs/linux_kernel/st/m0t1fs_common_inc.sh b/m0t1fs/linux_kernel/st/m0t1fs_common_inc.sh
index a6d7c7cd82..4810a16118 100755
--- a/m0t1fs/linux_kernel/st/m0t1fs_common_inc.sh
+++ b/m0t1fs/linux_kernel/st/m0t1fs_common_inc.sh
@@ -81,7 +81,7 @@ IOS5_CMD=""       #IOS5 process commandline to spawn it again on Controller even
 
 IOS4_CMD=""
 
-IOS_DISK_BLOCK_COUNT=1M
+export IOS_DISK_BLOCK_COUNT=1M
 
 # list of md server end points tmid in [800, 899)
 MDSEP=(
diff --git a/motr/st/utils/motr_io_small_disks.sh b/motr/st/utils/motr_io_small_disks.sh
index 2a30a74b63..904fc5e3b6 100755
--- a/motr/st/utils/motr_io_small_disks.sh
+++ b/motr/st/utils/motr_io_small_disks.sh
@@ -19,14 +19,14 @@
 #
 
 
-TOPDIR=`dirname $0`/../../../
+TOPDIR="$(dirname $0)/../../../"
 
-. ${TOPDIR}/m0t1fs/linux_kernel/st/common.sh
-. ${TOPDIR}/m0t1fs/linux_kernel/st/m0t1fs_common_inc.sh
-. ${TOPDIR}/m0t1fs/linux_kernel/st/m0t1fs_client_inc.sh
-. ${TOPDIR}/m0t1fs/linux_kernel/st/m0t1fs_server_inc.sh
-. ${TOPDIR}/m0t1fs/linux_kernel/st/m0t1fs_sns_common_inc.sh
-. ${TOPDIR}/motr/st/utils/sns_repair_common_inc.sh
+. "${TOPDIR}/m0t1fs/linux_kernel/st/common.sh"
+. "${TOPDIR}/m0t1fs/linux_kernel/st/m0t1fs_common_inc.sh"
+. "${TOPDIR}/m0t1fs/linux_kernel/st/m0t1fs_client_inc.sh"
+. "${TOPDIR}/m0t1fs/linux_kernel/st/m0t1fs_server_inc.sh"
+. "${TOPDIR}/m0t1fs/linux_kernel/st/m0t1fs_sns_common_inc.sh"
+. "${TOPDIR}/motr/st/utils/sns_repair_common_inc.sh"
 
 
 export MOTR_CLIENT_ONLY=1
@@ -37,7 +37,6 @@ export IOS_DISK_BLOCK_COUNT=500
 motr_io_small_disks()
 {
 	local rc=0
-	local fail_device=1
 
 	echo "Startin motr_io_small_disks testing ..."
 
@@ -61,7 +60,7 @@ main()
 
 	sandbox_init
 
-	NODE_UUID=`uuidgen`
+	NODE_UUID=$(uuidgen)
 	local multiple_pools=0
 	motr_service start $multiple_pools $stride $N $K $S $P || {
 		echo "Failed to start Motr Service."