Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(screenshot): get only some columns from csv file #114

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

psyray
Copy link
Contributor

@psyray psyray commented Jun 20, 2024

fix #110

Instead of fetching the whole row, where number of columns can change again in the future, I'm fetching only the ones we are interested

So no problem like that in the future.

Tested and working

@psyray psyray added the bug Something isn't working label Jun 20, 2024
@psyray psyray requested a review from AnonymousWP June 20, 2024 13:05
@psyray psyray self-assigned this Jun 20, 2024
@AnonymousWP
Copy link
Member

Please solve the conflicts so I can review it properly.

@psyray
Copy link
Contributor Author

psyray commented Jun 20, 2024

Done

@AnonymousWP AnonymousWP merged commit 2a29534 into master Jun 20, 2024
4 of 5 checks passed
@AnonymousWP AnonymousWP deleted the fix-110-screenshot-error branch June 20, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(screenshot): screenshot scan fails with errors
2 participants