Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change install_type value in .env-dist and add missing imports #201

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

psyray
Copy link
Contributor

@psyray psyray commented Sep 18, 2024

  • Unattended install was broken due to bad var value
  • CIDR import broken due to missing import

Tested and working

@psyray psyray requested a review from AnonymousWP September 18, 2024 20:46
Copy link
Contributor

sourcery-ai bot commented Sep 18, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@psyray psyray self-assigned this Sep 18, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @psyray - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@psyray psyray added the bug Something isn't working label Sep 18, 2024
@AnonymousWP
Copy link
Member

I'll wait for checks to complete.

@AnonymousWP AnonymousWP merged commit 2b79276 into release/2.1.0 Sep 18, 2024
5 checks passed
@AnonymousWP AnonymousWP deleted the fix-little-bugs branch September 18, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants