Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): fix links and images #65

Merged
merged 4 commits into from
May 24, 2024

Conversation

psyray
Copy link
Contributor

@psyray psyray commented May 1, 2024

I've update the README to change links and images.
I've added Discord invitation, Last conference where I've talked of reNGine
I've removed huntr and sponsoring part

I've generated a banner

@psyray psyray requested a review from AnonymousWP May 1, 2024 13:48
@AnonymousWP AnonymousWP changed the title fix(docs): Update README.md + Images docs(readme): fix links and images May 3, 2024
@AnonymousWP AnonymousWP added the documentation Improvements or additions to documentation label May 3, 2024
Copy link
Member

@AnonymousWP AnonymousWP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@yarysp yarysp self-assigned this May 21, 2024
@yarysp yarysp added the bug Something isn't working label May 21, 2024
@yarysp yarysp requested a review from AnonymousWP May 21, 2024 22:40
@psyray
Copy link
Contributor Author

psyray commented May 23, 2024

See comments.

Comments have been resolved, could you review and merge this if it's good for you

@AnonymousWP AnonymousWP removed the bug Something isn't working label May 23, 2024
Copy link
Member

@AnonymousWP AnonymousWP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of it looks good, apart from some nitbits that I'll fix myself in the future (mainly Markdown-related). Also, one important thing/question:

Do we keep the badges at the top of the README? And do we also keep the release video of reNgine. reNgine-ng is basically the same as reNgine, but this makes it look like we've been credited/mentioned/featured at some events while that's reNgine. What do you think?

Co-authored-by: Anonymoussaurus <50231698+AnonymousWP@users.noreply.github.com>
@psyray
Copy link
Contributor Author

psyray commented May 24, 2024

Also, one important thing/question:

Do we keep the badges at the top of the README? And do we also keep the release video of reNgine. reNgine-ng is basically the same as reNgine, but this makes it look like we've been credited/mentioned/featured at some events while that's reNgine. What do you think?

For me it's the reNgine history.
This project has reNgine as a source, so it's legitimate to put Yogesh videos that explain the spirit and usage of the tool.
Same for the badge and I will add ours.
I'm waiting for my french presentation to be published to add another badge 😉

@AnonymousWP AnonymousWP merged commit 31daf53 into Security-Tools-Alliance:master May 24, 2024
@psyray psyray deleted the update-readme branch May 24, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants