-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(install/uninstall/update): improve usability, readability and overall user experience of output #95
Conversation
Makes sure we don't need to manually update it
@Security-Tools-Alliance/developers-rengine Please test and review this. I spent quite a lot of time on testing, but it's appreciated if you find anything that can be improved or isn't working well. Thanks. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Install is fine, color are clear.
Could you modify those two comments, and also the update check.
When reNgine-ng is installed, popup came with update from yogesh repo
It's located here
Lines 789 to 794 in e34625c
class RengineUpdateCheck(APIView): | |
def get(self, request): | |
req = self.request | |
github_api = \ | |
'https://api.github.com/repos/yogeshojha/rengine/releases' | |
response = requests.get(github_api).json() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work 😉
The following has changed in this PR related to the title: