Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi monitor support #13

Closed
dhyams opened this issue Sep 28, 2023 · 3 comments · Fixed by #17
Closed

Multi monitor support #13

dhyams opened this issue Sep 28, 2023 · 3 comments · Fixed by #17

Comments

@dhyams
Copy link

dhyams commented Sep 28, 2023

It looks like self.num_monitors is always set to zero, which means that the option to span across monitors is not meaningful; it always spans monitors no matter what. Is there another way to do multi monitor support, where the banner appears separately in each monitor, with the classification level centered at the top of each monitor?

@bracketttc
Copy link
Contributor

It should be possible. The existing multi-monitor code seems broken though. Gdk.Monitor.get_geometry() returns a Gdk.Rectangle which isn't iterable or decomposable into a tuple. I think it's fairly trivially fixable, but it makes me wonder why the code started using xrandr as the preferred source of screen/monitor size over GTK - there might be something I'm missing.

@redhatrises
Copy link
Member

redhatrises commented Oct 21, 2023

Previously, gtk didn't reliably provide the correct number of monitors in older versions depending on display and graphic card implementation. Granted this issue is several years old and maybe fixed, so happy to merge and revisit if it is still an issue with improper display settings reported back.

@bracketttc
Copy link
Contributor

With some work, we can get that information from xrandr, but the current processing of the xrandr output doesn't do that - it only gets the screen size (with the version ofxrandr that I have installed that's the only invocation that parses as expected).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants