From 0501f49f6bac618321fcfd62807f56afa56b37d3 Mon Sep 17 00:00:00 2001
From: ryandawsonuk <rd@seldon.io>
Date: Fri, 26 Jun 2020 17:38:23 +0100
Subject: [PATCH] first expand test for upgrade status

---
 testing/scripts/seldon_e2e_utils.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/testing/scripts/seldon_e2e_utils.py b/testing/scripts/seldon_e2e_utils.py
index 71e9391d87..32ec25f3c9 100644
--- a/testing/scripts/seldon_e2e_utils.py
+++ b/testing/scripts/seldon_e2e_utils.py
@@ -565,11 +565,12 @@ def assert_model(sdep_name, namespace, initial=False, endpoint=API_AMBASSADOR):
     # a Kubernetes resource. This covers cases where some resources (e.g. CRD
     # versions or webhooks) may get inadvertently removed between versions.
     ret = run(
-        f"kubectl get -n {namespace} sdep {sdep_name}",
-        stdout=subprocess.DEVNULL,
+        f"kubectl get -n {namespace} sdep {sdep_name} -o=jsonpath='{.status.state}'",
+        stdout=subprocess.PIPE,
         shell=True,
     )
     assert ret.returncode == 0
+    assert ret.stdout != "Failed"
 
 
 def to_resources_path(file_name):