From d83ff7e140fd5efa5b91ac45f5b32a6014a34d18 Mon Sep 17 00:00:00 2001 From: aguspe Date: Sat, 20 Jul 2024 01:54:55 +0200 Subject: [PATCH 01/33] Add timeout and tests for curb, also added the gem curb that was not being loaded --- rb/Gemfile.lock | 2 + rb/lib/selenium/webdriver/remote.rb | 3 +- rb/lib/selenium/webdriver/remote/http/curb.rb | 20 +++++--- rb/selenium-webdriver.gemspec | 1 + rb/sig/gems/curb/curl.rbs | 5 ++ .../selenium/webdriver/remote/http/curb.rbs | 10 ++-- .../webdriver/remote/http/curb_spec.rb | 51 +++++++++++++++++++ 7 files changed, 82 insertions(+), 10 deletions(-) create mode 100644 rb/sig/gems/curb/curl.rbs create mode 100644 rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb diff --git a/rb/Gemfile.lock b/rb/Gemfile.lock index d99af4f3dd4bb..54f8ed7733827 100644 --- a/rb/Gemfile.lock +++ b/rb/Gemfile.lock @@ -5,6 +5,7 @@ PATH selenium-webdriver (~> 4.2) selenium-webdriver (4.23.0) base64 (~> 0.2) + curb (~> 1.0.5) logger (~> 1.4) rexml (~> 3.2, >= 3.2.5) rubyzip (>= 1.2.2, < 3.0) @@ -35,6 +36,7 @@ GEM bigdecimal rexml csv (3.3.0) + curb (1.0.5) debug (1.9.2) irb (~> 1.10) reline (>= 0.3.8) diff --git a/rb/lib/selenium/webdriver/remote.rb b/rb/lib/selenium/webdriver/remote.rb index 1f73c4b93270d..fe2fda6913be5 100644 --- a/rb/lib/selenium/webdriver/remote.rb +++ b/rb/lib/selenium/webdriver/remote.rb @@ -31,7 +31,8 @@ module Remote autoload :Capabilities, 'selenium/webdriver/remote/capabilities' module Http - autoload :Common, 'selenium/webdriver/remote/http/common' + autoload :Common, 'selenium/webdriver/remote/http/common' + autoload :Curb, 'selenium/webdriver/remote/http/curb' autoload :Default, 'selenium/webdriver/remote/http/default' end end diff --git a/rb/lib/selenium/webdriver/remote/http/curb.rb b/rb/lib/selenium/webdriver/remote/http/curb.rb index 1ab2fd1398554..71031c6abd90c 100644 --- a/rb/lib/selenium/webdriver/remote/http/curb.rb +++ b/rb/lib/selenium/webdriver/remote/http/curb.rb @@ -37,6 +37,13 @@ module Http # class Curb < Common + attr_accessor :timeout + + def initialize(timeout: nil) + @timeout = timeout + super() + end + def quit_errors [Curl::Err::RecvError] + super end @@ -53,7 +60,7 @@ def request(verb, url, headers, payload) client.headers = headers # http://github.com/taf2/curb/issues/issue/33 - client.head = false + client.head = false client.delete = false case verb @@ -80,15 +87,16 @@ def client @client ||= begin c = Curl::Easy.new - c.max_redirects = MAX_REDIRECTS + c.max_redirects = MAX_REDIRECTS c.follow_location = true - c.timeout = @timeout if @timeout - c.verbose = WebDriver.logger.debug? - + c.timeout = timeout if timeout + c.verbose = WebDriver.logger.debug? c end end - end # Curb + end + + # Curb end # Http end # Remote end # WebDriver diff --git a/rb/selenium-webdriver.gemspec b/rb/selenium-webdriver.gemspec index 64a92dcb358fc..3e15a42b9ce79 100644 --- a/rb/selenium-webdriver.gemspec +++ b/rb/selenium-webdriver.gemspec @@ -48,6 +48,7 @@ Gem::Specification.new do |s| s.require_paths = ['lib'] s.add_dependency 'base64', ['~> 0.2'] + s.add_dependency 'curb', ['~> 1.0.5'] s.add_dependency 'logger', ['~> 1.4'] s.add_dependency 'rexml', ['~> 3.2', '>= 3.2.5'] s.add_dependency 'rubyzip', ['>= 1.2.2', '< 3.0'] diff --git a/rb/sig/gems/curb/curl.rbs b/rb/sig/gems/curb/curl.rbs new file mode 100644 index 0000000000000..569dc153c160f --- /dev/null +++ b/rb/sig/gems/curb/curl.rbs @@ -0,0 +1,5 @@ +module Curl + class Easy + def initialize: () -> void + end +end diff --git a/rb/sig/lib/selenium/webdriver/remote/http/curb.rbs b/rb/sig/lib/selenium/webdriver/remote/http/curb.rbs index 03e3e6e025b53..4d9ad7fdac1f3 100644 --- a/rb/sig/lib/selenium/webdriver/remote/http/curb.rbs +++ b/rb/sig/lib/selenium/webdriver/remote/http/curb.rbs @@ -5,13 +5,17 @@ module Selenium class Curb < Common @client: untyped - def quit_errors: () -> untyped + attr_accessor timeout: Numeric? + + def initialize: (timeout: Numeric?) -> void + + def quit_errors: () -> Array[StandardError] private - def request: (untyped verb, untyped url, untyped headers, untyped payload) -> untyped + def request: (Symbol verb, URI | String url, Hash[String, String] headers, String payload) -> Remote::Response - def client: () -> untyped + def client: () -> Curl::Easy end end end diff --git a/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb b/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb new file mode 100644 index 0000000000000..c2cb41d9b7719 --- /dev/null +++ b/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb @@ -0,0 +1,51 @@ +# frozen_string_literal: true + +# Licensed to the Software Freedom Conservancy (SFC) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The SFC licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +require File.expand_path('../../spec_helper', __dir__) + +module Selenium + module WebDriver + module Remote + module Http + describe Curb do + subject(:curb) { described_class.new } + + it 'assigns default timeout to 0.0' do + http = curb.send :client + + expect(http.timeout).to eq 0.0 + end + + it 'sets the timeout' do + curb.timeout = 20 + expect(curb.timeout).to eq 20 + end + + describe '#initialize' do + let(:curb) { described_class.new(timeout: 10) } + + it 'is initialized with timeout' do + expect(curb.timeout).to eq 10 + end + end + end + end # Http + end # Remote + end # WebDriver +end # Selenium From b7bef9f6b32fb6c80553f7a11b0fb22b821597b9 Mon Sep 17 00:00:00 2001 From: aguspe Date: Sat, 3 Aug 2024 20:33:05 +0200 Subject: [PATCH 02/33] Update gemfile lock --- rb/Gemfile.lock | 3 +-- rb/lib/selenium/webdriver/remote.rb | 1 - rb/selenium-webdriver.gemspec | 2 +- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/rb/Gemfile.lock b/rb/Gemfile.lock index 6bf6e085f5fbf..a84d70b8d8b4d 100644 --- a/rb/Gemfile.lock +++ b/rb/Gemfile.lock @@ -5,7 +5,6 @@ PATH selenium-webdriver (~> 4.2) selenium-webdriver (4.24.0.nightly) base64 (~> 0.2) - curb (~> 1.0.5) logger (~> 1.4) rexml (~> 3.2, >= 3.2.5) rubyzip (>= 1.2.2, < 3.0) @@ -36,7 +35,6 @@ GEM bigdecimal rexml csv (3.3.0) - curb (1.0.5) debug (1.9.2) irb (~> 1.10) reline (>= 0.3.8) @@ -176,6 +174,7 @@ PLATFORMS universal-java-1.8 universal-java-17 universal-java-18 + universal-java-21 x64-mingw32 x86_64-darwin-22 diff --git a/rb/lib/selenium/webdriver/remote.rb b/rb/lib/selenium/webdriver/remote.rb index fe2fda6913be5..f449f9030985d 100644 --- a/rb/lib/selenium/webdriver/remote.rb +++ b/rb/lib/selenium/webdriver/remote.rb @@ -32,7 +32,6 @@ module Remote module Http autoload :Common, 'selenium/webdriver/remote/http/common' - autoload :Curb, 'selenium/webdriver/remote/http/curb' autoload :Default, 'selenium/webdriver/remote/http/default' end end diff --git a/rb/selenium-webdriver.gemspec b/rb/selenium-webdriver.gemspec index 3e15a42b9ce79..25a0babbd91a9 100644 --- a/rb/selenium-webdriver.gemspec +++ b/rb/selenium-webdriver.gemspec @@ -48,12 +48,12 @@ Gem::Specification.new do |s| s.require_paths = ['lib'] s.add_dependency 'base64', ['~> 0.2'] - s.add_dependency 'curb', ['~> 1.0.5'] s.add_dependency 'logger', ['~> 1.4'] s.add_dependency 'rexml', ['~> 3.2', '>= 3.2.5'] s.add_dependency 'rubyzip', ['>= 1.2.2', '< 3.0'] s.add_dependency 'websocket', ['~> 1.0'] + s.add_dependency 'curb', ['~> 1.0.5'] s.add_development_dependency 'git', ['~> 1.19'] s.add_development_dependency 'rack', ['~> 2.0'] s.add_development_dependency 'rake', ['~> 13.0'] From f37500a6fabfed51932e5421845124fe8179751b Mon Sep 17 00:00:00 2001 From: aguspe Date: Sun, 4 Aug 2024 17:58:35 +0200 Subject: [PATCH 03/33] Gemfile updated and loaded on spec --- rb/Gemfile.lock | 2 ++ rb/lib/selenium/webdriver/remote/http/curb.rb | 4 +--- rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/rb/Gemfile.lock b/rb/Gemfile.lock index a84d70b8d8b4d..4775b11f7bc8e 100644 --- a/rb/Gemfile.lock +++ b/rb/Gemfile.lock @@ -5,6 +5,7 @@ PATH selenium-webdriver (~> 4.2) selenium-webdriver (4.24.0.nightly) base64 (~> 0.2) + curb (~> 1.0.5) logger (~> 1.4) rexml (~> 3.2, >= 3.2.5) rubyzip (>= 1.2.2, < 3.0) @@ -35,6 +36,7 @@ GEM bigdecimal rexml csv (3.3.0) + curb (1.0.5) debug (1.9.2) irb (~> 1.10) reline (>= 0.3.8) diff --git a/rb/lib/selenium/webdriver/remote/http/curb.rb b/rb/lib/selenium/webdriver/remote/http/curb.rb index 71031c6abd90c..820c01f3f4ae6 100644 --- a/rb/lib/selenium/webdriver/remote/http/curb.rb +++ b/rb/lib/selenium/webdriver/remote/http/curb.rb @@ -94,9 +94,7 @@ def client c end end - end - - # Curb + end # Curb end # Http end # Remote end # WebDriver diff --git a/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb b/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb index c2cb41d9b7719..db5c7e36b5fb9 100644 --- a/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb +++ b/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb @@ -18,6 +18,7 @@ # under the License. require File.expand_path('../../spec_helper', __dir__) +load 'selenium/webdriver/remote/http/curb.rb' module Selenium module WebDriver From ef41b673ef7f94cd0cffe4ecdc3560328dd01cf8 Mon Sep 17 00:00:00 2001 From: aguspe Date: Sat, 10 Aug 2024 20:54:26 +0200 Subject: [PATCH 04/33] Update checksums --- MODULE.bazel | 73 ++++++++++++++++++++++++++-------------------------- 1 file changed, 37 insertions(+), 36 deletions(-) diff --git a/MODULE.bazel b/MODULE.bazel index 0ee03b3fc581c..69719768751fd 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -254,82 +254,83 @@ ruby.bundle_fetch( "//:rb/selenium-webdriver.gemspec", ], gem_checksums = { - "abbrev-0.1.2": "ad1b4eaaaed4cb722d5684d63949e4bde1d34f2a95e20db93aecfe7cbac74242", - "activesupport-7.1.3.2": "ad8445b7ae4a6d3acc5f88c8c5f437eb0b54062032aaf44856c7b6d3855b8b2e", - "addressable-2.8.6": "798f6af3556641a7619bad1dce04cdb6eb44b0216a991b0396ea7339276f2b47", + "activesupport-7.1.3.4": "455bbc43d82e5ba20daa25f0888b80c9f7e2d80ca0cc96cea3e6acfec3e40309", + "addressable-2.8.7": "462986537cf3735ab5f3c0f557f14155d778f4b43ea4f485a9deb9c8f7c58232", "ast-2.4.2": "1e280232e6a33754cde542bc5ef85520b74db2aac73ec14acef453784447cc12", "base64-0.2.0": "0f25e9b21a02a0cc0cea8ef92b2041035d39350946e8789c562b2d1a3da01507", - "bigdecimal-3.1.7": "e799b369a0005fc6d62eed7ef19139ac9bc319cc51470c637b9dcdf593600133", - "bigdecimal-3.1.7-java": "955f5c7aa90136874b494655e42ed70d81382abb0f49f1b42f374a1660e33c63", - "concurrent-ruby-1.2.3": "82fdd3f8a0816e28d513e637bb2b90a45d7b982bdf4f3a0511722d2e495801e2", + "bigdecimal-3.1.8": "a89467ed5a44f8ae01824af49cbc575871fa078332e8f77ea425725c1ffe27be", + "bigdecimal-3.1.8-java": "b9e94c14623fff8575f17a10320852219bbba92ecff4977571503d942687326e", + "concurrent-ruby-1.3.3": "4f9cd28965c4dcf83ffd3ea7304f9323277be8525819cb18a3b61edcb56a7c6a", "connection_pool-2.4.1": "0f40cf997091f1f04ff66da67eabd61a9fe0d4928b9a3645228532512fab62f4", "crack-1.0.0": "c83aefdb428cdc7b66c7f287e488c796f055c0839e6e545fec2c7047743c4a49", "csv-3.3.0": "0bbd1defdc31134abefed027a639b3723c2753862150f4c3ee61cab71b20d67d", + "curb-1.0.5": "2c4755dfb5d6190e9ebb4407b23ac5a5c2c226be1449e6d3bdf625656352efd1", "debug-1.9.2": "48e026c0852c7a10c60263e2e527968308958e266231e36d64e3efcabec7e7fc", "diff-lcs-1.5.1": "273223dfb40685548436d32b4733aa67351769c7dea621da7d9dd4813e63ddfe", "drb-2.2.1": "e9d472bf785f558b96b25358bae115646da0dbfd45107ad858b0bc0d935cb340", - "ffi-1.16.3": "6d3242ff10c87271b0675c58d68d3f10148fabc2ad6da52a18123f06078871fb", - "ffi-1.16.3-java": "6f107fcd7c96f9c96f7e57db749b99502cc2f65665f7b2241d087a8f8c01d42c", - "ffi-1.16.3-x64-mingw32": "6ec709011e3955e97033fa77907a8ab89a9150137d4c45c82c77399b909c9259", + "ffi-1.17.0": "51630e43425078311c056ca75f961bb3bda1641ab36e44ad4c455e0b0e4a231c", + "ffi-1.17.0-java": "f65f022616970fcde83fe176393eb873a7b959ef2703f94931cf0af6ab55ec7a", + "ffi-1.17.0-x86_64-darwin": "fdcd48c69db3303ef95aec5c64d6275fcf9878a02c0bec0afddc506ceca0f56b", "fileutils-1.7.2": "36a0fb324218263e52b486ad7408e9a295378fe8edc9fd343709e523c0980631", "git-1.19.1": "b0a422d9f6517353c48a330d6114de4db9e0c82dbe7202964a1d9f1fbc827d70", "hashdiff-1.1.0": "b5465f0e7375f1ee883f53a766ece4dbc764b7674a7c5ffd76e79b2f5f6fc9c9", - "i18n-1.14.4": "c7deedead0866ea9102975a4eab7968f53de50793a0c211a37808f75dd187551", + "i18n-1.14.5": "26dcbc05e364b57e27ab430148b3377bc413987d34cc042336271d8f42e9d1b9", "io-console-0.7.2": "f0dccff252f877a4f60d04a4dc6b442b185ebffb4b320ab69212a92b48a7a221", "io-console-0.7.2-java": "73aa382f8832b116613ceaf57b8ff5bf73dfedcaf39f0aa5420e10f63a4543ed", - "irb-1.12.0": "07634937fbb7d28d07e46da50d0aa43b4d2f7258174d08de4e32dfb57c10539d", + "irb-1.14.0": "53d805013bbd194874b8c13a56aca6aebcd11dd79166d88724f8a434fedde615", "jar-dependencies-0.4.1": "b2df2f1ecbff15334ce20ea7fdd5b8d8161faab67761ff72c7647d728e40d387", "json-2.7.2": "1898b5cbc81cd36c0fd4d0b7ad2682c39fb07c5ff682fc6265f678f550d4982c", "json-2.7.2-java": "138e3038b5361b3d06ee2e8aa2be00bed0d0de4ef5f1553fc5935e5b93aca7ee", "language_server-protocol-3.17.0.3": "3d5c58c02f44a20d972957a9febe386d7e7468ab3900ce6bd2b563dd910c6b3f", "listen-3.9.0": "db9e4424e0e5834480385197c139cb6b0ae0ef28cc13310cfd1ca78377d59c67", "logger-1.6.0": "0ab7c120262dd8de2a18cb8d377f1f318cbe98535160a508af9e7710ff43ef3e", - "minitest-5.22.3": "ea84676290cb5e2b4f31f25751af6050aa90d3e43e4337141c3e3e839611981e", + "minitest-5.24.1": "31ec31ac9088d9e21fcc5a5487912234de83966f24368241b2bef03d7012464a", "mutex_m-0.2.0": "b6ef0c6c842ede846f2ec0ade9e266b1a9dac0bc151682b04835e8ebd54840d5", - "parallel-1.24.0": "5bf38efb9b37865f8e93d7a762727f8c5fc5deb19949f4040c76481d5eee9397", - "parser-3.3.0.5": "7748313e505ca87045dc0465c776c802043f777581796eb79b1654c5d19d2687", + "parallel-1.25.1": "12e089b9aa36ea2343f6e93f18cfcebd031798253db8260590d26a7f70b1ab90", + "parser-3.3.4.0": "8d247769c3873fe92201d591a7463384022a1a25e214853df5d6806623179e82", "psych-5.1.2": "337322f58fc2bf24827d2b9bd5ab595f6a72971867d151bb39980060ea40a368", "psych-5.1.2-java": "1dd68dc609eddbc884e6892e11da942e16f7256bd30ebde9d35449d43043a6fe", - "public_suffix-5.0.5": "72c340218bb384610536919988705cc29e09749c0021fd7005f715c7e5dfc493", - "racc-1.7.3": "b785ab8a30ec43bce073c51dbbe791fd27000f68d1c996c95da98bf685316905", - "racc-1.7.3-java": "b2ad737e788cfa083263ce7c9290644bb0f2c691908249eb4f6eb48ed2815dbf", + "public_suffix-6.0.1": "61d44e1cab5cbbbe5b31068481cf16976dd0dc1b6b07bd95617ef8c5e3e00c6f", + "racc-1.8.1": "4a7f6929691dbec8b5209a0b373bc2614882b55fc5d2e447a21aaa691303d62f", + "racc-1.8.1-java": "54f2e6d1e1b91c154013277d986f52a90e5ececbe91465d29172e49342732b98", "rack-2.2.9": "fd6301a97a1c1e955e68f85c861fcb1cde6145a32c532e1ea321a72ff8cc4042", "rainbow-3.1.1": "039491aa3a89f42efa1d6dec2fc4e62ede96eb6acd95e52f1ad581182b79bc6a", "rake-13.2.1": "46cb38dae65d7d74b6020a4ac9d48afed8eb8149c040eccf0523bec91907059d", "rb-fsevent-0.11.2": "43900b972e7301d6570f64b850a5aa67833ee7d87b458ee92805d56b7318aefe", - "rb-inotify-0.10.1": "050062d4f31d307cca52c3f6a7f4b946df8de25fc4bd373e1a5142e41034a7ca", - "rbs-3.4.4": "1376d2604a00832641bb47521595e63a1c0d1cc241ded383ba48ddb4396de5a8", + "rb-inotify-0.11.1": "a0a700441239b0ff18eb65e3866236cd78613d6b9f78fea1f9ac47a85e47be6e", + "rbs-3.5.2": "ac4a0ff5de832402fc30324028e00c3e8914af3de0abcba7a5cf21d38602f3bb", "rchardet-1.8.0": "693acd5253d5ade81a51940697955f6dd4bb2f0d245bda76a8e23deec70a52c7", - "rdoc-6.6.3.1": "39f7b749229ab5ad9d21c81586151c1dd7a549fa8be4070ee09b524f9c656345", - "regexp_parser-2.9.0": "81a00ba141cec0d4b4bf58cb80cd9193e5180836d3fa6ef623f7886d3ba8bdd9", - "reline-0.5.3": "2c46747a1dfd03e100f0666d8a374cf2930c3e734298af9b39e5fe8d35b42035", - "rexml-3.2.6": "e0669a2d4e9f109951cb1fde723d8acd285425d81594a2ea929304af50282816", + "rdoc-6.7.0": "b17d5f0f57b0853d7b880d4360a32c7caf8dbb81f8503a36426df809e617f379", + "regexp_parser-2.9.2": "5a27e767ad634f8a4b544520d5cd28a0db7aa1198a5d7c9d7e11d7b3d9066446", + "reline-0.5.9": "5d2dd7ed0fd078e79a05e4eaa47dc91b8dacec7358e9e1dd6d9c4636cff7d378", + "rexml-3.3.2": "4513686f858d0ff2e5a412d734c8a192e16cb1df4cb2063f56b72a8ad4c5257f", "rspec-3.13.0": "d490914ac1d5a5a64a0e1400c1d54ddd2a501324d703b8cfe83f458337bab993", "rspec-core-3.13.0": "557792b4e88da883d580342b263d9652b6a10a12d5bda9ef967b01a48f15454c", - "rspec-expectations-3.13.0": "621d48c62262f955421eaa418130744760802cad47e781df70dba4d9f897102e", - "rspec-mocks-3.13.0": "735a891215758d77cdb5f4721fffc21078793959d1f0ee4a961874311d9b7f66", + "rspec-expectations-3.13.1": "814cf8dadc797b00be55a84d7bc390c082735e5c914e62cbe8d0e19774b74200", + "rspec-mocks-3.13.1": "087189899c337937bcf1d66a50dc3fc999ac88335bbeba4d385c2a38c87d7b38", "rspec-support-3.13.1": "48877d4f15b772b7538f3693c22225f2eda490ba65a0515c4e7cf6f2f17de70f", - "rubocop-1.63.3": "17a31f16658f2fbb20bc7bcb4a841a06f7368da4f3be8a50365ad61e658d5f44", - "rubocop-ast-1.31.2": "7c206fb094553779923eca862aceece3913ce384f1bf85730208228e884578ec", - "rubocop-capybara-2.20.0": "2a6844b942921f230ee3ab8c94fe77f41a9406096a140245270c0e11624bb938", - "rubocop-factory_bot-2.25.1": "62751bde7af789878b8a31cbd2a82e69515ce7b23a2ad1820cb0fcc3e0150134", - "rubocop-performance-1.21.0": "ec54fa8991c2d538af7bc958361d63bdb3df2e53032da393e9903ea5e4f74a9a", - "rubocop-rspec-2.29.1": "534ee81a3006e7379ec6203687ef7c06ca1d137b7d6d67c2777b680b1ce82e13", - "rubocop-rspec_rails-2.28.3": "9769f2077cca8af2269193ba0450e0317ae1827a132c19149fdbeecaaca32818", + "rubocop-1.65.0": "624316407a3f8e3999c6f75c528471ed3d4513ca39cec3bede1964c69630e4a1", + "rubocop-ast-1.31.3": "1b07d618d8776993ec6053a706d1c09f0bf15139fd69415924656cbff07e7818", + "rubocop-capybara-2.21.0": "5d264efdd8b6c7081a3d4889decf1451a1cfaaec204d81534e236bc825b280ab", + "rubocop-factory_bot-2.26.1": "8de13cd4edcee5ca800f255188167ecef8dbfc3d1fae9f15734e9d2e755392aa", + "rubocop-performance-1.21.1": "5cf20002a544275ad6aa99abca4b945d2a2ed71be925c38fe83700360ed8734e", + "rubocop-rake-0.6.0": "56b6f22189af4b33d4f4e490a555c09f1281b02f4d48c3a61f6e8fe5f401d8db", + "rubocop-rspec-2.31.0": "2bae19388d78e1ceace44cd95fd34f3209f4ef20cac1b168d0a1325cbba3d672", + "rubocop-rspec_rails-2.29.1": "4ae95abbe9ca5a9b6d8be14e50d230fb5b6ba033b05d4c0981b5b76fc44988e4", "ruby-progressbar-1.13.0": "80fc9c47a9b640d6834e0dc7b3c94c9df37f08cb072b7761e4a71e22cff29b33", "rubyzip-2.3.2": "3f57e3935dc2255c414484fbf8d673b4909d8a6a57007ed754dde39342d2373f", "securerandom-0.3.1": "98f0450c0ea46d2f9a4b6db4f391dbd83dc08049592eada155739f40e0341bde", "steep-1.5.3": "7c6302a4d5932d0a46176ebc79766e52b853c223a85525aa2f8911e345123b85", - "stringio-3.1.0": "c1f6263ae03a15025e51194ab19b06b15e06adcaaedb7f5f6c06ab60f5d67718", + "stringio-3.1.1": "53456e14175c594e0e8eb2206a1be33f3974d4fe21c131e628908b05c8c2ae1e", "strscan-3.1.0": "01b8a81d214fbf7b5308c6fb51b5972bbfc4a6aa1f166fd3618ba97e0fcd5555", "strscan-3.1.0-java": "8645aa76e017e21764c6df572d2d79fcc1672284014f5bdbd806278cdbcd11b0", "terminal-table-3.0.2": "f951b6af5f3e00203fb290a669e0a85c5dd5b051b3b023392ccfd67ba5abae91", "tzinfo-2.0.6": "8daf828cc77bcf7d63b0e3bdb6caa47e2272dcfaf4fbfe46f8c3a9df087a829b", "unicode-display_width-2.5.0": "7e7681dcade1add70cb9fda20dd77f300b8587c81ebbd165d14fd93144ff0ab4", - "webmock-3.23.0": "100787435c1f556129a238c11cc7cbee38cb9c2864709c6a0dcdcf822545f31f", + "webmock-3.23.1": "0fa738c0767d1c4ec8cc57f6b21998f0c238c8a5b32450df1c847f2767140d95", "webrick-1.8.1": "19411ec6912911fd3df13559110127ea2badd0c035f7762873f58afc803e158f", - "websocket-1.2.10": "2cc1a4a79b6e63637b326b4273e46adcddf7871caa5dc5711f2ca4061a629fa8", - "yard-0.9.36": "5505736c1b00c926f71053a606ab75f02070c5960d0778b901fe9d8b0a470be4", + "websocket-1.2.11": "b7e7a74e2410b5e85c25858b26b3322f29161e300935f70a0e0d3c35e0462737", + "yard-0.9.36": "5505736c1b00c926f71053a606ab75f02070c5960d0778b901fe9d8b0a470be4" }, gemfile = "//:rb/Gemfile", gemfile_lock = "//:rb/Gemfile.lock", From 1ab7a34388909fbfea325db33bccd8ed6c3a1b66 Mon Sep 17 00:00:00 2001 From: aguspe Date: Sat, 10 Aug 2024 22:30:00 +0200 Subject: [PATCH 05/33] Review comments updated --- rb/Gemfile.lock | 3 ++- rb/selenium-webdriver.gemspec | 2 +- rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/rb/Gemfile.lock b/rb/Gemfile.lock index 4775b11f7bc8e..331b4941fe2d9 100644 --- a/rb/Gemfile.lock +++ b/rb/Gemfile.lock @@ -5,7 +5,6 @@ PATH selenium-webdriver (~> 4.2) selenium-webdriver (4.24.0.nightly) base64 (~> 0.2) - curb (~> 1.0.5) logger (~> 1.4) rexml (~> 3.2, >= 3.2.5) rubyzip (>= 1.2.2, < 3.0) @@ -44,6 +43,7 @@ GEM drb (2.2.1) ffi (1.17.0) ffi (1.17.0-java) + ffi (1.17.0-x64-mingw32) ffi (1.17.0-x86_64-darwin) fileutils (1.7.2) git (1.19.1) @@ -181,6 +181,7 @@ PLATFORMS x86_64-darwin-22 DEPENDENCIES + curb (~> 1.0.5) debug (~> 1.7) git (~> 1.19) rack (~> 2.0) diff --git a/rb/selenium-webdriver.gemspec b/rb/selenium-webdriver.gemspec index 25a0babbd91a9..c8db32a0b68cc 100644 --- a/rb/selenium-webdriver.gemspec +++ b/rb/selenium-webdriver.gemspec @@ -53,7 +53,7 @@ Gem::Specification.new do |s| s.add_dependency 'rubyzip', ['>= 1.2.2', '< 3.0'] s.add_dependency 'websocket', ['~> 1.0'] - s.add_dependency 'curb', ['~> 1.0.5'] + s.add_development_dependency 'curb', ['~> 1.0.5'] s.add_development_dependency 'git', ['~> 1.19'] s.add_development_dependency 'rack', ['~> 2.0'] s.add_development_dependency 'rake', ['~> 13.0'] diff --git a/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb b/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb index db5c7e36b5fb9..6670e0c51af29 100644 --- a/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb +++ b/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb @@ -18,7 +18,7 @@ # under the License. require File.expand_path('../../spec_helper', __dir__) -load 'selenium/webdriver/remote/http/curb.rb' +require 'selenium/webdriver/remote/http/curb' module Selenium module WebDriver From c6ed50dcf12311bb759505ab8ed76af80b18a20f Mon Sep 17 00:00:00 2001 From: aguspe Date: Sat, 10 Aug 2024 23:42:15 +0200 Subject: [PATCH 06/33] Remove curb from jruby reference --- rb/Gemfile | 1 + rb/selenium-webdriver.gemspec | 1 - .../webdriver/remote/http/curb_spec.rb | 26 ++++++++++--------- 3 files changed, 15 insertions(+), 13 deletions(-) diff --git a/rb/Gemfile b/rb/Gemfile index 6607147e6e870..740e559bae308 100644 --- a/rb/Gemfile +++ b/rb/Gemfile @@ -5,5 +5,6 @@ Dir["#{__dir__}/*.gemspec"].each do |spec| gemspec name: File.basename(spec, '.gemspec') end +gem 'curb', '~> 1.0.5', require: false, platforms: %i[mri mingw x64_mingw] gem 'debug', '~> 1.7', require: false, platforms: %i[mri mingw x64_mingw] gem 'steep', '~> 1.5.0', require: false, platforms: %i[mri mingw x64_mingw] diff --git a/rb/selenium-webdriver.gemspec b/rb/selenium-webdriver.gemspec index c8db32a0b68cc..64a92dcb358fc 100644 --- a/rb/selenium-webdriver.gemspec +++ b/rb/selenium-webdriver.gemspec @@ -53,7 +53,6 @@ Gem::Specification.new do |s| s.add_dependency 'rubyzip', ['>= 1.2.2', '< 3.0'] s.add_dependency 'websocket', ['~> 1.0'] - s.add_development_dependency 'curb', ['~> 1.0.5'] s.add_development_dependency 'git', ['~> 1.19'] s.add_development_dependency 'rack', ['~> 2.0'] s.add_development_dependency 'rake', ['~> 13.0'] diff --git a/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb b/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb index 6670e0c51af29..558570219fcf9 100644 --- a/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb +++ b/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb @@ -27,22 +27,24 @@ module Http describe Curb do subject(:curb) { described_class.new } - it 'assigns default timeout to 0.0' do - http = curb.send :client + unless Platform.jruby? + it 'assigns default timeout to 0.0' do + http = curb.send :client - expect(http.timeout).to eq 0.0 - end + expect(http.timeout).to eq 0.0 + end - it 'sets the timeout' do - curb.timeout = 20 - expect(curb.timeout).to eq 20 - end + it 'sets the timeout' do + curb.timeout = 20 + expect(curb.timeout).to eq 20 + end - describe '#initialize' do - let(:curb) { described_class.new(timeout: 10) } + describe '#initialize' do + let(:curb) { described_class.new(timeout: 10) } - it 'is initialized with timeout' do - expect(curb.timeout).to eq 10 + it 'is initialized with timeout' do + expect(curb.timeout).to eq 10 + end end end end From 473a91392a5a51a69c42c6f5e72b7edcdbe76c0d Mon Sep 17 00:00:00 2001 From: aguspe Date: Sun, 11 Aug 2024 22:19:29 +0200 Subject: [PATCH 07/33] Guard for platforms not supporting curb --- rb/lib/selenium/webdriver/remote/http/curb.rb | 6 +++++- rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/rb/lib/selenium/webdriver/remote/http/curb.rb b/rb/lib/selenium/webdriver/remote/http/curb.rb index 820c01f3f4ae6..e93e80ac32705 100644 --- a/rb/lib/selenium/webdriver/remote/http/curb.rb +++ b/rb/lib/selenium/webdriver/remote/http/curb.rb @@ -17,7 +17,11 @@ # specific language governing permissions and limitations # under the License. -require 'curb' +begin + require 'curb' +rescue LoadError + # Curb is not supported by the platform +end module Selenium module WebDriver diff --git a/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb b/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb index 558570219fcf9..3847e9929b89d 100644 --- a/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb +++ b/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb @@ -27,7 +27,7 @@ module Http describe Curb do subject(:curb) { described_class.new } - unless Platform.jruby? + unless Platform.jruby? || Platform.windows? || Platform.linux? it 'assigns default timeout to 0.0' do http = curb.send :client From 0066cb28d09b5ba45541d28a8f7fbfd303fddb61 Mon Sep 17 00:00:00 2001 From: aguspe Date: Sun, 11 Aug 2024 22:54:33 +0200 Subject: [PATCH 08/33] Use only darwin as a platform for curb --- rb/Gemfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rb/Gemfile b/rb/Gemfile index 740e559bae308..dccdf94e1268f 100644 --- a/rb/Gemfile +++ b/rb/Gemfile @@ -5,6 +5,6 @@ Dir["#{__dir__}/*.gemspec"].each do |spec| gemspec name: File.basename(spec, '.gemspec') end -gem 'curb', '~> 1.0.5', require: false, platforms: %i[mri mingw x64_mingw] +gem 'curb', '~> 1.0.5', require: false, platforms: %i[darwin] gem 'debug', '~> 1.7', require: false, platforms: %i[mri mingw x64_mingw] gem 'steep', '~> 1.5.0', require: false, platforms: %i[mri mingw x64_mingw] From 5e128500434f7ad200f6ce8231aa8ae5c3a7f3bf Mon Sep 17 00:00:00 2001 From: aguspe Date: Fri, 16 Aug 2024 07:43:52 +0200 Subject: [PATCH 09/33] Add conditional for curb --- rb/Gemfile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rb/Gemfile b/rb/Gemfile index dccdf94e1268f..52f24da62eb23 100644 --- a/rb/Gemfile +++ b/rb/Gemfile @@ -5,6 +5,7 @@ Dir["#{__dir__}/*.gemspec"].each do |spec| gemspec name: File.basename(spec, '.gemspec') end -gem 'curb', '~> 1.0.5', require: false, platforms: %i[darwin] + +gem 'curb', '~> 1.0.5', require: false, platforms: :mri if RUBY_PLATFORM.include?('darwin') gem 'debug', '~> 1.7', require: false, platforms: %i[mri mingw x64_mingw] gem 'steep', '~> 1.5.0', require: false, platforms: %i[mri mingw x64_mingw] From 33720651c356779269a8bd73365e6f2ea749c386 Mon Sep 17 00:00:00 2001 From: aguspe Date: Fri, 16 Aug 2024 08:09:57 +0200 Subject: [PATCH 10/33] Add libcurl installation --- .github/workflows/bazel.yml | 3 +++ rb/Gemfile | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/bazel.yml b/.github/workflows/bazel.yml index 41a100327c9db..00b0dfd929ebe 100644 --- a/.github/workflows/bazel.yml +++ b/.github/workflows/bazel.yml @@ -146,6 +146,9 @@ jobs: - name: Setup Safari if: inputs.browser == 'safari' run: sudo safaridriver --enable + - name: Setup libcurl + if: inputs.os == 'linux' + run: sudo apt-get update && sudo apt-get install -y libcurl4-openssl-dev - name: Run Bazel run: ${{ inputs.run }} - name: Start SSH session diff --git a/rb/Gemfile b/rb/Gemfile index 52f24da62eb23..3c5159d6f22f1 100644 --- a/rb/Gemfile +++ b/rb/Gemfile @@ -6,6 +6,6 @@ Dir["#{__dir__}/*.gemspec"].each do |spec| end -gem 'curb', '~> 1.0.5', require: false, platforms: :mri if RUBY_PLATFORM.include?('darwin') +gem 'curb', '~> 1.0.5', require: false, platforms: :mri gem 'debug', '~> 1.7', require: false, platforms: %i[mri mingw x64_mingw] gem 'steep', '~> 1.5.0', require: false, platforms: %i[mri mingw x64_mingw] From 60aa9fee69f87f027ad9e78d60713b6e7246826b Mon Sep 17 00:00:00 2001 From: aguspe Date: Fri, 16 Aug 2024 09:53:18 +0200 Subject: [PATCH 11/33] Update checksums and bazel lib curl step --- .github/workflows/bazel.yml | 2 +- MODULE.bazel | 159 ++++++++++++++++++------------------ 2 files changed, 81 insertions(+), 80 deletions(-) diff --git a/.github/workflows/bazel.yml b/.github/workflows/bazel.yml index 00b0dfd929ebe..b79e0e20b48ac 100644 --- a/.github/workflows/bazel.yml +++ b/.github/workflows/bazel.yml @@ -147,7 +147,7 @@ jobs: if: inputs.browser == 'safari' run: sudo safaridriver --enable - name: Setup libcurl - if: inputs.os == 'linux' + if: inputs.os == 'ubuntu' run: sudo apt-get update && sudo apt-get install -y libcurl4-openssl-dev - name: Run Bazel run: ${{ inputs.run }} diff --git a/MODULE.bazel b/MODULE.bazel index 69719768751fd..17cc6bf101c9e 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -253,85 +253,86 @@ ruby.bundle_fetch( "//:rb/selenium-devtools.gemspec", "//:rb/selenium-webdriver.gemspec", ], - gem_checksums = { - "activesupport-7.1.3.4": "455bbc43d82e5ba20daa25f0888b80c9f7e2d80ca0cc96cea3e6acfec3e40309", - "addressable-2.8.7": "462986537cf3735ab5f3c0f557f14155d778f4b43ea4f485a9deb9c8f7c58232", - "ast-2.4.2": "1e280232e6a33754cde542bc5ef85520b74db2aac73ec14acef453784447cc12", - "base64-0.2.0": "0f25e9b21a02a0cc0cea8ef92b2041035d39350946e8789c562b2d1a3da01507", - "bigdecimal-3.1.8": "a89467ed5a44f8ae01824af49cbc575871fa078332e8f77ea425725c1ffe27be", - "bigdecimal-3.1.8-java": "b9e94c14623fff8575f17a10320852219bbba92ecff4977571503d942687326e", - "concurrent-ruby-1.3.3": "4f9cd28965c4dcf83ffd3ea7304f9323277be8525819cb18a3b61edcb56a7c6a", - "connection_pool-2.4.1": "0f40cf997091f1f04ff66da67eabd61a9fe0d4928b9a3645228532512fab62f4", - "crack-1.0.0": "c83aefdb428cdc7b66c7f287e488c796f055c0839e6e545fec2c7047743c4a49", - "csv-3.3.0": "0bbd1defdc31134abefed027a639b3723c2753862150f4c3ee61cab71b20d67d", - "curb-1.0.5": "2c4755dfb5d6190e9ebb4407b23ac5a5c2c226be1449e6d3bdf625656352efd1", - "debug-1.9.2": "48e026c0852c7a10c60263e2e527968308958e266231e36d64e3efcabec7e7fc", - "diff-lcs-1.5.1": "273223dfb40685548436d32b4733aa67351769c7dea621da7d9dd4813e63ddfe", - "drb-2.2.1": "e9d472bf785f558b96b25358bae115646da0dbfd45107ad858b0bc0d935cb340", - "ffi-1.17.0": "51630e43425078311c056ca75f961bb3bda1641ab36e44ad4c455e0b0e4a231c", - "ffi-1.17.0-java": "f65f022616970fcde83fe176393eb873a7b959ef2703f94931cf0af6ab55ec7a", - "ffi-1.17.0-x86_64-darwin": "fdcd48c69db3303ef95aec5c64d6275fcf9878a02c0bec0afddc506ceca0f56b", - "fileutils-1.7.2": "36a0fb324218263e52b486ad7408e9a295378fe8edc9fd343709e523c0980631", - "git-1.19.1": "b0a422d9f6517353c48a330d6114de4db9e0c82dbe7202964a1d9f1fbc827d70", - "hashdiff-1.1.0": "b5465f0e7375f1ee883f53a766ece4dbc764b7674a7c5ffd76e79b2f5f6fc9c9", - "i18n-1.14.5": "26dcbc05e364b57e27ab430148b3377bc413987d34cc042336271d8f42e9d1b9", - "io-console-0.7.2": "f0dccff252f877a4f60d04a4dc6b442b185ebffb4b320ab69212a92b48a7a221", - "io-console-0.7.2-java": "73aa382f8832b116613ceaf57b8ff5bf73dfedcaf39f0aa5420e10f63a4543ed", - "irb-1.14.0": "53d805013bbd194874b8c13a56aca6aebcd11dd79166d88724f8a434fedde615", - "jar-dependencies-0.4.1": "b2df2f1ecbff15334ce20ea7fdd5b8d8161faab67761ff72c7647d728e40d387", - "json-2.7.2": "1898b5cbc81cd36c0fd4d0b7ad2682c39fb07c5ff682fc6265f678f550d4982c", - "json-2.7.2-java": "138e3038b5361b3d06ee2e8aa2be00bed0d0de4ef5f1553fc5935e5b93aca7ee", - "language_server-protocol-3.17.0.3": "3d5c58c02f44a20d972957a9febe386d7e7468ab3900ce6bd2b563dd910c6b3f", - "listen-3.9.0": "db9e4424e0e5834480385197c139cb6b0ae0ef28cc13310cfd1ca78377d59c67", - "logger-1.6.0": "0ab7c120262dd8de2a18cb8d377f1f318cbe98535160a508af9e7710ff43ef3e", - "minitest-5.24.1": "31ec31ac9088d9e21fcc5a5487912234de83966f24368241b2bef03d7012464a", - "mutex_m-0.2.0": "b6ef0c6c842ede846f2ec0ade9e266b1a9dac0bc151682b04835e8ebd54840d5", - "parallel-1.25.1": "12e089b9aa36ea2343f6e93f18cfcebd031798253db8260590d26a7f70b1ab90", - "parser-3.3.4.0": "8d247769c3873fe92201d591a7463384022a1a25e214853df5d6806623179e82", - "psych-5.1.2": "337322f58fc2bf24827d2b9bd5ab595f6a72971867d151bb39980060ea40a368", - "psych-5.1.2-java": "1dd68dc609eddbc884e6892e11da942e16f7256bd30ebde9d35449d43043a6fe", - "public_suffix-6.0.1": "61d44e1cab5cbbbe5b31068481cf16976dd0dc1b6b07bd95617ef8c5e3e00c6f", - "racc-1.8.1": "4a7f6929691dbec8b5209a0b373bc2614882b55fc5d2e447a21aaa691303d62f", - "racc-1.8.1-java": "54f2e6d1e1b91c154013277d986f52a90e5ececbe91465d29172e49342732b98", - "rack-2.2.9": "fd6301a97a1c1e955e68f85c861fcb1cde6145a32c532e1ea321a72ff8cc4042", - "rainbow-3.1.1": "039491aa3a89f42efa1d6dec2fc4e62ede96eb6acd95e52f1ad581182b79bc6a", - "rake-13.2.1": "46cb38dae65d7d74b6020a4ac9d48afed8eb8149c040eccf0523bec91907059d", - "rb-fsevent-0.11.2": "43900b972e7301d6570f64b850a5aa67833ee7d87b458ee92805d56b7318aefe", - "rb-inotify-0.11.1": "a0a700441239b0ff18eb65e3866236cd78613d6b9f78fea1f9ac47a85e47be6e", - "rbs-3.5.2": "ac4a0ff5de832402fc30324028e00c3e8914af3de0abcba7a5cf21d38602f3bb", - "rchardet-1.8.0": "693acd5253d5ade81a51940697955f6dd4bb2f0d245bda76a8e23deec70a52c7", - "rdoc-6.7.0": "b17d5f0f57b0853d7b880d4360a32c7caf8dbb81f8503a36426df809e617f379", - "regexp_parser-2.9.2": "5a27e767ad634f8a4b544520d5cd28a0db7aa1198a5d7c9d7e11d7b3d9066446", - "reline-0.5.9": "5d2dd7ed0fd078e79a05e4eaa47dc91b8dacec7358e9e1dd6d9c4636cff7d378", - "rexml-3.3.2": "4513686f858d0ff2e5a412d734c8a192e16cb1df4cb2063f56b72a8ad4c5257f", - "rspec-3.13.0": "d490914ac1d5a5a64a0e1400c1d54ddd2a501324d703b8cfe83f458337bab993", - "rspec-core-3.13.0": "557792b4e88da883d580342b263d9652b6a10a12d5bda9ef967b01a48f15454c", - "rspec-expectations-3.13.1": "814cf8dadc797b00be55a84d7bc390c082735e5c914e62cbe8d0e19774b74200", - "rspec-mocks-3.13.1": "087189899c337937bcf1d66a50dc3fc999ac88335bbeba4d385c2a38c87d7b38", - "rspec-support-3.13.1": "48877d4f15b772b7538f3693c22225f2eda490ba65a0515c4e7cf6f2f17de70f", - "rubocop-1.65.0": "624316407a3f8e3999c6f75c528471ed3d4513ca39cec3bede1964c69630e4a1", - "rubocop-ast-1.31.3": "1b07d618d8776993ec6053a706d1c09f0bf15139fd69415924656cbff07e7818", - "rubocop-capybara-2.21.0": "5d264efdd8b6c7081a3d4889decf1451a1cfaaec204d81534e236bc825b280ab", - "rubocop-factory_bot-2.26.1": "8de13cd4edcee5ca800f255188167ecef8dbfc3d1fae9f15734e9d2e755392aa", - "rubocop-performance-1.21.1": "5cf20002a544275ad6aa99abca4b945d2a2ed71be925c38fe83700360ed8734e", - "rubocop-rake-0.6.0": "56b6f22189af4b33d4f4e490a555c09f1281b02f4d48c3a61f6e8fe5f401d8db", - "rubocop-rspec-2.31.0": "2bae19388d78e1ceace44cd95fd34f3209f4ef20cac1b168d0a1325cbba3d672", - "rubocop-rspec_rails-2.29.1": "4ae95abbe9ca5a9b6d8be14e50d230fb5b6ba033b05d4c0981b5b76fc44988e4", - "ruby-progressbar-1.13.0": "80fc9c47a9b640d6834e0dc7b3c94c9df37f08cb072b7761e4a71e22cff29b33", - "rubyzip-2.3.2": "3f57e3935dc2255c414484fbf8d673b4909d8a6a57007ed754dde39342d2373f", - "securerandom-0.3.1": "98f0450c0ea46d2f9a4b6db4f391dbd83dc08049592eada155739f40e0341bde", - "steep-1.5.3": "7c6302a4d5932d0a46176ebc79766e52b853c223a85525aa2f8911e345123b85", - "stringio-3.1.1": "53456e14175c594e0e8eb2206a1be33f3974d4fe21c131e628908b05c8c2ae1e", - "strscan-3.1.0": "01b8a81d214fbf7b5308c6fb51b5972bbfc4a6aa1f166fd3618ba97e0fcd5555", - "strscan-3.1.0-java": "8645aa76e017e21764c6df572d2d79fcc1672284014f5bdbd806278cdbcd11b0", - "terminal-table-3.0.2": "f951b6af5f3e00203fb290a669e0a85c5dd5b051b3b023392ccfd67ba5abae91", - "tzinfo-2.0.6": "8daf828cc77bcf7d63b0e3bdb6caa47e2272dcfaf4fbfe46f8c3a9df087a829b", - "unicode-display_width-2.5.0": "7e7681dcade1add70cb9fda20dd77f300b8587c81ebbd165d14fd93144ff0ab4", - "webmock-3.23.1": "0fa738c0767d1c4ec8cc57f6b21998f0c238c8a5b32450df1c847f2767140d95", - "webrick-1.8.1": "19411ec6912911fd3df13559110127ea2badd0c035f7762873f58afc803e158f", - "websocket-1.2.11": "b7e7a74e2410b5e85c25858b26b3322f29161e300935f70a0e0d3c35e0462737", - "yard-0.9.36": "5505736c1b00c926f71053a606ab75f02070c5960d0778b901fe9d8b0a470be4" - }, + gem_checksums = { + "activesupport-7.1.3.4": "455bbc43d82e5ba20daa25f0888b80c9f7e2d80ca0cc96cea3e6acfec3e40309", + "addressable-2.8.7": "462986537cf3735ab5f3c0f557f14155d778f4b43ea4f485a9deb9c8f7c58232", + "ast-2.4.2": "1e280232e6a33754cde542bc5ef85520b74db2aac73ec14acef453784447cc12", + "base64-0.2.0": "0f25e9b21a02a0cc0cea8ef92b2041035d39350946e8789c562b2d1a3da01507", + "bigdecimal-3.1.8": "a89467ed5a44f8ae01824af49cbc575871fa078332e8f77ea425725c1ffe27be", + "bigdecimal-3.1.8-java": "b9e94c14623fff8575f17a10320852219bbba92ecff4977571503d942687326e", + "concurrent-ruby-1.3.3": "4f9cd28965c4dcf83ffd3ea7304f9323277be8525819cb18a3b61edcb56a7c6a", + "connection_pool-2.4.1": "0f40cf997091f1f04ff66da67eabd61a9fe0d4928b9a3645228532512fab62f4", + "crack-1.0.0": "c83aefdb428cdc7b66c7f287e488c796f055c0839e6e545fec2c7047743c4a49", + "csv-3.3.0": "0bbd1defdc31134abefed027a639b3723c2753862150f4c3ee61cab71b20d67d", + "curb-1.0.5": "2c4755dfb5d6190e9ebb4407b23ac5a5c2c226be1449e6d3bdf625656352efd1", + "debug-1.9.2": "48e026c0852c7a10c60263e2e527968308958e266231e36d64e3efcabec7e7fc", + "diff-lcs-1.5.1": "273223dfb40685548436d32b4733aa67351769c7dea621da7d9dd4813e63ddfe", + "drb-2.2.1": "e9d472bf785f558b96b25358bae115646da0dbfd45107ad858b0bc0d935cb340", + "ffi-1.17.0": "51630e43425078311c056ca75f961bb3bda1641ab36e44ad4c455e0b0e4a231c", + "ffi-1.17.0-java": "f65f022616970fcde83fe176393eb873a7b959ef2703f94931cf0af6ab55ec7a", + "ffi-1.17.0-x64-mingw32": "63c9b1c847036550c655237526c151ee535dbbeb638e70d9dd3ccbc6104c713b", + "ffi-1.17.0-x86_64-darwin": "fdcd48c69db3303ef95aec5c64d6275fcf9878a02c0bec0afddc506ceca0f56b", + "fileutils-1.7.2": "36a0fb324218263e52b486ad7408e9a295378fe8edc9fd343709e523c0980631", + "git-1.19.1": "b0a422d9f6517353c48a330d6114de4db9e0c82dbe7202964a1d9f1fbc827d70", + "hashdiff-1.1.0": "b5465f0e7375f1ee883f53a766ece4dbc764b7674a7c5ffd76e79b2f5f6fc9c9", + "i18n-1.14.5": "26dcbc05e364b57e27ab430148b3377bc413987d34cc042336271d8f42e9d1b9", + "io-console-0.7.2": "f0dccff252f877a4f60d04a4dc6b442b185ebffb4b320ab69212a92b48a7a221", + "io-console-0.7.2-java": "73aa382f8832b116613ceaf57b8ff5bf73dfedcaf39f0aa5420e10f63a4543ed", + "irb-1.14.0": "53d805013bbd194874b8c13a56aca6aebcd11dd79166d88724f8a434fedde615", + "jar-dependencies-0.4.1": "b2df2f1ecbff15334ce20ea7fdd5b8d8161faab67761ff72c7647d728e40d387", + "json-2.7.2": "1898b5cbc81cd36c0fd4d0b7ad2682c39fb07c5ff682fc6265f678f550d4982c", + "json-2.7.2-java": "138e3038b5361b3d06ee2e8aa2be00bed0d0de4ef5f1553fc5935e5b93aca7ee", + "language_server-protocol-3.17.0.3": "3d5c58c02f44a20d972957a9febe386d7e7468ab3900ce6bd2b563dd910c6b3f", + "listen-3.9.0": "db9e4424e0e5834480385197c139cb6b0ae0ef28cc13310cfd1ca78377d59c67", + "logger-1.6.0": "0ab7c120262dd8de2a18cb8d377f1f318cbe98535160a508af9e7710ff43ef3e", + "minitest-5.24.1": "31ec31ac9088d9e21fcc5a5487912234de83966f24368241b2bef03d7012464a", + "mutex_m-0.2.0": "b6ef0c6c842ede846f2ec0ade9e266b1a9dac0bc151682b04835e8ebd54840d5", + "parallel-1.25.1": "12e089b9aa36ea2343f6e93f18cfcebd031798253db8260590d26a7f70b1ab90", + "parser-3.3.4.0": "8d247769c3873fe92201d591a7463384022a1a25e214853df5d6806623179e82", + "psych-5.1.2": "337322f58fc2bf24827d2b9bd5ab595f6a72971867d151bb39980060ea40a368", + "psych-5.1.2-java": "1dd68dc609eddbc884e6892e11da942e16f7256bd30ebde9d35449d43043a6fe", + "public_suffix-6.0.1": "61d44e1cab5cbbbe5b31068481cf16976dd0dc1b6b07bd95617ef8c5e3e00c6f", + "racc-1.8.1": "4a7f6929691dbec8b5209a0b373bc2614882b55fc5d2e447a21aaa691303d62f", + "racc-1.8.1-java": "54f2e6d1e1b91c154013277d986f52a90e5ececbe91465d29172e49342732b98", + "rack-2.2.9": "fd6301a97a1c1e955e68f85c861fcb1cde6145a32c532e1ea321a72ff8cc4042", + "rainbow-3.1.1": "039491aa3a89f42efa1d6dec2fc4e62ede96eb6acd95e52f1ad581182b79bc6a", + "rake-13.2.1": "46cb38dae65d7d74b6020a4ac9d48afed8eb8149c040eccf0523bec91907059d", + "rb-fsevent-0.11.2": "43900b972e7301d6570f64b850a5aa67833ee7d87b458ee92805d56b7318aefe", + "rb-inotify-0.11.1": "a0a700441239b0ff18eb65e3866236cd78613d6b9f78fea1f9ac47a85e47be6e", + "rbs-3.5.2": "ac4a0ff5de832402fc30324028e00c3e8914af3de0abcba7a5cf21d38602f3bb", + "rchardet-1.8.0": "693acd5253d5ade81a51940697955f6dd4bb2f0d245bda76a8e23deec70a52c7", + "rdoc-6.7.0": "b17d5f0f57b0853d7b880d4360a32c7caf8dbb81f8503a36426df809e617f379", + "regexp_parser-2.9.2": "5a27e767ad634f8a4b544520d5cd28a0db7aa1198a5d7c9d7e11d7b3d9066446", + "reline-0.5.9": "5d2dd7ed0fd078e79a05e4eaa47dc91b8dacec7358e9e1dd6d9c4636cff7d378", + "rexml-3.3.2": "4513686f858d0ff2e5a412d734c8a192e16cb1df4cb2063f56b72a8ad4c5257f", + "rspec-3.13.0": "d490914ac1d5a5a64a0e1400c1d54ddd2a501324d703b8cfe83f458337bab993", + "rspec-core-3.13.0": "557792b4e88da883d580342b263d9652b6a10a12d5bda9ef967b01a48f15454c", + "rspec-expectations-3.13.1": "814cf8dadc797b00be55a84d7bc390c082735e5c914e62cbe8d0e19774b74200", + "rspec-mocks-3.13.1": "087189899c337937bcf1d66a50dc3fc999ac88335bbeba4d385c2a38c87d7b38", + "rspec-support-3.13.1": "48877d4f15b772b7538f3693c22225f2eda490ba65a0515c4e7cf6f2f17de70f", + "rubocop-1.65.0": "624316407a3f8e3999c6f75c528471ed3d4513ca39cec3bede1964c69630e4a1", + "rubocop-ast-1.31.3": "1b07d618d8776993ec6053a706d1c09f0bf15139fd69415924656cbff07e7818", + "rubocop-capybara-2.21.0": "5d264efdd8b6c7081a3d4889decf1451a1cfaaec204d81534e236bc825b280ab", + "rubocop-factory_bot-2.26.1": "8de13cd4edcee5ca800f255188167ecef8dbfc3d1fae9f15734e9d2e755392aa", + "rubocop-performance-1.21.1": "5cf20002a544275ad6aa99abca4b945d2a2ed71be925c38fe83700360ed8734e", + "rubocop-rake-0.6.0": "56b6f22189af4b33d4f4e490a555c09f1281b02f4d48c3a61f6e8fe5f401d8db", + "rubocop-rspec-2.31.0": "2bae19388d78e1ceace44cd95fd34f3209f4ef20cac1b168d0a1325cbba3d672", + "rubocop-rspec_rails-2.29.1": "4ae95abbe9ca5a9b6d8be14e50d230fb5b6ba033b05d4c0981b5b76fc44988e4", + "ruby-progressbar-1.13.0": "80fc9c47a9b640d6834e0dc7b3c94c9df37f08cb072b7761e4a71e22cff29b33", + "rubyzip-2.3.2": "3f57e3935dc2255c414484fbf8d673b4909d8a6a57007ed754dde39342d2373f", + "securerandom-0.3.1": "98f0450c0ea46d2f9a4b6db4f391dbd83dc08049592eada155739f40e0341bde", + "steep-1.5.3": "7c6302a4d5932d0a46176ebc79766e52b853c223a85525aa2f8911e345123b85", + "stringio-3.1.1": "53456e14175c594e0e8eb2206a1be33f3974d4fe21c131e628908b05c8c2ae1e", + "strscan-3.1.0": "01b8a81d214fbf7b5308c6fb51b5972bbfc4a6aa1f166fd3618ba97e0fcd5555", + "strscan-3.1.0-java": "8645aa76e017e21764c6df572d2d79fcc1672284014f5bdbd806278cdbcd11b0", + "terminal-table-3.0.2": "f951b6af5f3e00203fb290a669e0a85c5dd5b051b3b023392ccfd67ba5abae91", + "tzinfo-2.0.6": "8daf828cc77bcf7d63b0e3bdb6caa47e2272dcfaf4fbfe46f8c3a9df087a829b", + "unicode-display_width-2.5.0": "7e7681dcade1add70cb9fda20dd77f300b8587c81ebbd165d14fd93144ff0ab4", + "webmock-3.23.1": "0fa738c0767d1c4ec8cc57f6b21998f0c238c8a5b32450df1c847f2767140d95", + "webrick-1.8.1": "19411ec6912911fd3df13559110127ea2badd0c035f7762873f58afc803e158f", + "websocket-1.2.11": "b7e7a74e2410b5e85c25858b26b3322f29161e300935f70a0e0d3c35e0462737", + "yard-0.9.36": "5505736c1b00c926f71053a606ab75f02070c5960d0778b901fe9d8b0a470be4" + }, gemfile = "//:rb/Gemfile", gemfile_lock = "//:rb/Gemfile.lock", ) From 6738d3c511d8642353b0f4f9d7500ec32e9635d2 Mon Sep 17 00:00:00 2001 From: aguspe Date: Fri, 16 Aug 2024 10:13:12 +0200 Subject: [PATCH 12/33] Remove extra space line --- rb/Gemfile | 1 - 1 file changed, 1 deletion(-) diff --git a/rb/Gemfile b/rb/Gemfile index 3c5159d6f22f1..7c3b68be14a44 100644 --- a/rb/Gemfile +++ b/rb/Gemfile @@ -5,7 +5,6 @@ Dir["#{__dir__}/*.gemspec"].each do |spec| gemspec name: File.basename(spec, '.gemspec') end - gem 'curb', '~> 1.0.5', require: false, platforms: :mri gem 'debug', '~> 1.7', require: false, platforms: %i[mri mingw x64_mingw] gem 'steep', '~> 1.5.0', require: false, platforms: %i[mri mingw x64_mingw] From 0b39528daced1ed2d728a5cc31052d8366441001 Mon Sep 17 00:00:00 2001 From: aguspe Date: Fri, 16 Aug 2024 11:44:20 +0200 Subject: [PATCH 13/33] FIx format and add windows curl --- .github/workflows/bazel.yml | 8 +++++++- rb/Gemfile | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/bazel.yml b/.github/workflows/bazel.yml index b79e0e20b48ac..b7175af82ae5e 100644 --- a/.github/workflows/bazel.yml +++ b/.github/workflows/bazel.yml @@ -146,9 +146,15 @@ jobs: - name: Setup Safari if: inputs.browser == 'safari' run: sudo safaridriver --enable - - name: Setup libcurl + - name: Setup curl for Ubuntu if: inputs.os == 'ubuntu' run: sudo apt-get update && sudo apt-get install -y libcurl4-openssl-dev + - name: Setup curl for Windows + if: inputs.os == 'windows' + uses: crazy-max/ghaction-chocolatey@v3 + run: choco install curl + with: + args: '' - name: Run Bazel run: ${{ inputs.run }} - name: Start SSH session diff --git a/rb/Gemfile b/rb/Gemfile index 7c3b68be14a44..740e559bae308 100644 --- a/rb/Gemfile +++ b/rb/Gemfile @@ -5,6 +5,6 @@ Dir["#{__dir__}/*.gemspec"].each do |spec| gemspec name: File.basename(spec, '.gemspec') end -gem 'curb', '~> 1.0.5', require: false, platforms: :mri +gem 'curb', '~> 1.0.5', require: false, platforms: %i[mri mingw x64_mingw] gem 'debug', '~> 1.7', require: false, platforms: %i[mri mingw x64_mingw] gem 'steep', '~> 1.5.0', require: false, platforms: %i[mri mingw x64_mingw] From ff7941c27e2dbfc8fb456d6d66e1b28a6aaaa21d Mon Sep 17 00:00:00 2001 From: aguspe Date: Fri, 16 Aug 2024 12:07:40 +0200 Subject: [PATCH 14/33] Fix chocolatey --- .github/workflows/bazel.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/bazel.yml b/.github/workflows/bazel.yml index b7175af82ae5e..0c8f50c664546 100644 --- a/.github/workflows/bazel.yml +++ b/.github/workflows/bazel.yml @@ -152,9 +152,8 @@ jobs: - name: Setup curl for Windows if: inputs.os == 'windows' uses: crazy-max/ghaction-chocolatey@v3 - run: choco install curl with: - args: '' + args: 'install curl' - name: Run Bazel run: ${{ inputs.run }} - name: Start SSH session From 62e48c033fcd39d141f873c8e44c84908727b687 Mon Sep 17 00:00:00 2001 From: aguspe Date: Fri, 16 Aug 2024 12:38:09 +0200 Subject: [PATCH 15/33] Fix format --- MODULE.bazel | 207 ++++++++++++++++++++++++++++++--------------------- 1 file changed, 121 insertions(+), 86 deletions(-) diff --git a/MODULE.bazel b/MODULE.bazel index 17cc6bf101c9e..446a1ab049835 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -250,92 +250,127 @@ ruby.bundle_fetch( srcs = [ "//:rb/lib/selenium/devtools/version.rb", "//:rb/lib/selenium/webdriver/version.rb", - "//:rb/selenium-devtools.gemspec", - "//:rb/selenium-webdriver.gemspec", - ], - gem_checksums = { - "activesupport-7.1.3.4": "455bbc43d82e5ba20daa25f0888b80c9f7e2d80ca0cc96cea3e6acfec3e40309", - "addressable-2.8.7": "462986537cf3735ab5f3c0f557f14155d778f4b43ea4f485a9deb9c8f7c58232", - "ast-2.4.2": "1e280232e6a33754cde542bc5ef85520b74db2aac73ec14acef453784447cc12", - "base64-0.2.0": "0f25e9b21a02a0cc0cea8ef92b2041035d39350946e8789c562b2d1a3da01507", - "bigdecimal-3.1.8": "a89467ed5a44f8ae01824af49cbc575871fa078332e8f77ea425725c1ffe27be", - "bigdecimal-3.1.8-java": "b9e94c14623fff8575f17a10320852219bbba92ecff4977571503d942687326e", - "concurrent-ruby-1.3.3": "4f9cd28965c4dcf83ffd3ea7304f9323277be8525819cb18a3b61edcb56a7c6a", - "connection_pool-2.4.1": "0f40cf997091f1f04ff66da67eabd61a9fe0d4928b9a3645228532512fab62f4", - "crack-1.0.0": "c83aefdb428cdc7b66c7f287e488c796f055c0839e6e545fec2c7047743c4a49", - "csv-3.3.0": "0bbd1defdc31134abefed027a639b3723c2753862150f4c3ee61cab71b20d67d", - "curb-1.0.5": "2c4755dfb5d6190e9ebb4407b23ac5a5c2c226be1449e6d3bdf625656352efd1", - "debug-1.9.2": "48e026c0852c7a10c60263e2e527968308958e266231e36d64e3efcabec7e7fc", - "diff-lcs-1.5.1": "273223dfb40685548436d32b4733aa67351769c7dea621da7d9dd4813e63ddfe", - "drb-2.2.1": "e9d472bf785f558b96b25358bae115646da0dbfd45107ad858b0bc0d935cb340", - "ffi-1.17.0": "51630e43425078311c056ca75f961bb3bda1641ab36e44ad4c455e0b0e4a231c", - "ffi-1.17.0-java": "f65f022616970fcde83fe176393eb873a7b959ef2703f94931cf0af6ab55ec7a", - "ffi-1.17.0-x64-mingw32": "63c9b1c847036550c655237526c151ee535dbbeb638e70d9dd3ccbc6104c713b", - "ffi-1.17.0-x86_64-darwin": "fdcd48c69db3303ef95aec5c64d6275fcf9878a02c0bec0afddc506ceca0f56b", - "fileutils-1.7.2": "36a0fb324218263e52b486ad7408e9a295378fe8edc9fd343709e523c0980631", - "git-1.19.1": "b0a422d9f6517353c48a330d6114de4db9e0c82dbe7202964a1d9f1fbc827d70", - "hashdiff-1.1.0": "b5465f0e7375f1ee883f53a766ece4dbc764b7674a7c5ffd76e79b2f5f6fc9c9", - "i18n-1.14.5": "26dcbc05e364b57e27ab430148b3377bc413987d34cc042336271d8f42e9d1b9", - "io-console-0.7.2": "f0dccff252f877a4f60d04a4dc6b442b185ebffb4b320ab69212a92b48a7a221", - "io-console-0.7.2-java": "73aa382f8832b116613ceaf57b8ff5bf73dfedcaf39f0aa5420e10f63a4543ed", - "irb-1.14.0": "53d805013bbd194874b8c13a56aca6aebcd11dd79166d88724f8a434fedde615", - "jar-dependencies-0.4.1": "b2df2f1ecbff15334ce20ea7fdd5b8d8161faab67761ff72c7647d728e40d387", - "json-2.7.2": "1898b5cbc81cd36c0fd4d0b7ad2682c39fb07c5ff682fc6265f678f550d4982c", - "json-2.7.2-java": "138e3038b5361b3d06ee2e8aa2be00bed0d0de4ef5f1553fc5935e5b93aca7ee", - "language_server-protocol-3.17.0.3": "3d5c58c02f44a20d972957a9febe386d7e7468ab3900ce6bd2b563dd910c6b3f", - "listen-3.9.0": "db9e4424e0e5834480385197c139cb6b0ae0ef28cc13310cfd1ca78377d59c67", - "logger-1.6.0": "0ab7c120262dd8de2a18cb8d377f1f318cbe98535160a508af9e7710ff43ef3e", - "minitest-5.24.1": "31ec31ac9088d9e21fcc5a5487912234de83966f24368241b2bef03d7012464a", - "mutex_m-0.2.0": "b6ef0c6c842ede846f2ec0ade9e266b1a9dac0bc151682b04835e8ebd54840d5", - "parallel-1.25.1": "12e089b9aa36ea2343f6e93f18cfcebd031798253db8260590d26a7f70b1ab90", - "parser-3.3.4.0": "8d247769c3873fe92201d591a7463384022a1a25e214853df5d6806623179e82", - "psych-5.1.2": "337322f58fc2bf24827d2b9bd5ab595f6a72971867d151bb39980060ea40a368", - "psych-5.1.2-java": "1dd68dc609eddbc884e6892e11da942e16f7256bd30ebde9d35449d43043a6fe", - "public_suffix-6.0.1": "61d44e1cab5cbbbe5b31068481cf16976dd0dc1b6b07bd95617ef8c5e3e00c6f", - "racc-1.8.1": "4a7f6929691dbec8b5209a0b373bc2614882b55fc5d2e447a21aaa691303d62f", - "racc-1.8.1-java": "54f2e6d1e1b91c154013277d986f52a90e5ececbe91465d29172e49342732b98", - "rack-2.2.9": "fd6301a97a1c1e955e68f85c861fcb1cde6145a32c532e1ea321a72ff8cc4042", - "rainbow-3.1.1": "039491aa3a89f42efa1d6dec2fc4e62ede96eb6acd95e52f1ad581182b79bc6a", - "rake-13.2.1": "46cb38dae65d7d74b6020a4ac9d48afed8eb8149c040eccf0523bec91907059d", - "rb-fsevent-0.11.2": "43900b972e7301d6570f64b850a5aa67833ee7d87b458ee92805d56b7318aefe", - "rb-inotify-0.11.1": "a0a700441239b0ff18eb65e3866236cd78613d6b9f78fea1f9ac47a85e47be6e", - "rbs-3.5.2": "ac4a0ff5de832402fc30324028e00c3e8914af3de0abcba7a5cf21d38602f3bb", - "rchardet-1.8.0": "693acd5253d5ade81a51940697955f6dd4bb2f0d245bda76a8e23deec70a52c7", - "rdoc-6.7.0": "b17d5f0f57b0853d7b880d4360a32c7caf8dbb81f8503a36426df809e617f379", - "regexp_parser-2.9.2": "5a27e767ad634f8a4b544520d5cd28a0db7aa1198a5d7c9d7e11d7b3d9066446", - "reline-0.5.9": "5d2dd7ed0fd078e79a05e4eaa47dc91b8dacec7358e9e1dd6d9c4636cff7d378", - "rexml-3.3.2": "4513686f858d0ff2e5a412d734c8a192e16cb1df4cb2063f56b72a8ad4c5257f", - "rspec-3.13.0": "d490914ac1d5a5a64a0e1400c1d54ddd2a501324d703b8cfe83f458337bab993", - "rspec-core-3.13.0": "557792b4e88da883d580342b263d9652b6a10a12d5bda9ef967b01a48f15454c", - "rspec-expectations-3.13.1": "814cf8dadc797b00be55a84d7bc390c082735e5c914e62cbe8d0e19774b74200", - "rspec-mocks-3.13.1": "087189899c337937bcf1d66a50dc3fc999ac88335bbeba4d385c2a38c87d7b38", - "rspec-support-3.13.1": "48877d4f15b772b7538f3693c22225f2eda490ba65a0515c4e7cf6f2f17de70f", - "rubocop-1.65.0": "624316407a3f8e3999c6f75c528471ed3d4513ca39cec3bede1964c69630e4a1", - "rubocop-ast-1.31.3": "1b07d618d8776993ec6053a706d1c09f0bf15139fd69415924656cbff07e7818", - "rubocop-capybara-2.21.0": "5d264efdd8b6c7081a3d4889decf1451a1cfaaec204d81534e236bc825b280ab", - "rubocop-factory_bot-2.26.1": "8de13cd4edcee5ca800f255188167ecef8dbfc3d1fae9f15734e9d2e755392aa", - "rubocop-performance-1.21.1": "5cf20002a544275ad6aa99abca4b945d2a2ed71be925c38fe83700360ed8734e", - "rubocop-rake-0.6.0": "56b6f22189af4b33d4f4e490a555c09f1281b02f4d48c3a61f6e8fe5f401d8db", - "rubocop-rspec-2.31.0": "2bae19388d78e1ceace44cd95fd34f3209f4ef20cac1b168d0a1325cbba3d672", - "rubocop-rspec_rails-2.29.1": "4ae95abbe9ca5a9b6d8be14e50d230fb5b6ba033b05d4c0981b5b76fc44988e4", - "ruby-progressbar-1.13.0": "80fc9c47a9b640d6834e0dc7b3c94c9df37f08cb072b7761e4a71e22cff29b33", - "rubyzip-2.3.2": "3f57e3935dc2255c414484fbf8d673b4909d8a6a57007ed754dde39342d2373f", - "securerandom-0.3.1": "98f0450c0ea46d2f9a4b6db4f391dbd83dc08049592eada155739f40e0341bde", - "steep-1.5.3": "7c6302a4d5932d0a46176ebc79766e52b853c223a85525aa2f8911e345123b85", - "stringio-3.1.1": "53456e14175c594e0e8eb2206a1be33f3974d4fe21c131e628908b05c8c2ae1e", - "strscan-3.1.0": "01b8a81d214fbf7b5308c6fb51b5972bbfc4a6aa1f166fd3618ba97e0fcd5555", - "strscan-3.1.0-java": "8645aa76e017e21764c6df572d2d79fcc1672284014f5bdbd806278cdbcd11b0", - "terminal-table-3.0.2": "f951b6af5f3e00203fb290a669e0a85c5dd5b051b3b023392ccfd67ba5abae91", - "tzinfo-2.0.6": "8daf828cc77bcf7d63b0e3bdb6caa47e2272dcfaf4fbfe46f8c3a9df087a829b", - "unicode-display_width-2.5.0": "7e7681dcade1add70cb9fda20dd77f300b8587c81ebbd165d14fd93144ff0ab4", - "webmock-3.23.1": "0fa738c0767d1c4ec8cc57f6b21998f0c238c8a5b32450df1c847f2767140d95", - "webrick-1.8.1": "19411ec6912911fd3df13559110127ea2badd0c035f7762873f58afc803e158f", - "websocket-1.2.11": "b7e7a74e2410b5e85c25858b26b3322f29161e300935f70a0e0d3c35e0462737", - "yard-0.9.36": "5505736c1b00c926f71053a606ab75f02070c5960d0778b901fe9d8b0a470be4" - }, - gemfile = "//:rb/Gemfile", - gemfile_lock = "//:rb/Gemfile.lock", -) + "//:rb/selenium-devtools.gemspec", + "//:rb/selenium-webdriver.gemspec", + ], + gem_checksums = { + "abbrev-0.1.2": "ad1b4eaaaed4cb722d5684d63949e4bde1d34f2a95e20db93aecfe7cbac74242", + "activesupport-7.1.3.2": "ad8445b7ae4a6d3acc5f88c8c5f437eb0b54062032aaf44856c7b6d3855b8b2e", + "addressable-2.8.6": "798f6af3556641a7619bad1dce04cdb6eb44b0216a991b0396ea7339276f2b47", + "activesupport-7.1.3.4": "455bbc43d82e5ba20daa25f0888b80c9f7e2d80ca0cc96cea3e6acfec3e40309", + "addressable-2.8.7": "462986537cf3735ab5f3c0f557f14155d778f4b43ea4f485a9deb9c8f7c58232", + "ast-2.4.2": "1e280232e6a33754cde542bc5ef85520b74db2aac73ec14acef453784447cc12", + "base64-0.2.0": "0f25e9b21a02a0cc0cea8ef92b2041035d39350946e8789c562b2d1a3da01507", + "bigdecimal-3.1.7": "e799b369a0005fc6d62eed7ef19139ac9bc319cc51470c637b9dcdf593600133", + "bigdecimal-3.1.7-java": "955f5c7aa90136874b494655e42ed70d81382abb0f49f1b42f374a1660e33c63", + "concurrent-ruby-1.2.3": "82fdd3f8a0816e28d513e637bb2b90a45d7b982bdf4f3a0511722d2e495801e2", + "bigdecimal-3.1.8": "a89467ed5a44f8ae01824af49cbc575871fa078332e8f77ea425725c1ffe27be", + "bigdecimal-3.1.8-java": "b9e94c14623fff8575f17a10320852219bbba92ecff4977571503d942687326e", + "concurrent-ruby-1.3.3": "4f9cd28965c4dcf83ffd3ea7304f9323277be8525819cb18a3b61edcb56a7c6a", + "connection_pool-2.4.1": "0f40cf997091f1f04ff66da67eabd61a9fe0d4928b9a3645228532512fab62f4", + "crack-1.0.0": "c83aefdb428cdc7b66c7f287e488c796f055c0839e6e545fec2c7047743c4a49", + "csv-3.3.0": "0bbd1defdc31134abefed027a639b3723c2753862150f4c3ee61cab71b20d67d", + "curb-1.0.5": "2c4755dfb5d6190e9ebb4407b23ac5a5c2c226be1449e6d3bdf625656352efd1", + "debug-1.9.2": "48e026c0852c7a10c60263e2e527968308958e266231e36d64e3efcabec7e7fc", + "diff-lcs-1.5.1": "273223dfb40685548436d32b4733aa67351769c7dea621da7d9dd4813e63ddfe", + "drb-2.2.1": "e9d472bf785f558b96b25358bae115646da0dbfd45107ad858b0bc0d935cb340", + "ffi-1.16.3": "6d3242ff10c87271b0675c58d68d3f10148fabc2ad6da52a18123f06078871fb", + "ffi-1.16.3-java": "6f107fcd7c96f9c96f7e57db749b99502cc2f65665f7b2241d087a8f8c01d42c", + "ffi-1.16.3-x64-mingw32": "6ec709011e3955e97033fa77907a8ab89a9150137d4c45c82c77399b909c9259", + "ffi-1.17.0": "51630e43425078311c056ca75f961bb3bda1641ab36e44ad4c455e0b0e4a231c", + "ffi-1.17.0-java": "f65f022616970fcde83fe176393eb873a7b959ef2703f94931cf0af6ab55ec7a", + "ffi-1.17.0-x86_64-darwin": "fdcd48c69db3303ef95aec5c64d6275fcf9878a02c0bec0afddc506ceca0f56b", + "fileutils-1.7.2": "36a0fb324218263e52b486ad7408e9a295378fe8edc9fd343709e523c0980631", + "git-1.19.1": "b0a422d9f6517353c48a330d6114de4db9e0c82dbe7202964a1d9f1fbc827d70", + "hashdiff-1.1.0": "b5465f0e7375f1ee883f53a766ece4dbc764b7674a7c5ffd76e79b2f5f6fc9c9", + "i18n-1.14.4": "c7deedead0866ea9102975a4eab7968f53de50793a0c211a37808f75dd187551", + "i18n-1.14.5": "26dcbc05e364b57e27ab430148b3377bc413987d34cc042336271d8f42e9d1b9", + "io-console-0.7.2": "f0dccff252f877a4f60d04a4dc6b442b185ebffb4b320ab69212a92b48a7a221", + "io-console-0.7.2-java": "73aa382f8832b116613ceaf57b8ff5bf73dfedcaf39f0aa5420e10f63a4543ed", + "irb-1.12.0": "07634937fbb7d28d07e46da50d0aa43b4d2f7258174d08de4e32dfb57c10539d", + "irb-1.14.0": "53d805013bbd194874b8c13a56aca6aebcd11dd79166d88724f8a434fedde615", + "jar-dependencies-0.4.1": "b2df2f1ecbff15334ce20ea7fdd5b8d8161faab67761ff72c7647d728e40d387", + "json-2.7.2": "1898b5cbc81cd36c0fd4d0b7ad2682c39fb07c5ff682fc6265f678f550d4982c", + "json-2.7.2-java": "138e3038b5361b3d06ee2e8aa2be00bed0d0de4ef5f1553fc5935e5b93aca7ee", + "language_server-protocol-3.17.0.3": "3d5c58c02f44a20d972957a9febe386d7e7468ab3900ce6bd2b563dd910c6b3f", + "listen-3.9.0": "db9e4424e0e5834480385197c139cb6b0ae0ef28cc13310cfd1ca78377d59c67", + "logger-1.6.0": "0ab7c120262dd8de2a18cb8d377f1f318cbe98535160a508af9e7710ff43ef3e", + "minitest-5.22.3": "ea84676290cb5e2b4f31f25751af6050aa90d3e43e4337141c3e3e839611981e", + "minitest-5.24.1": "31ec31ac9088d9e21fcc5a5487912234de83966f24368241b2bef03d7012464a", + "mutex_m-0.2.0": "b6ef0c6c842ede846f2ec0ade9e266b1a9dac0bc151682b04835e8ebd54840d5", + "parallel-1.24.0": "5bf38efb9b37865f8e93d7a762727f8c5fc5deb19949f4040c76481d5eee9397", + "parser-3.3.0.5": "7748313e505ca87045dc0465c776c802043f777581796eb79b1654c5d19d2687", + "parallel-1.25.1": "12e089b9aa36ea2343f6e93f18cfcebd031798253db8260590d26a7f70b1ab90", + "parser-3.3.4.0": "8d247769c3873fe92201d591a7463384022a1a25e214853df5d6806623179e82", + "psych-5.1.2": "337322f58fc2bf24827d2b9bd5ab595f6a72971867d151bb39980060ea40a368", + "psych-5.1.2-java": "1dd68dc609eddbc884e6892e11da942e16f7256bd30ebde9d35449d43043a6fe", + "public_suffix-5.0.5": "72c340218bb384610536919988705cc29e09749c0021fd7005f715c7e5dfc493", + "racc-1.7.3": "b785ab8a30ec43bce073c51dbbe791fd27000f68d1c996c95da98bf685316905", + "racc-1.7.3-java": "b2ad737e788cfa083263ce7c9290644bb0f2c691908249eb4f6eb48ed2815dbf", + "public_suffix-6.0.1": "61d44e1cab5cbbbe5b31068481cf16976dd0dc1b6b07bd95617ef8c5e3e00c6f", + "racc-1.8.1": "4a7f6929691dbec8b5209a0b373bc2614882b55fc5d2e447a21aaa691303d62f", + "racc-1.8.1-java": "54f2e6d1e1b91c154013277d986f52a90e5ececbe91465d29172e49342732b98", + "rack-2.2.9": "fd6301a97a1c1e955e68f85c861fcb1cde6145a32c532e1ea321a72ff8cc4042", + "rainbow-3.1.1": "039491aa3a89f42efa1d6dec2fc4e62ede96eb6acd95e52f1ad581182b79bc6a", + "rake-13.2.1": "46cb38dae65d7d74b6020a4ac9d48afed8eb8149c040eccf0523bec91907059d", + "rb-fsevent-0.11.2": "43900b972e7301d6570f64b850a5aa67833ee7d87b458ee92805d56b7318aefe", + "rb-inotify-0.10.1": "050062d4f31d307cca52c3f6a7f4b946df8de25fc4bd373e1a5142e41034a7ca", + "rbs-3.4.4": "1376d2604a00832641bb47521595e63a1c0d1cc241ded383ba48ddb4396de5a8", + "rb-inotify-0.11.1": "a0a700441239b0ff18eb65e3866236cd78613d6b9f78fea1f9ac47a85e47be6e", + "rbs-3.5.2": "ac4a0ff5de832402fc30324028e00c3e8914af3de0abcba7a5cf21d38602f3bb", + "rchardet-1.8.0": "693acd5253d5ade81a51940697955f6dd4bb2f0d245bda76a8e23deec70a52c7", + "rdoc-6.6.3.1": "39f7b749229ab5ad9d21c81586151c1dd7a549fa8be4070ee09b524f9c656345", + "regexp_parser-2.9.0": "81a00ba141cec0d4b4bf58cb80cd9193e5180836d3fa6ef623f7886d3ba8bdd9", + "reline-0.5.3": "2c46747a1dfd03e100f0666d8a374cf2930c3e734298af9b39e5fe8d35b42035", + "rexml-3.2.6": "e0669a2d4e9f109951cb1fde723d8acd285425d81594a2ea929304af50282816", + "rdoc-6.7.0": "b17d5f0f57b0853d7b880d4360a32c7caf8dbb81f8503a36426df809e617f379", + "regexp_parser-2.9.2": "5a27e767ad634f8a4b544520d5cd28a0db7aa1198a5d7c9d7e11d7b3d9066446", + "reline-0.5.9": "5d2dd7ed0fd078e79a05e4eaa47dc91b8dacec7358e9e1dd6d9c4636cff7d378", + "rexml-3.3.2": "4513686f858d0ff2e5a412d734c8a192e16cb1df4cb2063f56b72a8ad4c5257f", + "rspec-3.13.0": "d490914ac1d5a5a64a0e1400c1d54ddd2a501324d703b8cfe83f458337bab993", + "rspec-core-3.13.0": "557792b4e88da883d580342b263d9652b6a10a12d5bda9ef967b01a48f15454c", + "rspec-expectations-3.13.0": "621d48c62262f955421eaa418130744760802cad47e781df70dba4d9f897102e", + "rspec-mocks-3.13.0": "735a891215758d77cdb5f4721fffc21078793959d1f0ee4a961874311d9b7f66", + "rspec-expectations-3.13.1": "814cf8dadc797b00be55a84d7bc390c082735e5c914e62cbe8d0e19774b74200", + "rspec-mocks-3.13.1": "087189899c337937bcf1d66a50dc3fc999ac88335bbeba4d385c2a38c87d7b38", + "rspec-support-3.13.1": "48877d4f15b772b7538f3693c22225f2eda490ba65a0515c4e7cf6f2f17de70f", + "rubocop-1.63.3": "17a31f16658f2fbb20bc7bcb4a841a06f7368da4f3be8a50365ad61e658d5f44", + "rubocop-ast-1.31.2": "7c206fb094553779923eca862aceece3913ce384f1bf85730208228e884578ec", + "rubocop-capybara-2.20.0": "2a6844b942921f230ee3ab8c94fe77f41a9406096a140245270c0e11624bb938", + "rubocop-factory_bot-2.25.1": "62751bde7af789878b8a31cbd2a82e69515ce7b23a2ad1820cb0fcc3e0150134", + "rubocop-performance-1.21.0": "ec54fa8991c2d538af7bc958361d63bdb3df2e53032da393e9903ea5e4f74a9a", + "rubocop-rspec-2.29.1": "534ee81a3006e7379ec6203687ef7c06ca1d137b7d6d67c2777b680b1ce82e13", + "rubocop-rspec_rails-2.28.3": "9769f2077cca8af2269193ba0450e0317ae1827a132c19149fdbeecaaca32818", + "rubocop-1.65.0": "624316407a3f8e3999c6f75c528471ed3d4513ca39cec3bede1964c69630e4a1", + "rubocop-ast-1.31.3": "1b07d618d8776993ec6053a706d1c09f0bf15139fd69415924656cbff07e7818", + "rubocop-capybara-2.21.0": "5d264efdd8b6c7081a3d4889decf1451a1cfaaec204d81534e236bc825b280ab", + "rubocop-factory_bot-2.26.1": "8de13cd4edcee5ca800f255188167ecef8dbfc3d1fae9f15734e9d2e755392aa", + "rubocop-performance-1.21.1": "5cf20002a544275ad6aa99abca4b945d2a2ed71be925c38fe83700360ed8734e", + "rubocop-rake-0.6.0": "56b6f22189af4b33d4f4e490a555c09f1281b02f4d48c3a61f6e8fe5f401d8db", + "rubocop-rspec-2.31.0": "2bae19388d78e1ceace44cd95fd34f3209f4ef20cac1b168d0a1325cbba3d672", + "rubocop-rspec_rails-2.29.1": "4ae95abbe9ca5a9b6d8be14e50d230fb5b6ba033b05d4c0981b5b76fc44988e4", + "ruby-progressbar-1.13.0": "80fc9c47a9b640d6834e0dc7b3c94c9df37f08cb072b7761e4a71e22cff29b33", + "rubyzip-2.3.2": "3f57e3935dc2255c414484fbf8d673b4909d8a6a57007ed754dde39342d2373f", + "securerandom-0.3.1": "98f0450c0ea46d2f9a4b6db4f391dbd83dc08049592eada155739f40e0341bde", + "steep-1.5.3": "7c6302a4d5932d0a46176ebc79766e52b853c223a85525aa2f8911e345123b85", + "stringio-3.1.0": "c1f6263ae03a15025e51194ab19b06b15e06adcaaedb7f5f6c06ab60f5d67718", + "stringio-3.1.1": "53456e14175c594e0e8eb2206a1be33f3974d4fe21c131e628908b05c8c2ae1e", + "strscan-3.1.0": "01b8a81d214fbf7b5308c6fb51b5972bbfc4a6aa1f166fd3618ba97e0fcd5555", + "strscan-3.1.0-java": "8645aa76e017e21764c6df572d2d79fcc1672284014f5bdbd806278cdbcd11b0", + "terminal-table-3.0.2": "f951b6af5f3e00203fb290a669e0a85c5dd5b051b3b023392ccfd67ba5abae91", + "tzinfo-2.0.6": "8daf828cc77bcf7d63b0e3bdb6caa47e2272dcfaf4fbfe46f8c3a9df087a829b", + "unicode-display_width-2.5.0": "7e7681dcade1add70cb9fda20dd77f300b8587c81ebbd165d14fd93144ff0ab4", + "webmock-3.23.0": "100787435c1f556129a238c11cc7cbee38cb9c2864709c6a0dcdcf822545f31f", + "webmock-3.23.1": "0fa738c0767d1c4ec8cc57f6b21998f0c238c8a5b32450df1c847f2767140d95", + "webrick-1.8.1": "19411ec6912911fd3df13559110127ea2badd0c035f7762873f58afc803e158f", + "websocket-1.2.10": "2cc1a4a79b6e63637b326b4273e46adcddf7871caa5dc5711f2ca4061a629fa8", + "yard-0.9.36": "5505736c1b00c926f71053a606ab75f02070c5960d0778b901fe9d8b0a470be4", + "websocket-1.2.11": "b7e7a74e2410b5e85c25858b26b3322f29161e300935f70a0e0d3c35e0462737", + "yard-0.9.36": "5505736c1b00c926f71053a606ab75f02070c5960d0778b901fe9d8b0a470be4" + }, + gemfile = "//:rb/Gemfile", + gemfile_lock = "//:rb/Gemfile.lock", + ) use_repo(ruby, "bundle", "ruby", "ruby_toolchains") register_toolchains("@ruby_toolchains//:all") From 9da8827c07e843502130c553d1d16ccf7be9cebd Mon Sep 17 00:00:00 2001 From: aguspe Date: Fri, 16 Aug 2024 14:34:01 +0200 Subject: [PATCH 16/33] Update module and try to set curl dir --- MODULE.bazel | 3 +-- rb/Gemfile | 2 ++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/MODULE.bazel b/MODULE.bazel index 446a1ab049835..eccaf7f3c7c45 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -365,8 +365,7 @@ ruby.bundle_fetch( "webrick-1.8.1": "19411ec6912911fd3df13559110127ea2badd0c035f7762873f58afc803e158f", "websocket-1.2.10": "2cc1a4a79b6e63637b326b4273e46adcddf7871caa5dc5711f2ca4061a629fa8", "yard-0.9.36": "5505736c1b00c926f71053a606ab75f02070c5960d0778b901fe9d8b0a470be4", - "websocket-1.2.11": "b7e7a74e2410b5e85c25858b26b3322f29161e300935f70a0e0d3c35e0462737", - "yard-0.9.36": "5505736c1b00c926f71053a606ab75f02070c5960d0778b901fe9d8b0a470be4" + "websocket-1.2.11": "b7e7a74e2410b5e85c25858b26b3322f29161e300935f70a0e0d3c35e0462737" }, gemfile = "//:rb/Gemfile", gemfile_lock = "//:rb/Gemfile.lock", diff --git a/rb/Gemfile b/rb/Gemfile index 740e559bae308..d72db2e7ca221 100644 --- a/rb/Gemfile +++ b/rb/Gemfile @@ -5,6 +5,8 @@ Dir["#{__dir__}/*.gemspec"].each do |spec| gemspec name: File.basename(spec, '.gemspec') end +Bundler.settings.set_local('build.curb', '--with-curl-dir="C:\ProgramData\chocolatey\lib\curl\tools"') + gem 'curb', '~> 1.0.5', require: false, platforms: %i[mri mingw x64_mingw] gem 'debug', '~> 1.7', require: false, platforms: %i[mri mingw x64_mingw] gem 'steep', '~> 1.5.0', require: false, platforms: %i[mri mingw x64_mingw] From f7c4c7a6eec1e631e61160dafaaee31a8c56e249 Mon Sep 17 00:00:00 2001 From: aguspe Date: Fri, 16 Aug 2024 14:37:51 +0200 Subject: [PATCH 17/33] Update module and try to set curl dir --- rb/Gemfile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/rb/Gemfile b/rb/Gemfile index d72db2e7ca221..efee8f641572e 100644 --- a/rb/Gemfile +++ b/rb/Gemfile @@ -4,8 +4,9 @@ source 'https://rubygems.org' Dir["#{__dir__}/*.gemspec"].each do |spec| gemspec name: File.basename(spec, '.gemspec') end - -Bundler.settings.set_local('build.curb', '--with-curl-dir="C:\ProgramData\chocolatey\lib\curl\tools"') +if RUBY_PLATFORM.match?(/mingw|mswin/) + Bundler.settings.set_local('build.curb', '--with-curl-dir="C:\ProgramData\chocolatey\lib\curl\tools"') +end gem 'curb', '~> 1.0.5', require: false, platforms: %i[mri mingw x64_mingw] gem 'debug', '~> 1.7', require: false, platforms: %i[mri mingw x64_mingw] From deb0ede229a6499667ef735ee54b0a6d15071e51 Mon Sep 17 00:00:00 2001 From: aguspe Date: Fri, 16 Aug 2024 15:33:56 +0200 Subject: [PATCH 18/33] Change curl config --- rb/Gemfile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/rb/Gemfile b/rb/Gemfile index efee8f641572e..6c6c383e272b8 100644 --- a/rb/Gemfile +++ b/rb/Gemfile @@ -4,8 +4,11 @@ source 'https://rubygems.org' Dir["#{__dir__}/*.gemspec"].each do |spec| gemspec name: File.basename(spec, '.gemspec') end + if RUBY_PLATFORM.match?(/mingw|mswin/) - Bundler.settings.set_local('build.curb', '--with-curl-dir="C:\ProgramData\chocolatey\lib\curl\tools"') + Bundler.settings.set_local('build.curb', + '--with-curl-lib="C:/ProgramData/chocolatey/lib/curl/bin"', + '--with-curl-include="C:/ProgramData/chocolatey/lib/curl/include"') end gem 'curb', '~> 1.0.5', require: false, platforms: %i[mri mingw x64_mingw] From cb333cdbcaf59feed62566626dc82fce08275234 Mon Sep 17 00:00:00 2001 From: aguspe Date: Fri, 16 Aug 2024 15:42:51 +0200 Subject: [PATCH 19/33] Try with bazel --- .github/workflows/bazel.yml | 5 ----- rb/Gemfile | 6 ------ 2 files changed, 11 deletions(-) diff --git a/.github/workflows/bazel.yml b/.github/workflows/bazel.yml index 0c8f50c664546..428ac9ae6f87a 100644 --- a/.github/workflows/bazel.yml +++ b/.github/workflows/bazel.yml @@ -149,11 +149,6 @@ jobs: - name: Setup curl for Ubuntu if: inputs.os == 'ubuntu' run: sudo apt-get update && sudo apt-get install -y libcurl4-openssl-dev - - name: Setup curl for Windows - if: inputs.os == 'windows' - uses: crazy-max/ghaction-chocolatey@v3 - with: - args: 'install curl' - name: Run Bazel run: ${{ inputs.run }} - name: Start SSH session diff --git a/rb/Gemfile b/rb/Gemfile index 6c6c383e272b8..740e559bae308 100644 --- a/rb/Gemfile +++ b/rb/Gemfile @@ -5,12 +5,6 @@ Dir["#{__dir__}/*.gemspec"].each do |spec| gemspec name: File.basename(spec, '.gemspec') end -if RUBY_PLATFORM.match?(/mingw|mswin/) - Bundler.settings.set_local('build.curb', - '--with-curl-lib="C:/ProgramData/chocolatey/lib/curl/bin"', - '--with-curl-include="C:/ProgramData/chocolatey/lib/curl/include"') -end - gem 'curb', '~> 1.0.5', require: false, platforms: %i[mri mingw x64_mingw] gem 'debug', '~> 1.7', require: false, platforms: %i[mri mingw x64_mingw] gem 'steep', '~> 1.5.0', require: false, platforms: %i[mri mingw x64_mingw] From 8301eb80b0e0f216faea28b4debd5ded154c25d4 Mon Sep 17 00:00:00 2001 From: aguspe Date: Fri, 16 Aug 2024 15:42:57 +0200 Subject: [PATCH 20/33] Try with bazel --- MODULE.bazel | 1 + 1 file changed, 1 insertion(+) diff --git a/MODULE.bazel b/MODULE.bazel index eccaf7f3c7c45..5249b4a0dc8bc 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -244,6 +244,7 @@ ruby = use_extension("@rules_ruby//ruby:extensions.bzl", "ruby") ruby.toolchain( name = "ruby", version_file = "//:rb/.ruby-version", + msys2_packages = ["libcurl", "libyaml"] ) ruby.bundle_fetch( name = "bundle", From 0a2d057d590e50014a9358b9e6c568e5226193fe Mon Sep 17 00:00:00 2001 From: aguspe Date: Fri, 16 Aug 2024 17:01:32 +0200 Subject: [PATCH 21/33] Use msys to install curl --- .github/workflows/bazel.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/bazel.yml b/.github/workflows/bazel.yml index 428ac9ae6f87a..0b87141bda710 100644 --- a/.github/workflows/bazel.yml +++ b/.github/workflows/bazel.yml @@ -149,6 +149,10 @@ jobs: - name: Setup curl for Ubuntu if: inputs.os == 'ubuntu' run: sudo apt-get update && sudo apt-get install -y libcurl4-openssl-dev + - name: Setup curl for Windows + if: inputs.os == 'windows' + uses: msys2/setup-msys2@v2 + run: pacman -S mingw-w64-x86_64-curl - name: Run Bazel run: ${{ inputs.run }} - name: Start SSH session From be8f39bc2c2d48be4f681f4e932eb91cc2d7fc05 Mon Sep 17 00:00:00 2001 From: aguspe Date: Fri, 16 Aug 2024 17:06:25 +0200 Subject: [PATCH 22/33] Using with instead of run --- .github/workflows/bazel.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/bazel.yml b/.github/workflows/bazel.yml index 0b87141bda710..96b71baf3048c 100644 --- a/.github/workflows/bazel.yml +++ b/.github/workflows/bazel.yml @@ -152,7 +152,8 @@ jobs: - name: Setup curl for Windows if: inputs.os == 'windows' uses: msys2/setup-msys2@v2 - run: pacman -S mingw-w64-x86_64-curl + with: + pacman -S mingw-w64-x86_64-curl - name: Run Bazel run: ${{ inputs.run }} - name: Start SSH session From 458959cdbd46359b1b66dfb94e6f4e0b700ddf48 Mon Sep 17 00:00:00 2001 From: aguspe Date: Sat, 17 Aug 2024 11:53:19 +0200 Subject: [PATCH 23/33] Install curl library --- .github/workflows/bazel.yml | 5 ----- MODULE.bazel | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/.github/workflows/bazel.yml b/.github/workflows/bazel.yml index 96b71baf3048c..428ac9ae6f87a 100644 --- a/.github/workflows/bazel.yml +++ b/.github/workflows/bazel.yml @@ -149,11 +149,6 @@ jobs: - name: Setup curl for Ubuntu if: inputs.os == 'ubuntu' run: sudo apt-get update && sudo apt-get install -y libcurl4-openssl-dev - - name: Setup curl for Windows - if: inputs.os == 'windows' - uses: msys2/setup-msys2@v2 - with: - pacman -S mingw-w64-x86_64-curl - name: Run Bazel run: ${{ inputs.run }} - name: Start SSH session diff --git a/MODULE.bazel b/MODULE.bazel index 5249b4a0dc8bc..905adaf4de940 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -244,7 +244,7 @@ ruby = use_extension("@rules_ruby//ruby:extensions.bzl", "ruby") ruby.toolchain( name = "ruby", version_file = "//:rb/.ruby-version", - msys2_packages = ["libcurl", "libyaml"] + msys2_packages = ["curl"] ) ruby.bundle_fetch( name = "bundle", From 04229618fc2458f51d83cdd6e2aa4837cebeffb8 Mon Sep 17 00:00:00 2001 From: aguspe Date: Sat, 17 Aug 2024 12:39:01 +0200 Subject: [PATCH 24/33] Add libyaml --- MODULE.bazel | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MODULE.bazel b/MODULE.bazel index 905adaf4de940..d310923510de5 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -244,7 +244,7 @@ ruby = use_extension("@rules_ruby//ruby:extensions.bzl", "ruby") ruby.toolchain( name = "ruby", version_file = "//:rb/.ruby-version", - msys2_packages = ["curl"] + msys2_packages = ["curl", "libyaml"] ) ruby.bundle_fetch( name = "bundle", From ada6c3384d3d54bac522a1ebfff27712d3046cee Mon Sep 17 00:00:00 2001 From: aguspe Date: Sun, 18 Aug 2024 18:24:07 +0200 Subject: [PATCH 25/33] Run bazel format --- MODULE.bazel | 245 ++++++++++++++++++++++++++------------------------- 1 file changed, 124 insertions(+), 121 deletions(-) diff --git a/MODULE.bazel b/MODULE.bazel index d310923510de5..53241498eb988 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -243,134 +243,137 @@ use_repo(maven, "maven", "unpinned_maven") ruby = use_extension("@rules_ruby//ruby:extensions.bzl", "ruby") ruby.toolchain( name = "ruby", + msys2_packages = [ + "curl", + "libyaml", + ], version_file = "//:rb/.ruby-version", - msys2_packages = ["curl", "libyaml"] ) ruby.bundle_fetch( name = "bundle", srcs = [ "//:rb/lib/selenium/devtools/version.rb", "//:rb/lib/selenium/webdriver/version.rb", - "//:rb/selenium-devtools.gemspec", - "//:rb/selenium-webdriver.gemspec", - ], - gem_checksums = { - "abbrev-0.1.2": "ad1b4eaaaed4cb722d5684d63949e4bde1d34f2a95e20db93aecfe7cbac74242", - "activesupport-7.1.3.2": "ad8445b7ae4a6d3acc5f88c8c5f437eb0b54062032aaf44856c7b6d3855b8b2e", - "addressable-2.8.6": "798f6af3556641a7619bad1dce04cdb6eb44b0216a991b0396ea7339276f2b47", - "activesupport-7.1.3.4": "455bbc43d82e5ba20daa25f0888b80c9f7e2d80ca0cc96cea3e6acfec3e40309", - "addressable-2.8.7": "462986537cf3735ab5f3c0f557f14155d778f4b43ea4f485a9deb9c8f7c58232", - "ast-2.4.2": "1e280232e6a33754cde542bc5ef85520b74db2aac73ec14acef453784447cc12", - "base64-0.2.0": "0f25e9b21a02a0cc0cea8ef92b2041035d39350946e8789c562b2d1a3da01507", - "bigdecimal-3.1.7": "e799b369a0005fc6d62eed7ef19139ac9bc319cc51470c637b9dcdf593600133", - "bigdecimal-3.1.7-java": "955f5c7aa90136874b494655e42ed70d81382abb0f49f1b42f374a1660e33c63", - "concurrent-ruby-1.2.3": "82fdd3f8a0816e28d513e637bb2b90a45d7b982bdf4f3a0511722d2e495801e2", - "bigdecimal-3.1.8": "a89467ed5a44f8ae01824af49cbc575871fa078332e8f77ea425725c1ffe27be", - "bigdecimal-3.1.8-java": "b9e94c14623fff8575f17a10320852219bbba92ecff4977571503d942687326e", - "concurrent-ruby-1.3.3": "4f9cd28965c4dcf83ffd3ea7304f9323277be8525819cb18a3b61edcb56a7c6a", - "connection_pool-2.4.1": "0f40cf997091f1f04ff66da67eabd61a9fe0d4928b9a3645228532512fab62f4", - "crack-1.0.0": "c83aefdb428cdc7b66c7f287e488c796f055c0839e6e545fec2c7047743c4a49", - "csv-3.3.0": "0bbd1defdc31134abefed027a639b3723c2753862150f4c3ee61cab71b20d67d", - "curb-1.0.5": "2c4755dfb5d6190e9ebb4407b23ac5a5c2c226be1449e6d3bdf625656352efd1", - "debug-1.9.2": "48e026c0852c7a10c60263e2e527968308958e266231e36d64e3efcabec7e7fc", - "diff-lcs-1.5.1": "273223dfb40685548436d32b4733aa67351769c7dea621da7d9dd4813e63ddfe", - "drb-2.2.1": "e9d472bf785f558b96b25358bae115646da0dbfd45107ad858b0bc0d935cb340", - "ffi-1.16.3": "6d3242ff10c87271b0675c58d68d3f10148fabc2ad6da52a18123f06078871fb", - "ffi-1.16.3-java": "6f107fcd7c96f9c96f7e57db749b99502cc2f65665f7b2241d087a8f8c01d42c", - "ffi-1.16.3-x64-mingw32": "6ec709011e3955e97033fa77907a8ab89a9150137d4c45c82c77399b909c9259", - "ffi-1.17.0": "51630e43425078311c056ca75f961bb3bda1641ab36e44ad4c455e0b0e4a231c", - "ffi-1.17.0-java": "f65f022616970fcde83fe176393eb873a7b959ef2703f94931cf0af6ab55ec7a", - "ffi-1.17.0-x86_64-darwin": "fdcd48c69db3303ef95aec5c64d6275fcf9878a02c0bec0afddc506ceca0f56b", - "fileutils-1.7.2": "36a0fb324218263e52b486ad7408e9a295378fe8edc9fd343709e523c0980631", - "git-1.19.1": "b0a422d9f6517353c48a330d6114de4db9e0c82dbe7202964a1d9f1fbc827d70", - "hashdiff-1.1.0": "b5465f0e7375f1ee883f53a766ece4dbc764b7674a7c5ffd76e79b2f5f6fc9c9", - "i18n-1.14.4": "c7deedead0866ea9102975a4eab7968f53de50793a0c211a37808f75dd187551", - "i18n-1.14.5": "26dcbc05e364b57e27ab430148b3377bc413987d34cc042336271d8f42e9d1b9", - "io-console-0.7.2": "f0dccff252f877a4f60d04a4dc6b442b185ebffb4b320ab69212a92b48a7a221", - "io-console-0.7.2-java": "73aa382f8832b116613ceaf57b8ff5bf73dfedcaf39f0aa5420e10f63a4543ed", - "irb-1.12.0": "07634937fbb7d28d07e46da50d0aa43b4d2f7258174d08de4e32dfb57c10539d", - "irb-1.14.0": "53d805013bbd194874b8c13a56aca6aebcd11dd79166d88724f8a434fedde615", - "jar-dependencies-0.4.1": "b2df2f1ecbff15334ce20ea7fdd5b8d8161faab67761ff72c7647d728e40d387", - "json-2.7.2": "1898b5cbc81cd36c0fd4d0b7ad2682c39fb07c5ff682fc6265f678f550d4982c", - "json-2.7.2-java": "138e3038b5361b3d06ee2e8aa2be00bed0d0de4ef5f1553fc5935e5b93aca7ee", - "language_server-protocol-3.17.0.3": "3d5c58c02f44a20d972957a9febe386d7e7468ab3900ce6bd2b563dd910c6b3f", - "listen-3.9.0": "db9e4424e0e5834480385197c139cb6b0ae0ef28cc13310cfd1ca78377d59c67", - "logger-1.6.0": "0ab7c120262dd8de2a18cb8d377f1f318cbe98535160a508af9e7710ff43ef3e", - "minitest-5.22.3": "ea84676290cb5e2b4f31f25751af6050aa90d3e43e4337141c3e3e839611981e", - "minitest-5.24.1": "31ec31ac9088d9e21fcc5a5487912234de83966f24368241b2bef03d7012464a", - "mutex_m-0.2.0": "b6ef0c6c842ede846f2ec0ade9e266b1a9dac0bc151682b04835e8ebd54840d5", - "parallel-1.24.0": "5bf38efb9b37865f8e93d7a762727f8c5fc5deb19949f4040c76481d5eee9397", - "parser-3.3.0.5": "7748313e505ca87045dc0465c776c802043f777581796eb79b1654c5d19d2687", - "parallel-1.25.1": "12e089b9aa36ea2343f6e93f18cfcebd031798253db8260590d26a7f70b1ab90", - "parser-3.3.4.0": "8d247769c3873fe92201d591a7463384022a1a25e214853df5d6806623179e82", - "psych-5.1.2": "337322f58fc2bf24827d2b9bd5ab595f6a72971867d151bb39980060ea40a368", - "psych-5.1.2-java": "1dd68dc609eddbc884e6892e11da942e16f7256bd30ebde9d35449d43043a6fe", - "public_suffix-5.0.5": "72c340218bb384610536919988705cc29e09749c0021fd7005f715c7e5dfc493", - "racc-1.7.3": "b785ab8a30ec43bce073c51dbbe791fd27000f68d1c996c95da98bf685316905", - "racc-1.7.3-java": "b2ad737e788cfa083263ce7c9290644bb0f2c691908249eb4f6eb48ed2815dbf", - "public_suffix-6.0.1": "61d44e1cab5cbbbe5b31068481cf16976dd0dc1b6b07bd95617ef8c5e3e00c6f", - "racc-1.8.1": "4a7f6929691dbec8b5209a0b373bc2614882b55fc5d2e447a21aaa691303d62f", - "racc-1.8.1-java": "54f2e6d1e1b91c154013277d986f52a90e5ececbe91465d29172e49342732b98", - "rack-2.2.9": "fd6301a97a1c1e955e68f85c861fcb1cde6145a32c532e1ea321a72ff8cc4042", - "rainbow-3.1.1": "039491aa3a89f42efa1d6dec2fc4e62ede96eb6acd95e52f1ad581182b79bc6a", - "rake-13.2.1": "46cb38dae65d7d74b6020a4ac9d48afed8eb8149c040eccf0523bec91907059d", - "rb-fsevent-0.11.2": "43900b972e7301d6570f64b850a5aa67833ee7d87b458ee92805d56b7318aefe", - "rb-inotify-0.10.1": "050062d4f31d307cca52c3f6a7f4b946df8de25fc4bd373e1a5142e41034a7ca", - "rbs-3.4.4": "1376d2604a00832641bb47521595e63a1c0d1cc241ded383ba48ddb4396de5a8", - "rb-inotify-0.11.1": "a0a700441239b0ff18eb65e3866236cd78613d6b9f78fea1f9ac47a85e47be6e", - "rbs-3.5.2": "ac4a0ff5de832402fc30324028e00c3e8914af3de0abcba7a5cf21d38602f3bb", - "rchardet-1.8.0": "693acd5253d5ade81a51940697955f6dd4bb2f0d245bda76a8e23deec70a52c7", - "rdoc-6.6.3.1": "39f7b749229ab5ad9d21c81586151c1dd7a549fa8be4070ee09b524f9c656345", - "regexp_parser-2.9.0": "81a00ba141cec0d4b4bf58cb80cd9193e5180836d3fa6ef623f7886d3ba8bdd9", - "reline-0.5.3": "2c46747a1dfd03e100f0666d8a374cf2930c3e734298af9b39e5fe8d35b42035", - "rexml-3.2.6": "e0669a2d4e9f109951cb1fde723d8acd285425d81594a2ea929304af50282816", - "rdoc-6.7.0": "b17d5f0f57b0853d7b880d4360a32c7caf8dbb81f8503a36426df809e617f379", - "regexp_parser-2.9.2": "5a27e767ad634f8a4b544520d5cd28a0db7aa1198a5d7c9d7e11d7b3d9066446", - "reline-0.5.9": "5d2dd7ed0fd078e79a05e4eaa47dc91b8dacec7358e9e1dd6d9c4636cff7d378", - "rexml-3.3.2": "4513686f858d0ff2e5a412d734c8a192e16cb1df4cb2063f56b72a8ad4c5257f", - "rspec-3.13.0": "d490914ac1d5a5a64a0e1400c1d54ddd2a501324d703b8cfe83f458337bab993", - "rspec-core-3.13.0": "557792b4e88da883d580342b263d9652b6a10a12d5bda9ef967b01a48f15454c", - "rspec-expectations-3.13.0": "621d48c62262f955421eaa418130744760802cad47e781df70dba4d9f897102e", - "rspec-mocks-3.13.0": "735a891215758d77cdb5f4721fffc21078793959d1f0ee4a961874311d9b7f66", - "rspec-expectations-3.13.1": "814cf8dadc797b00be55a84d7bc390c082735e5c914e62cbe8d0e19774b74200", - "rspec-mocks-3.13.1": "087189899c337937bcf1d66a50dc3fc999ac88335bbeba4d385c2a38c87d7b38", - "rspec-support-3.13.1": "48877d4f15b772b7538f3693c22225f2eda490ba65a0515c4e7cf6f2f17de70f", - "rubocop-1.63.3": "17a31f16658f2fbb20bc7bcb4a841a06f7368da4f3be8a50365ad61e658d5f44", - "rubocop-ast-1.31.2": "7c206fb094553779923eca862aceece3913ce384f1bf85730208228e884578ec", - "rubocop-capybara-2.20.0": "2a6844b942921f230ee3ab8c94fe77f41a9406096a140245270c0e11624bb938", - "rubocop-factory_bot-2.25.1": "62751bde7af789878b8a31cbd2a82e69515ce7b23a2ad1820cb0fcc3e0150134", - "rubocop-performance-1.21.0": "ec54fa8991c2d538af7bc958361d63bdb3df2e53032da393e9903ea5e4f74a9a", - "rubocop-rspec-2.29.1": "534ee81a3006e7379ec6203687ef7c06ca1d137b7d6d67c2777b680b1ce82e13", - "rubocop-rspec_rails-2.28.3": "9769f2077cca8af2269193ba0450e0317ae1827a132c19149fdbeecaaca32818", - "rubocop-1.65.0": "624316407a3f8e3999c6f75c528471ed3d4513ca39cec3bede1964c69630e4a1", - "rubocop-ast-1.31.3": "1b07d618d8776993ec6053a706d1c09f0bf15139fd69415924656cbff07e7818", - "rubocop-capybara-2.21.0": "5d264efdd8b6c7081a3d4889decf1451a1cfaaec204d81534e236bc825b280ab", - "rubocop-factory_bot-2.26.1": "8de13cd4edcee5ca800f255188167ecef8dbfc3d1fae9f15734e9d2e755392aa", - "rubocop-performance-1.21.1": "5cf20002a544275ad6aa99abca4b945d2a2ed71be925c38fe83700360ed8734e", - "rubocop-rake-0.6.0": "56b6f22189af4b33d4f4e490a555c09f1281b02f4d48c3a61f6e8fe5f401d8db", - "rubocop-rspec-2.31.0": "2bae19388d78e1ceace44cd95fd34f3209f4ef20cac1b168d0a1325cbba3d672", - "rubocop-rspec_rails-2.29.1": "4ae95abbe9ca5a9b6d8be14e50d230fb5b6ba033b05d4c0981b5b76fc44988e4", - "ruby-progressbar-1.13.0": "80fc9c47a9b640d6834e0dc7b3c94c9df37f08cb072b7761e4a71e22cff29b33", - "rubyzip-2.3.2": "3f57e3935dc2255c414484fbf8d673b4909d8a6a57007ed754dde39342d2373f", - "securerandom-0.3.1": "98f0450c0ea46d2f9a4b6db4f391dbd83dc08049592eada155739f40e0341bde", - "steep-1.5.3": "7c6302a4d5932d0a46176ebc79766e52b853c223a85525aa2f8911e345123b85", - "stringio-3.1.0": "c1f6263ae03a15025e51194ab19b06b15e06adcaaedb7f5f6c06ab60f5d67718", - "stringio-3.1.1": "53456e14175c594e0e8eb2206a1be33f3974d4fe21c131e628908b05c8c2ae1e", - "strscan-3.1.0": "01b8a81d214fbf7b5308c6fb51b5972bbfc4a6aa1f166fd3618ba97e0fcd5555", - "strscan-3.1.0-java": "8645aa76e017e21764c6df572d2d79fcc1672284014f5bdbd806278cdbcd11b0", - "terminal-table-3.0.2": "f951b6af5f3e00203fb290a669e0a85c5dd5b051b3b023392ccfd67ba5abae91", - "tzinfo-2.0.6": "8daf828cc77bcf7d63b0e3bdb6caa47e2272dcfaf4fbfe46f8c3a9df087a829b", - "unicode-display_width-2.5.0": "7e7681dcade1add70cb9fda20dd77f300b8587c81ebbd165d14fd93144ff0ab4", - "webmock-3.23.0": "100787435c1f556129a238c11cc7cbee38cb9c2864709c6a0dcdcf822545f31f", - "webmock-3.23.1": "0fa738c0767d1c4ec8cc57f6b21998f0c238c8a5b32450df1c847f2767140d95", - "webrick-1.8.1": "19411ec6912911fd3df13559110127ea2badd0c035f7762873f58afc803e158f", - "websocket-1.2.10": "2cc1a4a79b6e63637b326b4273e46adcddf7871caa5dc5711f2ca4061a629fa8", - "yard-0.9.36": "5505736c1b00c926f71053a606ab75f02070c5960d0778b901fe9d8b0a470be4", - "websocket-1.2.11": "b7e7a74e2410b5e85c25858b26b3322f29161e300935f70a0e0d3c35e0462737" - }, - gemfile = "//:rb/Gemfile", - gemfile_lock = "//:rb/Gemfile.lock", - ) + "//:rb/selenium-devtools.gemspec", + "//:rb/selenium-webdriver.gemspec", + ], + gem_checksums = { + "abbrev-0.1.2": "ad1b4eaaaed4cb722d5684d63949e4bde1d34f2a95e20db93aecfe7cbac74242", + "activesupport-7.1.3.2": "ad8445b7ae4a6d3acc5f88c8c5f437eb0b54062032aaf44856c7b6d3855b8b2e", + "addressable-2.8.6": "798f6af3556641a7619bad1dce04cdb6eb44b0216a991b0396ea7339276f2b47", + "activesupport-7.1.3.4": "455bbc43d82e5ba20daa25f0888b80c9f7e2d80ca0cc96cea3e6acfec3e40309", + "addressable-2.8.7": "462986537cf3735ab5f3c0f557f14155d778f4b43ea4f485a9deb9c8f7c58232", + "ast-2.4.2": "1e280232e6a33754cde542bc5ef85520b74db2aac73ec14acef453784447cc12", + "base64-0.2.0": "0f25e9b21a02a0cc0cea8ef92b2041035d39350946e8789c562b2d1a3da01507", + "bigdecimal-3.1.7": "e799b369a0005fc6d62eed7ef19139ac9bc319cc51470c637b9dcdf593600133", + "bigdecimal-3.1.7-java": "955f5c7aa90136874b494655e42ed70d81382abb0f49f1b42f374a1660e33c63", + "concurrent-ruby-1.2.3": "82fdd3f8a0816e28d513e637bb2b90a45d7b982bdf4f3a0511722d2e495801e2", + "bigdecimal-3.1.8": "a89467ed5a44f8ae01824af49cbc575871fa078332e8f77ea425725c1ffe27be", + "bigdecimal-3.1.8-java": "b9e94c14623fff8575f17a10320852219bbba92ecff4977571503d942687326e", + "concurrent-ruby-1.3.3": "4f9cd28965c4dcf83ffd3ea7304f9323277be8525819cb18a3b61edcb56a7c6a", + "connection_pool-2.4.1": "0f40cf997091f1f04ff66da67eabd61a9fe0d4928b9a3645228532512fab62f4", + "crack-1.0.0": "c83aefdb428cdc7b66c7f287e488c796f055c0839e6e545fec2c7047743c4a49", + "csv-3.3.0": "0bbd1defdc31134abefed027a639b3723c2753862150f4c3ee61cab71b20d67d", + "curb-1.0.5": "2c4755dfb5d6190e9ebb4407b23ac5a5c2c226be1449e6d3bdf625656352efd1", + "debug-1.9.2": "48e026c0852c7a10c60263e2e527968308958e266231e36d64e3efcabec7e7fc", + "diff-lcs-1.5.1": "273223dfb40685548436d32b4733aa67351769c7dea621da7d9dd4813e63ddfe", + "drb-2.2.1": "e9d472bf785f558b96b25358bae115646da0dbfd45107ad858b0bc0d935cb340", + "ffi-1.16.3": "6d3242ff10c87271b0675c58d68d3f10148fabc2ad6da52a18123f06078871fb", + "ffi-1.16.3-java": "6f107fcd7c96f9c96f7e57db749b99502cc2f65665f7b2241d087a8f8c01d42c", + "ffi-1.16.3-x64-mingw32": "6ec709011e3955e97033fa77907a8ab89a9150137d4c45c82c77399b909c9259", + "ffi-1.17.0": "51630e43425078311c056ca75f961bb3bda1641ab36e44ad4c455e0b0e4a231c", + "ffi-1.17.0-java": "f65f022616970fcde83fe176393eb873a7b959ef2703f94931cf0af6ab55ec7a", + "ffi-1.17.0-x86_64-darwin": "fdcd48c69db3303ef95aec5c64d6275fcf9878a02c0bec0afddc506ceca0f56b", + "fileutils-1.7.2": "36a0fb324218263e52b486ad7408e9a295378fe8edc9fd343709e523c0980631", + "git-1.19.1": "b0a422d9f6517353c48a330d6114de4db9e0c82dbe7202964a1d9f1fbc827d70", + "hashdiff-1.1.0": "b5465f0e7375f1ee883f53a766ece4dbc764b7674a7c5ffd76e79b2f5f6fc9c9", + "i18n-1.14.4": "c7deedead0866ea9102975a4eab7968f53de50793a0c211a37808f75dd187551", + "i18n-1.14.5": "26dcbc05e364b57e27ab430148b3377bc413987d34cc042336271d8f42e9d1b9", + "io-console-0.7.2": "f0dccff252f877a4f60d04a4dc6b442b185ebffb4b320ab69212a92b48a7a221", + "io-console-0.7.2-java": "73aa382f8832b116613ceaf57b8ff5bf73dfedcaf39f0aa5420e10f63a4543ed", + "irb-1.12.0": "07634937fbb7d28d07e46da50d0aa43b4d2f7258174d08de4e32dfb57c10539d", + "irb-1.14.0": "53d805013bbd194874b8c13a56aca6aebcd11dd79166d88724f8a434fedde615", + "jar-dependencies-0.4.1": "b2df2f1ecbff15334ce20ea7fdd5b8d8161faab67761ff72c7647d728e40d387", + "json-2.7.2": "1898b5cbc81cd36c0fd4d0b7ad2682c39fb07c5ff682fc6265f678f550d4982c", + "json-2.7.2-java": "138e3038b5361b3d06ee2e8aa2be00bed0d0de4ef5f1553fc5935e5b93aca7ee", + "language_server-protocol-3.17.0.3": "3d5c58c02f44a20d972957a9febe386d7e7468ab3900ce6bd2b563dd910c6b3f", + "listen-3.9.0": "db9e4424e0e5834480385197c139cb6b0ae0ef28cc13310cfd1ca78377d59c67", + "logger-1.6.0": "0ab7c120262dd8de2a18cb8d377f1f318cbe98535160a508af9e7710ff43ef3e", + "minitest-5.22.3": "ea84676290cb5e2b4f31f25751af6050aa90d3e43e4337141c3e3e839611981e", + "minitest-5.24.1": "31ec31ac9088d9e21fcc5a5487912234de83966f24368241b2bef03d7012464a", + "mutex_m-0.2.0": "b6ef0c6c842ede846f2ec0ade9e266b1a9dac0bc151682b04835e8ebd54840d5", + "parallel-1.24.0": "5bf38efb9b37865f8e93d7a762727f8c5fc5deb19949f4040c76481d5eee9397", + "parser-3.3.0.5": "7748313e505ca87045dc0465c776c802043f777581796eb79b1654c5d19d2687", + "parallel-1.25.1": "12e089b9aa36ea2343f6e93f18cfcebd031798253db8260590d26a7f70b1ab90", + "parser-3.3.4.0": "8d247769c3873fe92201d591a7463384022a1a25e214853df5d6806623179e82", + "psych-5.1.2": "337322f58fc2bf24827d2b9bd5ab595f6a72971867d151bb39980060ea40a368", + "psych-5.1.2-java": "1dd68dc609eddbc884e6892e11da942e16f7256bd30ebde9d35449d43043a6fe", + "public_suffix-5.0.5": "72c340218bb384610536919988705cc29e09749c0021fd7005f715c7e5dfc493", + "racc-1.7.3": "b785ab8a30ec43bce073c51dbbe791fd27000f68d1c996c95da98bf685316905", + "racc-1.7.3-java": "b2ad737e788cfa083263ce7c9290644bb0f2c691908249eb4f6eb48ed2815dbf", + "public_suffix-6.0.1": "61d44e1cab5cbbbe5b31068481cf16976dd0dc1b6b07bd95617ef8c5e3e00c6f", + "racc-1.8.1": "4a7f6929691dbec8b5209a0b373bc2614882b55fc5d2e447a21aaa691303d62f", + "racc-1.8.1-java": "54f2e6d1e1b91c154013277d986f52a90e5ececbe91465d29172e49342732b98", + "rack-2.2.9": "fd6301a97a1c1e955e68f85c861fcb1cde6145a32c532e1ea321a72ff8cc4042", + "rainbow-3.1.1": "039491aa3a89f42efa1d6dec2fc4e62ede96eb6acd95e52f1ad581182b79bc6a", + "rake-13.2.1": "46cb38dae65d7d74b6020a4ac9d48afed8eb8149c040eccf0523bec91907059d", + "rb-fsevent-0.11.2": "43900b972e7301d6570f64b850a5aa67833ee7d87b458ee92805d56b7318aefe", + "rb-inotify-0.10.1": "050062d4f31d307cca52c3f6a7f4b946df8de25fc4bd373e1a5142e41034a7ca", + "rbs-3.4.4": "1376d2604a00832641bb47521595e63a1c0d1cc241ded383ba48ddb4396de5a8", + "rb-inotify-0.11.1": "a0a700441239b0ff18eb65e3866236cd78613d6b9f78fea1f9ac47a85e47be6e", + "rbs-3.5.2": "ac4a0ff5de832402fc30324028e00c3e8914af3de0abcba7a5cf21d38602f3bb", + "rchardet-1.8.0": "693acd5253d5ade81a51940697955f6dd4bb2f0d245bda76a8e23deec70a52c7", + "rdoc-6.6.3.1": "39f7b749229ab5ad9d21c81586151c1dd7a549fa8be4070ee09b524f9c656345", + "regexp_parser-2.9.0": "81a00ba141cec0d4b4bf58cb80cd9193e5180836d3fa6ef623f7886d3ba8bdd9", + "reline-0.5.3": "2c46747a1dfd03e100f0666d8a374cf2930c3e734298af9b39e5fe8d35b42035", + "rexml-3.2.6": "e0669a2d4e9f109951cb1fde723d8acd285425d81594a2ea929304af50282816", + "rdoc-6.7.0": "b17d5f0f57b0853d7b880d4360a32c7caf8dbb81f8503a36426df809e617f379", + "regexp_parser-2.9.2": "5a27e767ad634f8a4b544520d5cd28a0db7aa1198a5d7c9d7e11d7b3d9066446", + "reline-0.5.9": "5d2dd7ed0fd078e79a05e4eaa47dc91b8dacec7358e9e1dd6d9c4636cff7d378", + "rexml-3.3.2": "4513686f858d0ff2e5a412d734c8a192e16cb1df4cb2063f56b72a8ad4c5257f", + "rspec-3.13.0": "d490914ac1d5a5a64a0e1400c1d54ddd2a501324d703b8cfe83f458337bab993", + "rspec-core-3.13.0": "557792b4e88da883d580342b263d9652b6a10a12d5bda9ef967b01a48f15454c", + "rspec-expectations-3.13.0": "621d48c62262f955421eaa418130744760802cad47e781df70dba4d9f897102e", + "rspec-mocks-3.13.0": "735a891215758d77cdb5f4721fffc21078793959d1f0ee4a961874311d9b7f66", + "rspec-expectations-3.13.1": "814cf8dadc797b00be55a84d7bc390c082735e5c914e62cbe8d0e19774b74200", + "rspec-mocks-3.13.1": "087189899c337937bcf1d66a50dc3fc999ac88335bbeba4d385c2a38c87d7b38", + "rspec-support-3.13.1": "48877d4f15b772b7538f3693c22225f2eda490ba65a0515c4e7cf6f2f17de70f", + "rubocop-1.63.3": "17a31f16658f2fbb20bc7bcb4a841a06f7368da4f3be8a50365ad61e658d5f44", + "rubocop-ast-1.31.2": "7c206fb094553779923eca862aceece3913ce384f1bf85730208228e884578ec", + "rubocop-capybara-2.20.0": "2a6844b942921f230ee3ab8c94fe77f41a9406096a140245270c0e11624bb938", + "rubocop-factory_bot-2.25.1": "62751bde7af789878b8a31cbd2a82e69515ce7b23a2ad1820cb0fcc3e0150134", + "rubocop-performance-1.21.0": "ec54fa8991c2d538af7bc958361d63bdb3df2e53032da393e9903ea5e4f74a9a", + "rubocop-rspec-2.29.1": "534ee81a3006e7379ec6203687ef7c06ca1d137b7d6d67c2777b680b1ce82e13", + "rubocop-rspec_rails-2.28.3": "9769f2077cca8af2269193ba0450e0317ae1827a132c19149fdbeecaaca32818", + "rubocop-1.65.0": "624316407a3f8e3999c6f75c528471ed3d4513ca39cec3bede1964c69630e4a1", + "rubocop-ast-1.31.3": "1b07d618d8776993ec6053a706d1c09f0bf15139fd69415924656cbff07e7818", + "rubocop-capybara-2.21.0": "5d264efdd8b6c7081a3d4889decf1451a1cfaaec204d81534e236bc825b280ab", + "rubocop-factory_bot-2.26.1": "8de13cd4edcee5ca800f255188167ecef8dbfc3d1fae9f15734e9d2e755392aa", + "rubocop-performance-1.21.1": "5cf20002a544275ad6aa99abca4b945d2a2ed71be925c38fe83700360ed8734e", + "rubocop-rake-0.6.0": "56b6f22189af4b33d4f4e490a555c09f1281b02f4d48c3a61f6e8fe5f401d8db", + "rubocop-rspec-2.31.0": "2bae19388d78e1ceace44cd95fd34f3209f4ef20cac1b168d0a1325cbba3d672", + "rubocop-rspec_rails-2.29.1": "4ae95abbe9ca5a9b6d8be14e50d230fb5b6ba033b05d4c0981b5b76fc44988e4", + "ruby-progressbar-1.13.0": "80fc9c47a9b640d6834e0dc7b3c94c9df37f08cb072b7761e4a71e22cff29b33", + "rubyzip-2.3.2": "3f57e3935dc2255c414484fbf8d673b4909d8a6a57007ed754dde39342d2373f", + "securerandom-0.3.1": "98f0450c0ea46d2f9a4b6db4f391dbd83dc08049592eada155739f40e0341bde", + "steep-1.5.3": "7c6302a4d5932d0a46176ebc79766e52b853c223a85525aa2f8911e345123b85", + "stringio-3.1.0": "c1f6263ae03a15025e51194ab19b06b15e06adcaaedb7f5f6c06ab60f5d67718", + "stringio-3.1.1": "53456e14175c594e0e8eb2206a1be33f3974d4fe21c131e628908b05c8c2ae1e", + "strscan-3.1.0": "01b8a81d214fbf7b5308c6fb51b5972bbfc4a6aa1f166fd3618ba97e0fcd5555", + "strscan-3.1.0-java": "8645aa76e017e21764c6df572d2d79fcc1672284014f5bdbd806278cdbcd11b0", + "terminal-table-3.0.2": "f951b6af5f3e00203fb290a669e0a85c5dd5b051b3b023392ccfd67ba5abae91", + "tzinfo-2.0.6": "8daf828cc77bcf7d63b0e3bdb6caa47e2272dcfaf4fbfe46f8c3a9df087a829b", + "unicode-display_width-2.5.0": "7e7681dcade1add70cb9fda20dd77f300b8587c81ebbd165d14fd93144ff0ab4", + "webmock-3.23.0": "100787435c1f556129a238c11cc7cbee38cb9c2864709c6a0dcdcf822545f31f", + "webmock-3.23.1": "0fa738c0767d1c4ec8cc57f6b21998f0c238c8a5b32450df1c847f2767140d95", + "webrick-1.8.1": "19411ec6912911fd3df13559110127ea2badd0c035f7762873f58afc803e158f", + "websocket-1.2.10": "2cc1a4a79b6e63637b326b4273e46adcddf7871caa5dc5711f2ca4061a629fa8", + "yard-0.9.36": "5505736c1b00c926f71053a606ab75f02070c5960d0778b901fe9d8b0a470be4", + "websocket-1.2.11": "b7e7a74e2410b5e85c25858b26b3322f29161e300935f70a0e0d3c35e0462737", + }, + gemfile = "//:rb/Gemfile", + gemfile_lock = "//:rb/Gemfile.lock", +) use_repo(ruby, "bundle", "ruby", "ruby_toolchains") register_toolchains("@ruby_toolchains//:all") From be797b2a347bbf2eb33ee4b25960bb4eeb82e291 Mon Sep 17 00:00:00 2001 From: aguspe Date: Tue, 20 Aug 2024 07:46:18 +0200 Subject: [PATCH 26/33] Update require curl on the curl spec --- rb/lib/selenium/webdriver/remote/http/curb.rb | 6 ------ rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb | 5 +++++ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/rb/lib/selenium/webdriver/remote/http/curb.rb b/rb/lib/selenium/webdriver/remote/http/curb.rb index e93e80ac32705..b11d2276b6451 100644 --- a/rb/lib/selenium/webdriver/remote/http/curb.rb +++ b/rb/lib/selenium/webdriver/remote/http/curb.rb @@ -17,12 +17,6 @@ # specific language governing permissions and limitations # under the License. -begin - require 'curb' -rescue LoadError - # Curb is not supported by the platform -end - module Selenium module WebDriver module Remote diff --git a/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb b/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb index 3847e9929b89d..b06b5221d6a4c 100644 --- a/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb +++ b/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb @@ -19,6 +19,11 @@ require File.expand_path('../../spec_helper', __dir__) require 'selenium/webdriver/remote/http/curb' +begin + require 'curb' +rescue LoadError + raise 'Curb is not supported by this platform. Try installing Curl' +end module Selenium module WebDriver From 7103ecaa00d6026563e35b1e9a13e60df893834b Mon Sep 17 00:00:00 2001 From: aguspe Date: Tue, 20 Aug 2024 16:00:45 +0200 Subject: [PATCH 27/33] Update rescue with comment --- rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb b/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb index b06b5221d6a4c..b03868f7deb03 100644 --- a/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb +++ b/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb @@ -22,7 +22,7 @@ begin require 'curb' rescue LoadError - raise 'Curb is not supported by this platform. Try installing Curl' + # Curb is not supported by this platform end module Selenium From 3f617b0e499de22d01eb78603167240bf71c4276 Mon Sep 17 00:00:00 2001 From: aguspe Date: Tue, 20 Aug 2024 16:52:26 +0200 Subject: [PATCH 28/33] Require curb added again --- rb/lib/selenium/webdriver/remote/http/curb.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/rb/lib/selenium/webdriver/remote/http/curb.rb b/rb/lib/selenium/webdriver/remote/http/curb.rb index b11d2276b6451..820c01f3f4ae6 100644 --- a/rb/lib/selenium/webdriver/remote/http/curb.rb +++ b/rb/lib/selenium/webdriver/remote/http/curb.rb @@ -17,6 +17,8 @@ # specific language governing permissions and limitations # under the License. +require 'curb' + module Selenium module WebDriver module Remote From e6158a98753cf597977b0cced0a1afdc70a1a7ba Mon Sep 17 00:00:00 2001 From: aguspe Date: Tue, 20 Aug 2024 19:42:36 +0200 Subject: [PATCH 29/33] Require curb added again --- rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb b/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb index b03868f7deb03..577b57bd77363 100644 --- a/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb +++ b/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb @@ -18,11 +18,9 @@ # under the License. require File.expand_path('../../spec_helper', __dir__) -require 'selenium/webdriver/remote/http/curb' -begin +unless Platform.jruby? + require 'selenium/webdriver/remote/http/curb' require 'curb' -rescue LoadError - # Curb is not supported by this platform end module Selenium @@ -32,7 +30,7 @@ module Http describe Curb do subject(:curb) { described_class.new } - unless Platform.jruby? || Platform.windows? || Platform.linux? + unless Platform.jruby? it 'assigns default timeout to 0.0' do http = curb.send :client From 42ab4a203b3e13a7836b79761b24597202fbd62a Mon Sep 17 00:00:00 2001 From: aguspe Date: Tue, 20 Aug 2024 20:20:58 +0200 Subject: [PATCH 30/33] Update guard clause --- .../webdriver/remote/http/curb_spec.rb | 35 +++++++++---------- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb b/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb index 577b57bd77363..985d1c1659a49 100644 --- a/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb +++ b/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb @@ -17,11 +17,11 @@ # specific language governing permissions and limitations # under the License. +return if Platform.jruby? + require File.expand_path('../../spec_helper', __dir__) -unless Platform.jruby? - require 'selenium/webdriver/remote/http/curb' - require 'curb' -end +require 'selenium/webdriver/remote/http/curb' +require 'curb' module Selenium module WebDriver @@ -29,25 +29,22 @@ module Remote module Http describe Curb do subject(:curb) { described_class.new } + it 'assigns default timeout to 0.0' do + http = curb.send :client - unless Platform.jruby? - it 'assigns default timeout to 0.0' do - http = curb.send :client - - expect(http.timeout).to eq 0.0 - end + expect(http.timeout).to eq 0.0 + end - it 'sets the timeout' do - curb.timeout = 20 - expect(curb.timeout).to eq 20 - end + it 'sets the timeout' do + curb.timeout = 20 + expect(curb.timeout).to eq 20 + end - describe '#initialize' do - let(:curb) { described_class.new(timeout: 10) } + describe '#initialize' do + let(:curb) { described_class.new(timeout: 10) } - it 'is initialized with timeout' do - expect(curb.timeout).to eq 10 - end + it 'is initialized with timeout' do + expect(curb.timeout).to eq 10 end end end From 0559ebe4f79908e04152fc6f8a27e686d1214e8d Mon Sep 17 00:00:00 2001 From: aguspe Date: Tue, 20 Aug 2024 20:22:10 +0200 Subject: [PATCH 31/33] Update to RUBY_PLATFORM --- rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb b/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb index 985d1c1659a49..a72fc056e92ef 100644 --- a/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb +++ b/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb @@ -17,7 +17,7 @@ # specific language governing permissions and limitations # under the License. -return if Platform.jruby? +return if RUBY_PLATFORM.include?('java') require File.expand_path('../../spec_helper', __dir__) require 'selenium/webdriver/remote/http/curb' From 05c77adcebfe555d23a572448dd43366c867a92d Mon Sep 17 00:00:00 2001 From: aguspe Date: Tue, 20 Aug 2024 21:18:18 +0200 Subject: [PATCH 32/33] Try with ruby engine --- rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb b/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb index a72fc056e92ef..64a02f04cc347 100644 --- a/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb +++ b/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb @@ -17,9 +17,9 @@ # specific language governing permissions and limitations # under the License. -return if RUBY_PLATFORM.include?('java') - require File.expand_path('../../spec_helper', __dir__) +return if RUBY_ENGINE == 'jruby' + require 'selenium/webdriver/remote/http/curb' require 'curb' From e1674f7f38d6f71ded105fe9733793d646178bea Mon Sep 17 00:00:00 2001 From: aguspe Date: Tue, 20 Aug 2024 21:45:51 +0200 Subject: [PATCH 33/33] Update to remove truffle ruby --- rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb b/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb index 64a02f04cc347..683e99ffb4a4d 100644 --- a/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb +++ b/rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb @@ -18,7 +18,7 @@ # under the License. require File.expand_path('../../spec_helper', __dir__) -return if RUBY_ENGINE == 'jruby' +return if Selenium::WebDriver::Platform.jruby? || Selenium::WebDriver::Platform.truffleruby? require 'selenium/webdriver/remote/http/curb' require 'curb'