From 9d78c50c9aa2ee954e03f6331773e5547e9f04f0 Mon Sep 17 00:00:00 2001 From: Corey Goldberg <1113081+cgoldberg@users.noreply.github.com> Date: Fri, 21 Mar 2025 14:20:09 -0400 Subject: [PATCH 1/2] [py] Only skip WebKit tests on Windows --- py/conftest.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/py/conftest.py b/py/conftest.py index a16c83b3e0226..2f233eeb7aa4f 100644 --- a/py/conftest.py +++ b/py/conftest.py @@ -113,8 +113,8 @@ def driver(request): pytest.skip("Safari tests can only run on an Apple OS") if (driver_class == "Ie") and _platform != "Windows": pytest.skip("IE and EdgeHTML Tests can only run on Windows") - if "WebKit" in driver_class and _platform != "Linux": - pytest.skip("Webkit tests can only run on Linux") + if "WebKit" in driver_class and _platform == "Windows": + pytest.skip("WebKit tests can not be run on Windows") # conditionally mark tests as expected to fail based on driver marker = request.node.get_closest_marker(f"xfail_{driver_class.lower()}") From 8043e00d9800a7f726036c386dd10c433023e0ef Mon Sep 17 00:00:00 2001 From: Corey Goldberg <1113081+cgoldberg@users.noreply.github.com> Date: Fri, 21 Mar 2025 16:00:57 -0400 Subject: [PATCH 2/2] [py] fix grammar error --- py/conftest.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/py/conftest.py b/py/conftest.py index 2f233eeb7aa4f..f3065e5e550d7 100644 --- a/py/conftest.py +++ b/py/conftest.py @@ -114,7 +114,7 @@ def driver(request): if (driver_class == "Ie") and _platform != "Windows": pytest.skip("IE and EdgeHTML Tests can only run on Windows") if "WebKit" in driver_class and _platform == "Windows": - pytest.skip("WebKit tests can not be run on Windows") + pytest.skip("WebKit tests cannot be run on Windows") # conditionally mark tests as expected to fail based on driver marker = request.node.get_closest_marker(f"xfail_{driver_class.lower()}")