From 64e9d6cee2a2355f0dc38ce79ed6c4ada882e8ad Mon Sep 17 00:00:00 2001 From: Titus Fortner Date: Fri, 23 Jan 2026 23:14:14 -0600 Subject: [PATCH] [build] Remove git.add() calls from rake tasks --- Rakefile | 19 ------------------- rake_tasks/common.rb | 1 - rake_tasks/dotnet.rake | 2 -- rake_tasks/java.rake | 2 -- rake_tasks/node.rake | 2 -- rake_tasks/python.rake | 2 -- rake_tasks/ruby.rake | 5 ----- rake_tasks/rust.rake | 3 --- 8 files changed, 36 deletions(-) diff --git a/Rakefile b/Rakefile index 2ba6b6e6b64d6..e5fcf84f84133 100644 --- a/Rakefile +++ b/Rakefile @@ -61,22 +61,18 @@ task :update_browsers, [:channel] do |_task, arguments| puts 'pinning updated browsers and drivers' Bazel.execute('run', args, '//scripts:pinned_browsers') - SeleniumRake.git.add('common/repositories.bzl') end desc 'Update Selenium Manager to latest release' task :update_manager do |_task, _arguments| puts 'Updating Selenium Manager references' Bazel.execute('run', [], '//scripts:selenium_manager') - - SeleniumRake.git.add('common/selenium_manager.bzl') end desc 'Update multitool binaries to latest releases' task :update_multitool do |_task, _arguments| puts 'Updating multitool binary versions' Bazel.execute('run', [], '//scripts:update_multitool_binaries') - SeleniumRake.git.add('multitool.lock.json') end desc 'Update dependencies for release' @@ -92,19 +88,6 @@ task :update_cdp, [:channel] do |_task, arguments| puts "Updating Chrome DevTools references to include latest from #{chrome_channel} channel" Bazel.execute('run', args, '//scripts:update_cdp') - - ['common/devtools/', - 'dotnet/src/webdriver/DevTools/', - 'dotnet/src/webdriver/Selenium.WebDriver.csproj', - 'dotnet/test/common/DevTools/', - 'dotnet/test/common/CustomDriverConfigs/', - 'dotnet/selenium-dotnet-version.bzl', - 'java/src/org/openqa/selenium/devtools/', - 'javascript/selenium-webdriver/BUILD.bazel', - 'py/BUILD.bazel', - 'rb/lib/selenium/devtools/', - 'rb/Gemfile.lock', - 'rake_tasks/java.rake'].each { |file| SeleniumRake.git.add(file) } end task ios_driver: 'appium:build' @@ -113,7 +96,6 @@ desc 'Update AUTHORS file' task :authors do puts 'Updating AUTHORS file' sh "(git log --use-mailmap --format='%aN <%aE>' ; cat .OLD_AUTHORS) | sort -uf > AUTHORS" - SeleniumRake.git.add('AUTHORS') end # Example: `./go prep_release[4.31.0,early-stable]` @@ -293,7 +275,6 @@ namespace :all do text = File.read(file).gsub(old_version_pattern, "The latest released version of Selenium is #{major_minor}") File.write(file, text) - SeleniumRake.git.add(file) end end diff --git a/rake_tasks/common.rb b/rake_tasks/common.rb index cf25b2f5b7cd1..334afa459a6e0 100644 --- a/rake_tasks/common.rb +++ b/rake_tasks/common.rb @@ -70,7 +70,6 @@ def self.update_changelog(version, language, path, changelog, header) content = File.read(changelog) File.write(changelog, "#{header}\n#{entries}\n\n#{content}") - git.add(changelog) end def self.verify_package_published(url) diff --git a/rake_tasks/dotnet.rake b/rake_tasks/dotnet.rake index 2c0b8d01777f4..c9a49e084168c 100644 --- a/rake_tasks/dotnet.rake +++ b/rake_tasks/dotnet.rake @@ -97,7 +97,6 @@ task :version, [:version] do |_task, arguments| file = 'dotnet/selenium-dotnet-version.bzl' text = File.read(file).gsub(old_version, new_version) File.open(file, 'w') { |f| f.puts text } - SeleniumRake.git.add(file) end desc 'Update .NET dependencies to latest versions' @@ -112,5 +111,4 @@ task :pin do Bazel.execute('run', ['--', '--dependencies-file', "#{Dir.pwd}/dotnet/paket.dependencies", '--output-folder', "#{Dir.pwd}/dotnet"], '@rules_dotnet//tools/paket2bazel:paket2bazel') - %w[dotnet/paket.lock dotnet/paket.nuget.bzl].each { |f| SeleniumRake.git.add(f) } end diff --git a/rake_tasks/java.rake b/rake_tasks/java.rake index 7cbe86906d201..2b2e03ae9b698 100644 --- a/rake_tasks/java.rake +++ b/rake_tasks/java.rake @@ -364,7 +364,6 @@ desc 'Pin Maven dependencies' task :pin do args = ['--action_env=RULES_JVM_EXTERNAL_REPIN=1'] Bazel.execute('run', args, '@maven//:pin') - %w[MODULE.bazel java/maven_install.json].each { |file| SeleniumRake.git.add(file) } end desc 'Update Java changelog' @@ -382,7 +381,6 @@ task :version, [:version] do |_task, arguments| file = 'java/version.bzl' text = File.read(file).gsub(old_version, new_version) File.open(file, 'w') { |f| f.puts text } - SeleniumRake.git.add(file) end desc 'Run Java formatter (google-java-format)' diff --git a/rake_tasks/node.rake b/rake_tasks/node.rake index 1cf8d59137b51..978401e445f52 100644 --- a/rake_tasks/node.rake +++ b/rake_tasks/node.rake @@ -31,7 +31,6 @@ end desc 'Pin JavaScript dependencies via pnpm lockfile' task :pin do Bazel.execute('run', ['--', 'install', '--dir', Dir.pwd, '--lockfile-only'], '@pnpm//:pnpm') - SeleniumRake.git.add('pnpm-lock.yaml') end desc 'Update JavaScript dependencies and refresh lockfile (use "latest" to bump ranges)' @@ -119,7 +118,6 @@ task :version, [:version] do |_task, arguments| %w[javascript/selenium-webdriver/package.json javascript/selenium-webdriver/BUILD.bazel].each do |file| text = File.read(file).gsub(old_version, new_version) File.open(file, 'w') { |f| f.puts text } - SeleniumRake.git.add(file) end end diff --git a/rake_tasks/python.rake b/rake_tasks/python.rake index a0fe4e0c49a03..98b2e11f2a135 100644 --- a/rake_tasks/python.rake +++ b/rake_tasks/python.rake @@ -141,7 +141,6 @@ task :version, [:version] do |_task, arguments| 'py/docs/source/conf.py'].each do |file| text = File.read(file).gsub(old_version, new_version) File.open(file, 'w') { |f| f.puts text } - SeleniumRake.git.add(file) end old_short_version = old_version.split('.')[0..1].join('.') @@ -150,7 +149,6 @@ task :version, [:version] do |_task, arguments| conf = 'py/docs/source/conf.py' text = File.read(conf).gsub(old_short_version, new_short_version) File.open(conf, 'w') { |f| f.puts text } - SeleniumRake.git.add(conf) end desc 'Run Python linter (ruff check + format)' diff --git a/rake_tasks/ruby.rake b/rake_tasks/ruby.rake index d82a8619d7cfc..b74f3b780285c 100644 --- a/rake_tasks/ruby.rake +++ b/rake_tasks/ruby.rake @@ -126,7 +126,6 @@ task :version, [:version] do |_task, arguments| file = 'rb/lib/selenium/webdriver/version.rb' text = File.read(file).gsub(old_version, new_version) File.open(file, 'w') { |f| f.puts text } - SeleniumRake.git.add(file) Rake::Task['rb:update'].invoke end @@ -194,16 +193,12 @@ task :pin, [:force] do |_task, arguments| new_content = module_content.sub(/ gem_checksums = \{[^}]+\},/m, formatted) File.write(module_bazel, new_content) - - SeleniumRake.git.add(module_bazel) end desc 'Update Ruby dependencies and sync checksums to MODULE.bazel' task :update do puts 'updating and pinning gem versions' Bazel.execute('run', [], '//rb:bundle-update') - SeleniumRake.git.add('rb/Gemfile.lock') Bazel.execute('run', [], '//rb:rbs-update') - SeleniumRake.git.add('rb/rbs_collection.lock.yaml') Rake::Task['rb:pin'].invoke end diff --git a/rake_tasks/rust.rake b/rake_tasks/rust.rake index 6be0de90deaed..13abd14fc0add 100644 --- a/rake_tasks/rust.rake +++ b/rake_tasks/rust.rake @@ -53,10 +53,7 @@ task :version, [:version] do |_task, arguments| ['rust/Cargo.toml', 'rust/BUILD.bazel'].each do |file| text = File.read(file).gsub(old_version, new_version) File.open(file, 'w') { |f| f.puts text } - SeleniumRake.git.add(file) end Rake::Task['rust:update'].invoke - SeleniumRake.git.add('rust/Cargo.Bazel.lock') - SeleniumRake.git.add('rust/Cargo.lock') end