From 253d7a04b9fc0414b0153744035d293f4b1858a7 Mon Sep 17 00:00:00 2001 From: Pierre Date: Thu, 29 Jun 2017 16:45:37 +0200 Subject: [PATCH 1/5] Add panes prop definition --- src/modules/Tab/Tab.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/Tab/Tab.d.ts b/src/modules/Tab/Tab.d.ts index e3364e7c26..64bee77f5f 100644 --- a/src/modules/Tab/Tab.d.ts +++ b/src/modules/Tab/Tab.d.ts @@ -27,7 +27,7 @@ export interface TabProps { onTabChange?: (event: React.MouseEvent, data: TabProps) => void; /** Shorthand props for the Menu. */ - panes?: any; + panes?: Array<{menuItem: string; render: () => React.ReactNode;}>; } interface TabComponent extends React.ComponentClass { From 209e2fdbb9242ff3e30c62df835a24fedbd61322 Mon Sep 17 00:00:00 2001 From: Pierre Date: Thu, 29 Jun 2017 16:50:53 +0200 Subject: [PATCH 2/5] Add TabPaneProps interface So this interface can be used in code --- src/modules/Tab/Tab.d.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/modules/Tab/Tab.d.ts b/src/modules/Tab/Tab.d.ts index 64bee77f5f..ccd35e941c 100644 --- a/src/modules/Tab/Tab.d.ts +++ b/src/modules/Tab/Tab.d.ts @@ -27,9 +27,14 @@ export interface TabProps { onTabChange?: (event: React.MouseEvent, data: TabProps) => void; /** Shorthand props for the Menu. */ - panes?: Array<{menuItem: string; render: () => React.ReactNode;}>; + panes?: Array; } +export interface TabPaneProps = { + menuItem: string; + render: () => React.ReactNode; +}; + interface TabComponent extends React.ComponentClass { Pane: typeof TabPane; } From 38e6fa5a7b261d838cb7e904c2a9c5225441dd69 Mon Sep 17 00:00:00 2001 From: Pierre Date: Thu, 29 Jun 2017 16:52:38 +0200 Subject: [PATCH 3/5] Update Tab.d.ts --- src/modules/Tab/Tab.d.ts | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/modules/Tab/Tab.d.ts b/src/modules/Tab/Tab.d.ts index ccd35e941c..64bee77f5f 100644 --- a/src/modules/Tab/Tab.d.ts +++ b/src/modules/Tab/Tab.d.ts @@ -27,14 +27,9 @@ export interface TabProps { onTabChange?: (event: React.MouseEvent, data: TabProps) => void; /** Shorthand props for the Menu. */ - panes?: Array; + panes?: Array<{menuItem: string; render: () => React.ReactNode;}>; } -export interface TabPaneProps = { - menuItem: string; - render: () => React.ReactNode; -}; - interface TabComponent extends React.ComponentClass { Pane: typeof TabPane; } From 5cb4d76f21c13314196ce13c4847a50c00d50270 Mon Sep 17 00:00:00 2001 From: Pierre Date: Fri, 30 Jun 2017 08:47:22 +0200 Subject: [PATCH 4/5] Multiligne definition --- src/modules/Tab/Tab.d.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/modules/Tab/Tab.d.ts b/src/modules/Tab/Tab.d.ts index 64bee77f5f..49934920b1 100644 --- a/src/modules/Tab/Tab.d.ts +++ b/src/modules/Tab/Tab.d.ts @@ -27,7 +27,10 @@ export interface TabProps { onTabChange?: (event: React.MouseEvent, data: TabProps) => void; /** Shorthand props for the Menu. */ - panes?: Array<{menuItem: string; render: () => React.ReactNode;}>; + panes?: Array<{ + menuItem: string; + render: () => React.ReactNode; + }>; } interface TabComponent extends React.ComponentClass { From ca53d7e6738c0c14d4088127962fe137139f3d6e Mon Sep 17 00:00:00 2001 From: Alexander Fedyashov Date: Fri, 30 Jun 2017 18:06:42 +0300 Subject: [PATCH 5/5] relax menuItem prop type --- src/modules/Tab/Tab.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/Tab/Tab.d.ts b/src/modules/Tab/Tab.d.ts index 49934920b1..e6123d0da8 100644 --- a/src/modules/Tab/Tab.d.ts +++ b/src/modules/Tab/Tab.d.ts @@ -28,7 +28,7 @@ export interface TabProps { /** Shorthand props for the Menu. */ panes?: Array<{ - menuItem: string; + menuItem: any; render: () => React.ReactNode; }>; }