Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Portal): use Ref for handling trigger refs #2219

Merged
merged 1 commit into from
Oct 20, 2017

Conversation

layershifter
Copy link
Member

Split from #1879. Also fixes problem with warnings about refs on stateless components and React 16.

Portal is the single component where we have handle refs on trigger prop as I see.

@codecov-io
Copy link

Codecov Report

Merging #2219 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2219   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files         151      151           
  Lines        2624     2624           
=======================================
  Hits         2617     2617           
  Misses          7        7
Impacted Files Coverage Δ
src/addons/Portal/Portal.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 470c7b5...9cf90dc. Read the comment docs.

@levithomason
Copy link
Member

Portal is the single component where we have handle refs on trigger prop as I see.

Though this is true, I think we need to implement Ref anywhere we use this.refs on <ElementType /> as the user may pass a SFC in as also.

I will merge this one and we can do the others separately.

@levithomason
Copy link
Member

Released in semantic-ui-react@0.76.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants