Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mixed): handle properly refs on third-party components #3471

Merged
merged 1 commit into from
Mar 1, 2019

Conversation

layershifter
Copy link
Member

Fixes #1321.

See #1190 & #1321 for context.

@codecov-io
Copy link

Codecov Report

Merging #3471 into master will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3471      +/-   ##
==========================================
- Coverage   99.89%   99.82%   -0.08%     
==========================================
  Files         172      172              
  Lines        2796     2797       +1     
==========================================
- Hits         2793     2792       -1     
- Misses          3        5       +2
Impacted Files Coverage Δ
src/elements/Button/Button.js 94.28% <ø> (-5.72%) ⬇️
src/modules/Dropdown/Dropdown.js 100% <ø> (ø) ⬆️
src/addons/TextArea/TextArea.js 100% <ø> (ø) ⬆️
src/modules/Dimmer/DimmerInner.js 100% <ø> (ø) ⬆️
src/behaviors/Visibility/Visibility.js 100% <ø> (ø) ⬆️
src/modules/Checkbox/Checkbox.js 100% <100%> (ø) ⬆️
src/modules/Popup/Popup.js 99.26% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7e245f...709a49b. Read the comment docs.

@layershifter layershifter merged commit d6f20f9 into master Mar 1, 2019
@layershifter layershifter deleted the chore/refs-as branch March 1, 2019 15:20
@levithomason
Copy link
Member

Released in semantic-ui-react@0.86.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants