Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Next,js Header Telescope Icon Margins and size #1679

Closed
izhuravlev opened this issue Feb 9, 2021 · 5 comments
Closed

Fix Next,js Header Telescope Icon Margins and size #1679

izhuravlev opened this issue Feb 9, 2021 · 5 comments
Assignees
@rjayroso
Labels
5 min fix Fixable in 5 minutes or less area: css styling Anything related to CSS styling area: front-end area: nextjs Nextjs related issues type: bug Something isn't working
Milestone
1.7 Release

Comments

@izhuravlev
Copy link
Contributor

What happened: After porting Header.js, MobileHeader.js, DesktopHeader.js from Gatsby to Next.js in #, we've encountered a number of bugs that need to be fixed. One of them is Telescope Icon sizing.

What should have happened: The icon needs to have the same margins and be the same size as in the Gatsby version of the header.

How to reproduce it (as precise as possible):

Anything else we need to know?:

Environment:

  • OS:
  • Browser:
@izhuravlev izhuravlev added type: bug Something isn't working area: front-end Priority: High area: css styling Anything related to CSS styling area: nextjs Nextjs related issues labels Feb 9, 2021
@izhuravlev izhuravlev added 5 min fix Fixable in 5 minutes or less and removed Priority: High labels Feb 9, 2021
@yuanLeeMidori yuanLeeMidori added this to the 1.7 Release milestone Feb 9, 2021
@PedroFonsecaDEV
Copy link
Contributor

@izhuravlev @rjayroso
We are porting to our new UI, and this bug doesn't need to be fixed.
Please check #1676 pick up an issue and assign yourself.

@PedroFonsecaDEV PedroFonsecaDEV added Blocked Can't do this, until something else is done and removed Blocked Can't do this, until something else is done labels Feb 10, 2021
@PedroFonsecaDEV
Copy link
Contributor

@izhuravlev @rjayroso

Sorry guys.
there is a change in our plans. We need to finish the port and have the old UI working 100% on the NEXTJs.

@PedroFonsecaDEV
Copy link
Contributor

@izhuravlev could you please check if this is the same issue as #1734 ?

@izhuravlev
Copy link
Contributor Author

@PedroFonsecaDEV the main case here is the placement of telescope icon - if telescope's icon is placed the same way as it was in Gatsby version after merging the PR you mentioned - this one is good to be closed

@PedroFonsecaDEV
Copy link
Contributor

@izhuravlev thanks.
So I believe we are good with this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjayroso rjayroso

Labels
5 min fix Fixable in 5 minutes or less area: css styling Anything related to CSS styling area: front-end area: nextjs Nextjs related issues type: bug Something isn't working
Projects
None yet
Milestone
1.7 Release
Development

No branches or pull requests
4 participants
@izhuravlev @rjayroso @yuanLeeMidori @PedroFonsecaDEV