Update docker image #513
Update docker image #513
Conversation
|
@alxbl Thank you!! My only blocker to merging this is the bump in Ruby version in the Gemfile. I would like to keep it at 2.3.3. We typically do not change Ruby versions unless there is a significant need (i.e. security issue, critical compatibility issue). Thoughts? |
|
I don't mind leaving it at 2.3.3, I updated to 2.3.5 because of #388. If you'd like to handle that in a future version, I can update this PR to stick to 2.3.3. Let me know. |
|
Ok, great. Let's stick with 2.3.3 and get it bumped later. That was my bad in #388. IIRC originally we were on 2.3.5, but due to incompatibility in the Windows build we had to drop down to 2.3.3. |
|
I see, good to know. I'll make the modification in a few minutes. |
|
I've reverted both PRs to 2.3.3. Cheers, |
|
Thanks @alxbl! |
|
Side note, I updated the wiki page to reflect the new documentation. https://github.com/SerpicoProject/Serpico/wiki/Running-Serpico-From-Docker |
This pull request completely revamps the Dockerfile to use ruby 2.3.5 as requested and simplifies the image building process. It also includes the documentation for building Serpico containers and initial support for decoupling the database file from the container itself.
Currently, it's still missing a way to expose the certificates and configuration outside of the container so that a containerized instance of Serpico can run from an existing database and configuration. If there's enough people interested, I will work on that next.
Cheers,