From 3d03f9d9a49b6e46a0dd5d943c7a35ddd107f9db Mon Sep 17 00:00:00 2001
From: admin <vijaymymail4c5@gmail.com>
Date: Thu, 31 Oct 2024 22:40:34 -0700
Subject: [PATCH 1/2] Created a new instance scan checks (Table Check).

---
 ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt |  2 +-
 ...check_01c1c08ec3a19610afa6fc84e401310d.xml | 52 +++++++++++++++++++
 2 files changed, 53 insertions(+), 1 deletion(-)
 create mode 100644 ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_01c1c08ec3a19610afa6fc84e401310d.xml

diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
index a470068..a4a7d65 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
@@ -1 +1 @@
-HTyLYLhnyO9jJ2-wVHbOdN5QH-XVqntqccC6pkvG7d1BybJs18Flv4aXZMFFi0UINXoIixTFVdpu_v2Jo1wDrgq6JHtdYyLYIAzAXNtfykYOcIVYQw0dInO3V6vz-ahJzRQuBv_z7sAvGLAWUQKADubjps7VDo8bEzPbCKDoFdpVsRacY2gQCQKygk6xoNrwLzznHwB3Izkq_nhWki_FPwJdiOJyMwkWRl9r9z94A4uo58WoFb3655hUHuFfGCnAdr0fC5n7NzznSREFMU_Oj2OW_NT8iRzBybmK_DJ3Vibe53W1Q86I7Hy3cRf1mV1VaDCLRYxr01lyiezxZu77TEYe7sOixnHommnqr3-Dxq-dyWGWCX2zRNcFKp9tGgZv8PryA8vf_AqVay6OnM_MiG0KhtG9-48c89zb7ugwS8fy046nadVy5M-qp_SszVp_4IMXhtohP2l57EfeIjGcWqgodxzIDl67r-dIfAUVjKcCGgMCDtzNzmsili-YNVZ5allJukpkCqcs5hbi_u1CAl99XqW5M3fU7u7wrfyl_QklnIVhnLTxGXm_h5jWuJ5BY_mEbDxXLEGAFM0W5ORtUTyTu_BlVx_RtjNr4k9hhVPS6Dabwtavu9VXAHekp9tSd68P10wq0_L9jQTAo8mGVcCtPNlTjsmuNwn8fvdSuaU
\ No newline at end of file
+uEH-MVj5358yRx1qNhQZQDDN5DRl_EHSvw3CQ3-uqkJ_UjcZdANraoCdU5KL_mwp7x_66jQSj054ighy53LegM7d6xp8_kOx-SoZTIBBtdf3RE1OwevZASv1Xl2dR1lp0CM5i8lVq4rGQFmN2RkUv1xgprPYKTBCZ4CamesJX89wF4nSGzRdUqPHkH_e73S8Jgwmmm4BxHZ0ow4yyQ3QJbAu90kHsbyehFpjxnzDPjiml_OPVkwylOkpqn4QviJ4UAcgb-00eYvr7RSYX2blyPTisybSLuK2ty0jsylJC8xzt5ZuO5ronXCrqPIwN2P9yXqU-nP3xnCZJJXnSGV2xUU-5OkcoMrfEht5HOM39kIOxzzJvGAOXs6wGA7OqEDdoZHQeZL3eR9m6lq_nHMCHPYjl8nFUedj10VV3oF6YETA4MX0MGNrybGVxIFfibgbqAzLnwiUnfKRtdvF3kRpcIBn8WGEiiSSzDDXovB4gY1b8Fhkk8SNhAM8a9518wFfJRbCWj4kwIJRbbKOKmOf1PY31VjHy8tQ0FH8xALm4sbGHfDTgGdo-Cjy3Velkrr3nqFJJOpdpqB1-I4_fXl8clJPYUou8CdxBhc9bhuZbkJvggMU-8Ne18HimH3K9cn2OLyRe7gRi8-nfG8c-pzvY_gW6iYdD3Yvdfqtirxs6gw
\ No newline at end of file
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_01c1c08ec3a19610afa6fc84e401310d.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_01c1c08ec3a19610afa6fc84e401310d.xml
new file mode 100644
index 0000000..e891ab9
--- /dev/null
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_01c1c08ec3a19610afa6fc84e401310d.xml
@@ -0,0 +1,52 @@
+<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_table_check">
+    <scan_table_check action="INSERT_OR_UPDATE">
+        <active>true</active>
+        <advanced>true</advanced>
+        <category>manageability</category>
+        <conditions table="sys_update_set">state=in progress^ORstate=complete^EQ<item display_value="In progress" endquery="false" field="state" goto="false" newquery="false" operator="=" or="false" value="in progress"/>
+            <item display_value="Complete" endquery="false" field="state" goto="false" newquery="false" operator="=" or="true" value="complete"/>
+            <item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/>
+        </conditions>
+        <description>Usually, developers mark an updatesets as Ignore if the work done is not required to be promoted or incorrect or irrelavent or due to any other reasons. 
+However, at times, some of the developers may use the ignored set for any active work instead of creating new one by updating the state from Ignore to In-Progress. It is not a good practice to do the same. It may case the deployment issues and also makes the troubleshooting process cumbersome.
+It may also impact the deployment and cause issues in case if the state is changed to In-Progress/Completed for the potential ignored sets.</description>
+        <documentation_url/>
+        <finding_type>scan_finding</finding_type>
+        <name>Update set In Progress/Completed previously Ignored</name>
+        <priority>3</priority>
+        <resolution_details>It is always good and recommended to create a new updateset instead of using already Ignored updatesets by changing the state from Ignore to In-Progress/Completed.</resolution_details>
+        <run_condition/>
+        <score_max>100</score_max>
+        <score_min>0</score_min>
+        <score_scale>1</score_scale>
+        <script><![CDATA[(function (finding, current) {
+
+	var usSysId = current.getUniqueValue();
+	var audit = new GlideRecord('sys_audit');
+	audit.addEncodedQuery('fieldname=state^tablename=sys_update_set^oldvalue=ignore^newvalue=in progress^ORnewvalue=complete');
+	audit.addQuery('documentkey', usSysId);
+	audit.setLimit(1);
+	audit.query();
+	
+	if(audit.hasNext()){
+		finding.increment();
+	}
+
+})(finding, current);]]></script>
+        <short_description>Already Ignored  Update Set shouldn't be set back to In Pogress/Completed.</short_description>
+        <sys_class_name>scan_table_check</sys_class_name>
+        <sys_created_by>admin</sys_created_by>
+        <sys_created_on>2024-10-30 19:28:34</sys_created_on>
+        <sys_id>01c1c08ec3a19610afa6fc84e401310d</sys_id>
+        <sys_mod_count>0</sys_mod_count>
+        <sys_name>Update set In Progress/Completed previously Ignored</sys_name>
+        <sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
+        <sys_policy/>
+        <sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
+        <sys_update_name>scan_table_check_01c1c08ec3a19610afa6fc84e401310d</sys_update_name>
+        <sys_updated_by>admin</sys_updated_by>
+        <sys_updated_on>2024-10-30 19:28:34</sys_updated_on>
+        <table>sys_update_set</table>
+        <use_manifest>false</use_manifest>
+    </scan_table_check>
+</record_update>

From ea5143a0508eb3beb3d923d4c1f2be23e81c0088 Mon Sep 17 00:00:00 2001
From: vijaytalupula <30828543+vijaytalupula@users.noreply.github.com>
Date: Fri, 1 Nov 2024 11:13:35 +0530
Subject: [PATCH 2/2] Update README.md

---
 README.md | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/README.md b/README.md
index f857357..eb6dfcc 100644
--- a/README.md
+++ b/README.md
@@ -170,6 +170,11 @@ Tickets from tables such as Incident, Change Request, Problem, and other task-re
 ### Check Inactive Business Rules over 90 days
 Inactive Business Rules which are not updated for more than 90 days and not created by glide.maint and not updated by admin should be identified to remove unnecessary overhead.
 
+### Update set In Progress/Completed previously Ignored
+Usually, developers mark an updatesets as Ignore if the work done is not required to be promoted or incorrect or irrelavent or due to any other reasons. 
+However, at times, some of the developers may use the ignored set for any active work instead of creating new one by updating the state from Ignore to In-Progress. It is not a good practice to do the same. It may case the deployment issues and also makes the troubleshooting process cumbersome.
+It may also impact the deployment and cause issues in case if the state is changed to In-Progress/Completed for the potential ignored sets.
+
 ## Category: Upgradability
 
 ### Call GlideRecord using new