From d78aae9cb4d1b052c35ec5100b7228159a418e54 Mon Sep 17 00:00:00 2001
From: admin <admin@example.com>
Date: Fri, 1 Nov 2024 04:38:43 -0700
Subject: [PATCH 1/3] Check to find orphan UI Policies

---
 ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt |  2 +-
 ...check_81492c6ac321121095ac1173e40131bf.xml | 46 +++++++++++++++++++
 2 files changed, 47 insertions(+), 1 deletion(-)
 create mode 100644 ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_81492c6ac321121095ac1173e40131bf.xml

diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
index 1cc5236..08fc90e 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
@@ -1 +1 @@
-vqS62dwsHOftj0lK7PR87gomw2pIhK44opT0jPKRyjaGenHOsrTkyPCKzQ7rEUQHL5wJzSlMh2o7sx36ilRDd4i88RNzKdRmZQrAE43MBZiIP0vH5yIkRc9lrfiqlfrqlDa5QTwro6H3y4_p_S4sJaGSnLteaAJVb5sn7kboEKpPAvpdV8cgu-rlAKAzB9vegqMVyfgzrzzPlsZhChJpJZzGaqAhnN8h8VY1CH05130BFPqoo1M4DPdLevgSBoH_Hdx1UI4gh7XNIc722PYxnWc-suyoupr9vJk1mHKv0TtIG1UVf1UdlYuLplbA83Xjv-BGOzuHYCCBHy6DG97PjEYe_dHt5OE_51l59nDazeJXpYqQUQ21dEF4pnh1ZkKf3opqlxB7cHRtDL4-Fvj0HKemx8WjSoDC2ww_kGolUrR8KNWIewMS8de65BZMOFuvi0DvA2M0RjNSdxtDtGuJbGfd1gXuk8EO8B69uuyTDBD1q7hzowaVGXALNqKfLEk_BqsTv03-3sX1AAC7lU2VNjqCcESKEPimlLbYEh2xZUySwNJ3nsugjviNfHsGofds0xUjVfNJEoQtqEOu3VfMFK0zufXyLkCxLH-HFKwAy1tb2_Z0RvVK8MhrHfcqE5dQSbGTpOKW4J-OR939_Vx2KD1hwu901aNQmO6NMN5ix2c
\ No newline at end of file
+xtbFaVcRbE6z7HJzoog-_yaegzjjk3VyBHgEckb5vzdgzmfwbOSG57mSKwkAIp2ENXnJyepoQ-6TDhpAVEQu4OA_wm7H0Lm-nEnBAS31io3w7bRHYvygc5jW4fae1acMZhoTxKCBp_86PRS2xtVYO7yqB75lmZxeWUw4Tnn7IArjtrBs-jLzTDMUZ5HowOsnKFKeU0lSy3wPtKocHai7kNAxOdFtHyldwIUNLpRiy_Ky2q0MqfTutPL7QfhEpUSP0vE7HC4k35zH7VOPtutmGduF_-ZawGo-_hKbHVJyuj42YAVEAnbdTVxf4IkWIxNnKRGXkJAbVKoEZP3EaY1ivSGD4Q4atqnWGjyYuGuGe5Kci8nQDKaez8ceu2BnIvu6kW8aRx4e5nW5ExW0-BjsTB58PcEv_bLfqcl0Zpt7DQHLMilaLd5RPcExIegr8W8wHfzNZFCsglR333q5jJfituaPhq-cowROlJDLSdBA6JEl2H1MYqYRUthDvMkg_KZ2wqWYfA4_vxXRdgtqNZSmxdwxBnC8sdkXlKDtVq8KIx4g7C8kVhTKel-yJ22DnnjysbP1wa5-ZD3r25bhWz9zozK8Z-GAvrEjjwdlWo0mEVp_Vf7_ZCRvJgCPMHVj-ZtJXKqzmF9n7ZxD2Y_W60umOvJqG0BiR9Mv_3Kyoq9irRQ
\ No newline at end of file
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_81492c6ac321121095ac1173e40131bf.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_81492c6ac321121095ac1173e40131bf.xml
new file mode 100644
index 0000000..0353137
--- /dev/null
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_81492c6ac321121095ac1173e40131bf.xml
@@ -0,0 +1,46 @@
+<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_table_check">
+    <scan_table_check action="INSERT_OR_UPDATE">
+        <active>true</active>
+        <advanced>true</advanced>
+        <category>manageability</category>
+        <conditions table="sys_ui_policy">active=true^EQ<item endquery="false" field="active" goto="false" newquery="false" operator="=" or="false" value="true"/>
+            <item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/>
+        </conditions>
+        <description>UI policy should have any UI Policy Action defined</description>
+        <documentation_url/>
+        <finding_type>scan_finding</finding_type>
+        <name>Orphaned Catalog UI Policies</name>
+        <priority>3</priority>
+        <resolution_details>If UI policy is not in use, it should be deleted or made inactive</resolution_details>
+        <run_condition/>
+        <score_max>100</score_max>
+        <score_min>0</score_min>
+        <score_scale>1</score_scale>
+        <script><![CDATA[(function (finding, current) {
+
+    var policyAction = new GlideRecord("sys_ui_policy_action");
+	policyAction.addQuery("ui_policy", current.sys_id);
+	if(!policyAction.hasNext()){
+		finding.increment();
+	}
+	
+
+})(engine);]]></script>
+        <short_description>Orphaned Catalog UI Policies</short_description>
+        <sys_class_name>scan_table_check</sys_class_name>
+        <sys_created_by>admin</sys_created_by>
+        <sys_created_on>2024-11-01 11:38:07</sys_created_on>
+        <sys_id>81492c6ac321121095ac1173e40131bf</sys_id>
+        <sys_mod_count>0</sys_mod_count>
+        <sys_name>Orphaned Catalog UI Policies</sys_name>
+        <sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
+        <sys_policy/>
+        <sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
+        <sys_update_name>scan_table_check_81492c6ac321121095ac1173e40131bf</sys_update_name>
+        <sys_updated_by>admin</sys_updated_by>
+        <sys_updated_on>2024-11-01 11:38:07</sys_updated_on>
+        <table>sys_ui_policy</table>
+        <use_manifest>false</use_manifest>
+    </scan_table_check>
+    <sys_translated_text action="delete_multiple" query="documentkey=81492c6ac321121095ac1173e40131bf"/>
+</record_update>

From 5a1551e3c056801f2e2f1b83b0310e6356d37882 Mon Sep 17 00:00:00 2001
From: admin <admin@example.com>
Date: Fri, 1 Nov 2024 04:42:08 -0700
Subject: [PATCH 2/3] Add to check if the UI Policies is running any script

---
 ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt |  2 +-
 ...check_81492c6ac321121095ac1173e40131bf.xml | 24 ++++++++++++++-----
 2 files changed, 19 insertions(+), 7 deletions(-)

diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
index 08fc90e..bc6f9a5 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
@@ -1 +1 @@
-xtbFaVcRbE6z7HJzoog-_yaegzjjk3VyBHgEckb5vzdgzmfwbOSG57mSKwkAIp2ENXnJyepoQ-6TDhpAVEQu4OA_wm7H0Lm-nEnBAS31io3w7bRHYvygc5jW4fae1acMZhoTxKCBp_86PRS2xtVYO7yqB75lmZxeWUw4Tnn7IArjtrBs-jLzTDMUZ5HowOsnKFKeU0lSy3wPtKocHai7kNAxOdFtHyldwIUNLpRiy_Ky2q0MqfTutPL7QfhEpUSP0vE7HC4k35zH7VOPtutmGduF_-ZawGo-_hKbHVJyuj42YAVEAnbdTVxf4IkWIxNnKRGXkJAbVKoEZP3EaY1ivSGD4Q4atqnWGjyYuGuGe5Kci8nQDKaez8ceu2BnIvu6kW8aRx4e5nW5ExW0-BjsTB58PcEv_bLfqcl0Zpt7DQHLMilaLd5RPcExIegr8W8wHfzNZFCsglR333q5jJfituaPhq-cowROlJDLSdBA6JEl2H1MYqYRUthDvMkg_KZ2wqWYfA4_vxXRdgtqNZSmxdwxBnC8sdkXlKDtVq8KIx4g7C8kVhTKel-yJ22DnnjysbP1wa5-ZD3r25bhWz9zozK8Z-GAvrEjjwdlWo0mEVp_Vf7_ZCRvJgCPMHVj-ZtJXKqzmF9n7ZxD2Y_W60umOvJqG0BiR9Mv_3Kyoq9irRQ
\ No newline at end of file
+5PG25HpEKcJCUP-biGpvEGRPf783JM87l8Ao42hVi0-6yJVXbfpPoEqdFpgjfoikhmuqGIOzkRe-Aw4L0OLumIiynwMaifQIM6zrXH7NQMkyLbAw3vbxAWUNQRp4t3fMUsNz1Fye2LE6BAKDE7BXvec5OQgQ1ZbXqNPY8ZlnSnQ63kLOJzBWSpNOAhlQlmQOv7ligWuspvE-d1yrq90smsI56nRbdVPzjxuCOZUPluhMr7_1yp0fTOp_NE1M86SnnE9n8cRTGxKoRNucl8ra80nwnGJShjAhtOCSUUhCQH6fJtmb7hbBgt952WBYFSG7PvnqAfm42_bZ_8lIpj8q7B8vwbPHyq9N87FaZ0Q7xQfx9C0L9kDq3WNUAJqwvHTVwlB0npV93xcCIK12kz6F_RVPi-YeyMCInb2eUxuGDGxVlxTUT_DeGiW-W9O8YhtcyTcs3K5zljhUtaJg2geM7fxpPh7V9q81QRR-HraZBjxWH3rzdZljwJUa_x6ONnydmis3Czl1y7lsWEBpYeFbSiVWT8_KdXzcS_tAg9_JCH8l5r4sYc9NWGWhNULUkj0X1kUcGyc3Gj8id37u7WwwC9g4zpXHRDh_B9icQKv1teUYUg_OmdusEU6xwiR-VwpCJ2Pq7PkxY45_Q_9yuTk4mNm7B5r3rkRMw0H9XtN4OnA
\ No newline at end of file
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_81492c6ac321121095ac1173e40131bf.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_81492c6ac321121095ac1173e40131bf.xml
index 0353137..4536128 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_81492c6ac321121095ac1173e40131bf.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_81492c6ac321121095ac1173e40131bf.xml
@@ -3,13 +3,14 @@
         <active>true</active>
         <advanced>true</advanced>
         <category>manageability</category>
-        <conditions table="sys_ui_policy">active=true^EQ<item endquery="false" field="active" goto="false" newquery="false" operator="=" or="false" value="true"/>
+        <conditions table="sys_ui_policy">active=true^run_scripts=false^EQ<item endquery="false" field="active" goto="false" newquery="false" operator="=" or="false" value="true"/>
+            <item endquery="false" field="run_scripts" goto="false" newquery="false" operator="=" or="false" value="false"/>
             <item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/>
         </conditions>
         <description>UI policy should have any UI Policy Action defined</description>
         <documentation_url/>
         <finding_type>scan_finding</finding_type>
-        <name>Orphaned Catalog UI Policies</name>
+        <name>Orphaned UI Policies</name>
         <priority>3</priority>
         <resolution_details>If UI policy is not in use, it should be deleted or made inactive</resolution_details>
         <run_condition/>
@@ -26,21 +27,32 @@
 	
 
 })(engine);]]></script>
-        <short_description>Orphaned Catalog UI Policies</short_description>
+        <short_description>Orphaned UI Policies</short_description>
         <sys_class_name>scan_table_check</sys_class_name>
         <sys_created_by>admin</sys_created_by>
         <sys_created_on>2024-11-01 11:38:07</sys_created_on>
         <sys_id>81492c6ac321121095ac1173e40131bf</sys_id>
-        <sys_mod_count>0</sys_mod_count>
-        <sys_name>Orphaned Catalog UI Policies</sys_name>
+        <sys_mod_count>1</sys_mod_count>
+        <sys_name>Orphaned UI Policies</sys_name>
         <sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
         <sys_policy/>
         <sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
         <sys_update_name>scan_table_check_81492c6ac321121095ac1173e40131bf</sys_update_name>
         <sys_updated_by>admin</sys_updated_by>
-        <sys_updated_on>2024-11-01 11:38:07</sys_updated_on>
+        <sys_updated_on>2024-11-01 11:41:25</sys_updated_on>
         <table>sys_ui_policy</table>
         <use_manifest>false</use_manifest>
     </scan_table_check>
     <sys_translated_text action="delete_multiple" query="documentkey=81492c6ac321121095ac1173e40131bf"/>
+    <sys_es_latest_script action="INSERT_OR_UPDATE">
+        <id>81492c6ac321121095ac1173e40131bf</id>
+        <sys_created_by>admin</sys_created_by>
+        <sys_created_on>2024-11-01 11:41:24</sys_created_on>
+        <sys_id>090aaceac321121095ac1173e401311f</sys_id>
+        <sys_mod_count>0</sys_mod_count>
+        <sys_updated_by>admin</sys_updated_by>
+        <sys_updated_on>2024-11-01 11:41:24</sys_updated_on>
+        <table>scan_table_check</table>
+        <use_es_latest>false</use_es_latest>
+    </sys_es_latest_script>
 </record_update>

From 37ce8be5d9c1d1cdbd93cd2f427890d5c8b1648f Mon Sep 17 00:00:00 2001
From: Deepak Negi <120473057+dvn-lazywinner@users.noreply.github.com>
Date: Fri, 1 Nov 2024 22:12:24 +0530
Subject: [PATCH 3/3] Update README.md

Added check for "Orphaned UI Policies"
---
 README.md | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/README.md b/README.md
index eb57e9c..092517b 100644
--- a/README.md
+++ b/README.md
@@ -386,6 +386,11 @@ The isLoading flag is the simplest way to prevent unnecessary code from taking u
 
 It is recommended to select columans in List type report to provide better user experence.
 
+## Find Orphaned UI Policies
+
+Orphaned UI policies add a technical debt as they are active but no UI Policy Actions defined or No scripts are running on execution. 
+It is recommeded to deactivate or delete such UI policies.
+
 # Additional resources
 
 Please check these additional links for more information and details: