From 9d53b798f99d32e00f5a376f58ed22d133934ede Mon Sep 17 00:00:00 2001 From: nilsreichardt Date: Sat, 3 Feb 2024 18:43:53 +0100 Subject: [PATCH 1/3] Upgrade CI/CD pipelines from `macos-13` to `macos-14` --- .github/workflows/alpha.yml | 4 ++-- .github/workflows/beta.yml | 4 ++-- .github/workflows/integration_tests_app_ci.yml | 15 ++------------- .github/workflows/stable.yml | 4 ++-- 4 files changed, 8 insertions(+), 19 deletions(-) diff --git a/.github/workflows/alpha.yml b/.github/workflows/alpha.yml index c84e7197b..5216809d9 100644 --- a/.github/workflows/alpha.yml +++ b/.github/workflows/alpha.yml @@ -204,7 +204,7 @@ jobs: --release-notes "$LAST_COMMIT_MESSAGE" deploy-alpha-ios-app: - runs-on: macos-13 + runs-on: macos-14 timeout-minutes: 120 steps: - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 @@ -263,7 +263,7 @@ jobs: --export-options-plist=$HOME/export_options.plist deploy-alpha-macos-app: - runs-on: macos-13 + runs-on: macos-14 timeout-minutes: 60 steps: - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 diff --git a/.github/workflows/beta.yml b/.github/workflows/beta.yml index 5886c2e1f..7e250333f 100644 --- a/.github/workflows/beta.yml +++ b/.github/workflows/beta.yml @@ -63,7 +63,7 @@ jobs: # We skip the deployment if no changelog is provided because we assume that # nothing has changed in the iOS app and therefore no new version is needed. if: github.event.inputs.ios-changelog != '' - runs-on: macos-13 + runs-on: macos-14 timeout-minutes: 120 steps: - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 @@ -210,7 +210,7 @@ jobs: # We skip the deployment if no changelog is provided because we assume that # nothing has changed in the macOS app and therefore no new version is needed. if: github.event.inputs.macos-changelog != '' - runs-on: macos-13 + runs-on: macos-14 timeout-minutes: 60 steps: - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 diff --git a/.github/workflows/integration_tests_app_ci.yml b/.github/workflows/integration_tests_app_ci.yml index c95d99c45..ebc1b6a08 100644 --- a/.github/workflows/integration_tests_app_ci.yml +++ b/.github/workflows/integration_tests_app_ci.yml @@ -170,12 +170,7 @@ jobs: ios-integration-test: needs: changes - # We are using macos-12 instead macos-13 because with macos-13 we have job - # times of 40 - 120 minutes. - # - # Before switching back to macos-13, we should check if the job times are - # still that long by running the job with a matrix (3 runs). - runs-on: macos-12 + runs-on: macos-14 if: ${{ needs.changes.outputs.changesFound == 'true' }} timeout-minutes: 60 steps: @@ -190,12 +185,6 @@ jobs: flutter-version: ${{ steps.fvm-config-action.outputs.FLUTTER_VERSION }} channel: ${{ steps.fvm-config-action.outputs.FLUTTER_CHANNEL }} - # Because macos-12 doesn't have Metal support, we need to disable Impeller - # https://github.com/flutter/flutter/issues/126768 - - name: Disable Impeller - working-directory: app/ios/Runner - run: /usr/libexec/PlistBuddy -c "Add :FLTEnableImpeller bool false" Info.plist - - uses: futureware-tech/simulator-action@427329dea8e4d6417cba1273ebb5c9ad4720082d id: simulator with: @@ -269,7 +258,7 @@ jobs: # macOS app. macos-build-test: needs: changes - runs-on: macos-13 + runs-on: macos-14 if: ${{ needs.changes.outputs.changesFound == 'true' }} timeout-minutes: 60 defaults: diff --git a/.github/workflows/stable.yml b/.github/workflows/stable.yml index b6c24cac4..8d277f214 100644 --- a/.github/workflows/stable.yml +++ b/.github/workflows/stable.yml @@ -63,7 +63,7 @@ jobs: # We skip the deployment if no changelog is provided because we assume that # nothing has changed in the iOS app and therefore no new version is needed. if: github.event.inputs.ios-changelog != '' - runs-on: macos-13 + runs-on: macos-14 timeout-minutes: 120 steps: - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 @@ -212,7 +212,7 @@ jobs: # We skip the deployment if no changelog is provided because we assume that # nothing has changed in the macOS app and therefore no new version is needed. if: github.event.inputs.macos-changelog != '' - runs-on: macos-13 + runs-on: macos-14 timeout-minutes: 60 steps: - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 From 533017203de4af88a4c1c0eb1d8aee7beba6d190 Mon Sep 17 00:00:00 2001 From: nilsreichardt Date: Sat, 3 Feb 2024 18:47:52 +0100 Subject: [PATCH 2/3] Use iPhone 14 --- .github/workflows/integration_tests_app_ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/integration_tests_app_ci.yml b/.github/workflows/integration_tests_app_ci.yml index ebc1b6a08..1e66707ea 100644 --- a/.github/workflows/integration_tests_app_ci.yml +++ b/.github/workflows/integration_tests_app_ci.yml @@ -188,7 +188,7 @@ jobs: - uses: futureware-tech/simulator-action@427329dea8e4d6417cba1273ebb5c9ad4720082d id: simulator with: - model: "iPhone 13" + model: "iPhone 14" - name: Run integration tests working-directory: app From 7f5fdc5d9e7340715838fe8ca43ed64daa74ffe9 Mon Sep 17 00:00:00 2001 From: nilsreichardt Date: Sat, 3 Feb 2024 19:36:03 +0100 Subject: [PATCH 3/3] Disable impeller again --- .github/workflows/integration_tests_app_ci.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/integration_tests_app_ci.yml b/.github/workflows/integration_tests_app_ci.yml index 1e66707ea..828e040a7 100644 --- a/.github/workflows/integration_tests_app_ci.yml +++ b/.github/workflows/integration_tests_app_ci.yml @@ -185,6 +185,12 @@ jobs: flutter-version: ${{ steps.fvm-config-action.outputs.FLUTTER_VERSION }} channel: ${{ steps.fvm-config-action.outputs.FLUTTER_CHANNEL }} + # Because GitHub Action runners don't have Metal support, we need to + # disable Impeller https://github.com/flutter/flutter/issues/126768 + - name: Disable Impeller + working-directory: app/ios/Runner + run: /usr/libexec/PlistBuddy -c "Add :FLTEnableImpeller bool false" Info.plist + - uses: futureware-tech/simulator-action@427329dea8e4d6417cba1273ebb5c9ad4720082d id: simulator with: