This repository has been archived by the owner on Aug 30, 2018. It is now read-only.
QR code on printed gift card template #333
Merged
+36
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshold
added a commit
that referenced
this pull request
Feb 18, 2015
QR code on printed gift card template
| @@ -368,6 +368,17 @@ $gutter: 24px; | |||
| vertical-align: baseline; | |||
| } | |||
|
|
|||
| #QrCode { | |||
There was a problem hiding this comment.
I know it's a bit late in the game, but I was wondering about the fact this says #QrCode and not #qr-code.
In the default template provided by Shopify they're using #qr-code. Also, in the mark up Kevin asked us to copy from, the id used is #qr-code.
There was a problem hiding this comment.
Timber follows our internal styleguide, and in it we use PascalCase for IDs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added QR code to printed gift cards. A few other very minor style updates.
Demo - https://checkout.shopify.com/gift_cards/4790585/preview#
@stevebosworth @carolineschnapp