Update article comment form ids

[cshold]

A pending PR in Shopify (https://github.com/Shopify/shopify/pull/57450) will reload the page after a comment form submission with either #comments or #comment_form as a hash in the URL.

• #comments already works as expected on a successful post
• #comment_form will be added when the form has errors, jumping the page down to the anchor on the form so the user can fix the mistakes

This PR removes the hacky JS that got around having accurate URL hashes and updates the IDs.

cc @Shopify/themes-team @mac-adam-chaieb

FYI @Shopify/theme-support, this can be a reference for updating other themes. Ping me with any questions.

[moechaieb]

please remove this, as {% form 'new_comment', article %} will dynamically generate a form with id="comment_form"

[suture]

Just a small detail :)

It seems the hash that gets added is #comment_form not #comment-form

[suture]

Also in blog.liquid you need to update the Comments link (in the meta data) which has the old hash #Comments

[carolineschnapp]

@suture

Also in blog.liquid you need to update the Comments link (in the meta data) which has the old hash #Comments

Good one, thanks so much! We'll fix that.

We fixed #comment-form to #comment_form in the above comment.

[cshold]

Good catch, thanks @suture

[suture]

Maybe another problem. If you delete this, we no longer get a success message.

{% if form.posted_successfully? %}
      {% assign newHash = 'Comments' %}
 {% endif %}

[cshold]

Will be adding that in another PR shortly

Edit: this may actually be a bug with the update in core, preventing comments.created_at from being sent to the page after a successful post. Digging in now.

[suture]

Many thanks for following that up.