This repository has been archived by the owner on Aug 30, 2018. It is now read-only.
Disable cart drawer when setting is page #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carolineschnapp could you test this out for me too? |
|
🎩 It's good to merge, Carson! |
cshold
added a commit
that referenced
this pull request
Mar 15, 2016
Disable cart drawer when setting is page
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #516 and fixes #507
The original purpose of the cart/drawer setting was for what happens after you add a product to the cart. It's confusing the way it's worded in settings as you'd think the drawer would be completely disabled when selecting 'Page'.
This PR completely removes the cart drawer when 'Page' is selected.
@stevebosworth @carolineschnapp @t-kelly @m-ux