Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add add_offense method to match what rubocop is doing #69

Merged
merged 2 commits into from
Feb 14, 2018
Merged

Add add_offense method to match what rubocop is doing #69

merged 2 commits into from
Feb 14, 2018

Conversation

EiNSTeiN-
Copy link

@EiNSTeiN- EiNSTeiN- commented Feb 3, 2018 •
edited
Loading

store offenses in an instance variable @offenses on the linter and runner and switch to a method add_offense to match what rubocop's Cop class is doing.

@EiNSTeiN- EiNSTeiN- changed the title Add add_offense method to match what rubocop is doing Add add_offense method to match what rubocop is doing Feb 8, 2018
@EiNSTeiN-
Copy link
Author

@Edouard-chin following what you mentioned about matching the interface of Rubocop's Cop class, this is the first step.

@EiNSTeiN- EiNSTeiN- changed the base branch from use-parser-source-buffer to master February 8, 2018 19:12
Edouard-chin
Edouard-chin approved these changes Feb 14, 2018
View reviewed changes
Copy link

@Edouard-chin Edouard-chin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for adding it !

@EiNSTeiN- EiNSTeiN- merged commit 39a38d3 into master Feb 14, 2018
@EiNSTeiN- EiNSTeiN- deleted the add_offense branch February 14, 2018 16:22
@Mangoov Mangoov mentioned this pull request Feb 18, 2018
Merged
muan added a commit to muan/erb-lint that referenced this pull request Jan 29, 2019
@muan
Update custom linter demo, following Shopify#69
fbd658c
@muan muan mentioned this pull request Jan 29, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Edouard-chin Edouard-chin Edouard-chin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EiNSTeiN- @Edouard-chin