From 93c8c31218f8ed300d77e03cfecb33586209fa8f Mon Sep 17 00:00:00 2001 From: Sander Verdonschot Date: Mon, 23 Sep 2024 17:49:32 -0400 Subject: [PATCH 1/2] Add change log entry for GoodJob support --- CHANGELOG.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c800af4d..0e90f07e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,8 +1,9 @@ ### Main (unreleased) -Nil + +- [464](https://github.com/Shopify/job-iteration/pull/464) - Add interruption adapter for [GoodJob](https://github.com/bensheldon/good_job). ## v1.5.1 (May 29,2024) -- [483](https://github.com/Shopify/job-iteration/pull/483) Reverts [#456 Use Arel instead of String for AR Enumerator conditionals](https://github.com/Shopify/job-iteration/pull/456) +- [483](https://github.com/Shopify/job-iteration/pull/483) - Reverts [#456 Use Arel instead of String for AR Enumerator conditionals](https://github.com/Shopify/job-iteration/pull/456) ## v1.5.0 (May 29, 2024) ### Changes From 85cebdbc1e3b6a31bb7897ff8b04e9d69aa64c79 Mon Sep 17 00:00:00 2001 From: Sander Verdonschot Date: Mon, 23 Sep 2024 18:00:35 -0400 Subject: [PATCH 2/2] Fix integration load test --- test/integration/interruption_adapters_test.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/integration/interruption_adapters_test.rb b/test/integration/interruption_adapters_test.rb index 47a72335..408dbc41 100644 --- a/test/integration/interruption_adapters_test.rb +++ b/test/integration/interruption_adapters_test.rb @@ -37,7 +37,8 @@ class InterruptionAdaptersTest < ActiveSupport::TestCase require 'bundler/setup' require 'job-iteration' # The adapter for GoodJob cannot be easily tested at the moment. - JobIteration::InterruptionAdapters::BUNDLED_ADAPTERS.excluding(:good_job).each do |name| + addapters_to_test = JobIteration::InterruptionAdapters::BUNDLED_ADAPTERS - [:good_job] + addapters_to_test.each do |name| JobIteration::InterruptionAdapters.lookup(name) end RUBY