Update sucess logic

Shopify · Oct 12, 2017 · 0d8cd38 · 0d8cd38
1 parent ee55396
commit 0d8cd38
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/kubernetes-deploy/kubernetes_resource/stateful_set.rb b/lib/kubernetes-deploy/kubernetes_resource/stateful_set.rb
@@ -9,6 +9,8 @@ def sync
 
       if @found
         stateful_data = JSON.parse(raw_json)
+        @current_generation = stateful_data["metadata"]["generation"]
+        @observed_generation = stateful_data["status"]["observedGeneration"]
         @desired_replicas = stateful_data["spec"]["replicas"].to_i
         @rollout_data = stateful_data["status"].slice("replicas")
         @status = @rollout_data.map { |state_replicas, num| "#{num} #{state_replicas.chop.pluralize(num)}" }.join(", ")
@@ -21,7 +23,7 @@ def sync
     end
 
     def deploy_succeeded?
-      @desired_replicas == @rollout_data["replicas"].to_i
+      @current_generation == @observed_generation && @desired_replicas == @rollout_data["replicas"].to_i
     end
 
     def deploy_failed?