-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent preflight validations for all tasks #344
Comments
#533 Added a When working on adding the full set of pre-flight validations to the remaining tasks, consider if we need sub classes like |
We should look into how we report warning/errors as part of this too. See this comment for why I mention this. Thanks @dirceu ! |
Done. |
Follow-up to #337
The deploy task already checks whether it can reach the API server before proceeding, so that it can fail with a relevant message instead of failing whichever other request happens to be made first. We should do the same in the runner task. In fact, we should make sure that all globally applicable preflight validations are done consistently by all four of our tasks. One possible approach would be to introduce a config validator object for this purpose, as prototyped here: https://github.com/Shopify/kubernetes-deploy/compare/config_validator.
Considerations
The text was updated successfully, but these errors were encountered: