fix: update matching for Kubernetes error message when server-dry-run is not supported

[sco11morgan]

What are you trying to accomplish with this PR?
Current error message contains 1does not support dry run" not "doesn't support dry-run"
It is not clear if the message previously was "doesn't support dry-run" so I left that in the matching expression.

https://github.com/kubernetes/apiserver/blob/7dc4ceb2fd3311166a78bdf6a4eec4c194364dd0/pkg/admission/plugin/webhook/errors/statuserror.go#L61

...

How is this accomplished?
updated existing regex Krane::KubernetesResource::SERVER_DRY_RUN_DISABLED_ERROR
...

What could go wrong?
...

[KnVerey]

What specifically did you see that prompted this PR? The link in the description is to a repo containing a "Generic library for building a Kubernetes aggregated API server" and the error is specifically about admission webhooks, which krane doesn't deal with. I believe the error message we're checking for comes from https://github.com/kubernetes/kubernetes/blob/16c2ae4607371f1f948c0a9c884805e699330450/staging/src/k8s.io/kubectl/pkg/cmd/apply/apply.go#L698, which still uses doesn't on master.

[sco11morgan]

I ran into the message
Internal error occurred: admission webhook "redacted" does not support dry run
from our clusters.

We're in the process of updating our webhooks to work with server-dry-run, but in the meantime we can't upgrade to >=0.28.0 because deploying secrets fails.

[KnVerey]

Thanks for the explanation. I now see that the code in kubernetes/apiserver (despite that repo's description) is just synced from kubernetes/kubernetes, so the error message in question can also be found here: https://github.com/kubernetes/kubernetes/blob/8b0c36d6204029f6085567706d6e7f689a497346/staging/src/k8s.io/apiserver/pkg/admission/plugin/webhook/errors/statuserror.go#L61.

[jessie-JNing]

Thanks @sco11morgan for bring it to us.
We can make one regex for doesn't and does not, something like:
/(unknown flag: --server-dry-run)|(does[\s]*n[o|']t support dry-run)|(dryRun alpha feature is disabled)/

[sco11morgan]

Great idea! Thx

[KnVerey]

Tests passed, but the diff contains a couple linter errors:

Offenses:
--
  |  
  | lib/krane/kubernetes_resource.rb:19:121: C: Metrics/LineLength: Line is too long. [128/120]
  | /(unknown flag: --server-dry-run)\|(doesn't support dry-run)\|(does not support dry run)\|(dryRun alpha feature is disabled)/
  | ^^^^^^^^
  | test/unit/krane/kubernetes_resource_test.rb:266:93: C: Layout/TrailingWhitespace: Trailing whitespace detected.
  | refute(resource.validation_failed?, "Failed to ignore server dry run responses matching:

[jessie-JNing]

Change looks good to me. Please fix the lint before merge it!

[dturn]

Linting passed locally