Configure default line limit for container logs #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshenny
force-pushed
the
configure-line-limit
branch
from
97920ab
to
5b61a58
Compare
jenshenny
force-pushed
the
configure-line-limit
branch
from
5b61a58
to
2162e96
Compare
jenshenny
force-pushed
the
configure-line-limit
branch
from
2162e96
to
83ed239
Compare
dturn
approved these changes
Feb 11, 2021
timothysmith0609
approved these changes
Feb 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
From #800, it was suggested to make
DEFAULT_LINE_LIMITconfigurable by introducing an environment variable.How is this accomplished?
Turned the constant into a class method, if
ENV["LOG_LINE_LIMIT"](name open to suggestions) is not specified or cannot be converted to an integer, the number of lines will default to 25.