Simplify Deployment and ReplicaSet timeout condition #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two extra sources of Deployment timeout with the previous conditions: - the ReplicaSet hard timeout, which should have matched but didn't - the Pod hard timeout, which is higher, and which it doesn't even really make sense to fail Deployments on This was unnecessarily complex.
ibawt
approved these changes
Oct 26, 2017
kirs
reviewed
Oct 26, 2017
| @@ -50,10 +50,6 @@ def timeout_message | |||
| @pods.map(&:timeout_message).compact.uniq.join("\n") | |||
| end | |||
|
|
|||
| def deploy_timed_out? | |||
There was a problem hiding this comment.
Can you comment why we should fall back to
not to @pods.all?(&:deploy_timed_out?)?
There was a problem hiding this comment.
The most pragmatic reason is that @pods.all?(&:deploy_timed_out?) will never be true before super anyway, since the Pod timeout is double the RS timeout; this is just making the behaviour more difficult to understand with no real benefit. In fact, the Pod hard timeout was chosen based on the needs of bare pods, which are assumed to be running a single high-value pseudo-inline task, so referencing it from RS doesn't really make sense. Finally, the supported, k8s-native way to time out a deployment whose pods aren't rolling in time is using progressDeadlineSeconds.
This was referenced Oct 27, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two extra sources of Deployment timeout with the previous conditions:
really make sense to fail Deployments on
This was unnecessarily complex.