Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for deploying only secrets.ejson #416

Merged
merged 7 commits into from
Jan 28, 2019
Merged

Support for deploying only secrets.ejson #416

merged 7 commits into from
Jan 28, 2019

Conversation

timothysmith0609
Copy link
Contributor

@timothysmith0609 timothysmith0609 commented Jan 22, 2019 •
edited
Loading

What are you trying to accomplish with this PR?
Closes #412

Let users deploy directories that only contain secrets.ejson

How is this accomplished?
Add secrets.ejson to the regex that checks for valid templates

What could go wrong?
Not too much

dturn
dturn approved these changes Jan 22, 2019
View reviewed changes
lib/kubernetes-deploy/deploy_task.rb Outdated Show resolved Hide resolved
@timothysmith0609 timothysmith0609 changed the title ejson alone is valid Support for deploying only secrets.ejson Jan 22, 2019
KnVerey
KnVerey reviewed Jan 23, 2019
View reviewed changes
Copy link
Contributor

@KnVerey KnVerey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test?

I think you'll need to rebase to make sure the release note lands in the right place, since we've since released the rest of those features.

lib/kubernetes-deploy/deploy_task.rb Outdated Show resolved Hide resolved
@timothysmith0609
Copy link
Contributor Author

timothysmith0609 commented Jan 24, 2019 •
edited
Loading

Can you please add a test?

I had misread how deploy_fixtures worked at first so was struggling to build the test. Once I figured it out it was easy. For my sanity I tried the test without the rest of the diff and it fails as expected so 👍

@timothysmith0609 timothysmith0609 merged commit be0b5bd into master Jan 28, 2019
@timothysmith0609 timothysmith0609 deleted the only_ejson branch January 28, 2019 19:42
@timothysmith0609 timothysmith0609 mentioned this pull request Feb 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dturn dturn dturn approved these changes

@KnVerey KnVerey KnVerey approved these changes

@kirs kirs Awaiting requested review from kirs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timothysmith0609 @KnVerey @dturn