Pass the file path to the formatter #32
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
I can't get the
check
to finish on our repo because there are parsing errors (on both packwerk and our code). But when it errors, I can't tell where it's at. I've been addingputs
to the cli. While I was there, I thought it'd make sense for the cli to pass along the path to the formatter in case someone wants to make a document-style formatter.What approach did you choose and why?
This is similar to how RSpec (and others) formatter works.
Type of Change
Checklist