Skip to content

Commit 45baeb5

Browse files
committed
[ResourceItem] Consolidate conditional logic (#10172)
### WHY are these changes introduced? Fixes #9961 ### WHAT is this pull request doing? * Consolidate se23 logic and styles for the `ResourceItem` Component ### How to 🎩 * Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-resourceitem--default&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-ganribjzxv.chromatic.com/?path=/story/all-components-resourceitem--default)
1 parent fabe693 commit 45baeb5

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

polaris-react/src/components/ResourceItem/ResourceItem.scss

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,7 @@
2323
cursor: pointer;
2424

2525
&:hover {
26-
background-color: var(--p-color-bg-hover);
27-
#{$se23} & {
28-
background-color: var(--p-color-bg-subdued-hover);
29-
}
26+
background-color: var(--p-color-bg-subdued-hover);
3027

3128
.Actions {
3229
// stylelint-disable-next-line selector-max-combinators -- show actions on hover
@@ -120,9 +117,7 @@
120117
.ListItem + & {
121118
border-top: var(--p-border-width-1) solid var(--p-color-border-subdued);
122119

123-
#{$se23} & {
124-
@include item-separator;
125-
}
120+
@include item-separator;
126121
}
127122

128123
&:not(.hasBulkActions):not(.selectMode) {

0 commit comments

Comments
 (0)