From 71140e70b8b2273e653c6896f4db75dbe1b48983 Mon Sep 17 00:00:00 2001
From: Matt Lavoie <mathieu.lavoie@shopify.com>
Date: Mon, 7 Feb 2022 18:58:13 -0500
Subject: [PATCH] use typescript native types

changelog

remove homemade types

also this one

reword changelog

add breaking changes to changelog

Update packages/useful-types/CHANGELOG.md

Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com>

pr comments
---
 packages/useful-types/CHANGELOG.md |  8 ++++++++
 packages/useful-types/src/types.ts | 28 ----------------------------
 2 files changed, 8 insertions(+), 28 deletions(-)

diff --git a/packages/useful-types/CHANGELOG.md b/packages/useful-types/CHANGELOG.md
index a67ff62c79..6b62c4f6c7 100644
--- a/packages/useful-types/CHANGELOG.md
+++ b/packages/useful-types/CHANGELOG.md
@@ -7,6 +7,14 @@ and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
 <!-- ## Unreleased -->
 
+### Breaking Change
+
+- `Omit` has been removed. Remove any `import { Omit } from '@shopify/useful-types';` and use the built-in [`Omit`](https://www.typescriptlang.org/docs/handbook/utility-types.html#omittype-keys) type
+- `ThenType` has been removed. You should use the built-in `Awaited` type instead
+- `Arguments`, `ArgumentsAtIndex` and `FirstArgument` have been removed. Replace usage of `Arguments` with the built-in [`Parameters`](https://www.typescriptlang.org/docs/handbook/utility-types.html#parameterstype) type. Replace usage of `ArgumentAtIndex` with `Parameters<T>[i]` and `FirstArgument<T>` with `Parameters<T>[0]`.
+- `ConstructorArguments`, `ConstructorArgumentAtIndex` and `FirstConstructorArgument` have been removed. Replace usage of `ConstructorArguments` with the built-in [`ConstructorParameters`](https://www.typescriptlang.org/docs/handbook/utility-types.html#constructorparameterstype) type. Replace usage of `ConstructorArgumentAtIndex` with `ConstructorParameters<T>[i]` and `FirstConstructorArgument<T>` with `ConstructorParameters<T>[0]`
+- `MaybeFunctionReturnType` has been removed. Replace usage of `MaybeFunctionReturnType` with the built-in `ReturnType` type
+
 ## 3.1.0 - 2022-02-09
 
 ### Added
diff --git a/packages/useful-types/src/types.ts b/packages/useful-types/src/types.ts
index fd04b8b784..c54d8bd5b2 100644
--- a/packages/useful-types/src/types.ts
+++ b/packages/useful-types/src/types.ts
@@ -1,20 +1,5 @@
-export type ThenType<T> = T extends Promise<infer U> ? U : T;
-
-export type Arguments<T> = T extends (...args: infer U) => any ? U : never;
-export type ArgumentAtIndex<
-  Func,
-  Index extends keyof Arguments<Func>
-> = Arguments<Func>[Index];
-export type FirstArgument<T> = ArgumentAtIndex<T, 0>;
-
-export type MaybeFunctionReturnType<T> = T extends (...args: any[]) => infer U
-  ? U
-  : never;
-
 export type ArrayElement<T> = T extends (infer U)[] ? U : never;
 
-export type Omit<T, K extends keyof T> = Pick<T, Exclude<keyof T, K>>;
-
 export type DeepPartial<T> = {
   [P in keyof T]?: T[P] extends (infer U)[]
     ? DeepPartial<U>[]
@@ -67,19 +52,6 @@ export type NonReactStatics<T> = Pick<T, Exclude<keyof T, ReactStatics>>;
 
 export type ExtendedWindow<T> = Window & typeof globalThis & T;
 
-export type ConstructorArguments<T> = T extends {
-  new (...args: infer U): any;
-}
-  ? U
-  : never;
-
-export type ConstructorArgumentAtIndex<
-  T,
-  I extends keyof ConstructorArguments<T>
-> = ConstructorArguments<T>[I];
-
-export type FirstConstructorArgument<T> = ConstructorArgumentAtIndex<T, 0>;
-
 // Reference https://stackoverflow.com/questions/55539387/deep-omit-with-typescript
 type Primitive =
   | string