From b5d20f71ea633e29365b2440af31fad8da572346 Mon Sep 17 00:00:00 2001 From: Joshua May Date: Mon, 7 Feb 2022 13:42:37 +0100 Subject: [PATCH 1/2] Remove unused call to faker.seed() --- packages/graphql-fixtures/src/fill.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/graphql-fixtures/src/fill.ts b/packages/graphql-fixtures/src/fill.ts index 1d5df027dd..15e7be70d0 100644 --- a/packages/graphql-fixtures/src/fill.ts +++ b/packages/graphql-fixtures/src/fill.ts @@ -299,9 +299,7 @@ function withRandom(keypath: FieldDetails[], func: () => T, seedOffset = 0) { ), ) + seedOffset, ); - const value = func(); - faker.seed(Math.random() * 10000); - return value; + return func(); } function createValue( From 948bf6208b086fa1e4faf085a3826d239fa9242f Mon Sep 17 00:00:00 2001 From: Joshua May Date: Thu, 10 Feb 2022 11:18:02 +0100 Subject: [PATCH 2/2] Update CHANGELOG --- packages/graphql-fixtures/CHANGELOG.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/graphql-fixtures/CHANGELOG.md b/packages/graphql-fixtures/CHANGELOG.md index fcfb0e108e..96a9b5813c 100644 --- a/packages/graphql-fixtures/CHANGELOG.md +++ b/packages/graphql-fixtures/CHANGELOG.md @@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). - +## Unreleased + +### Changed + +- Removes call to `faker.seed()` that uses `Math.random()` as a seed value [[#2161]](https://github.com/Shopify/quilt/pull/2161) ## 1.4.1 - 2022-02-09