From fbccf2c4d3c28e055580f432de07ba176c106508 Mon Sep 17 00:00:00 2001 From: Ben Scott Date: Fri, 9 Apr 2021 14:34:01 -0700 Subject: [PATCH] Fix tests --- templates/package.hbs.json | 2 ++ tests/consistent-package-json.test.ts | 8 -------- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/templates/package.hbs.json b/templates/package.hbs.json index 4f9c96540f..8d26f726e3 100644 --- a/templates/package.hbs.json +++ b/templates/package.hbs.json @@ -5,6 +5,7 @@ "description": "{{{description}}}", "main": "index.js", "types": "index.d.ts", + "scripts": {}, "sideEffects": false, "publishConfig": { "access": "public", @@ -20,6 +21,7 @@ "url": "https://github.com/Shopify/quilt/issues" }, "homepage": "https://github.com/Shopify/quilt/blob/main/packages/{{name}}/README.md", + "dependencies": {}, "files": [ "build/*", "!*.tsbuildinfo", diff --git a/tests/consistent-package-json.test.ts b/tests/consistent-package-json.test.ts index 7696dd21ac..06a2ee1a03 100644 --- a/tests/consistent-package-json.test.ts +++ b/tests/consistent-package-json.test.ts @@ -59,9 +59,6 @@ packages.forEach( it('specifies Quilt Issues as bugs URL', () => { expect(packageJSON.bugs).toStrictEqual(expectedPackageJSON.bugs); }); - it('specifies dependencies', () => { - expect(packageJSON.dependencies).not.toStrictEqual({}); - }); it('specifies a description', () => { expect(packageJSON.description).not.toBeUndefined(); }); @@ -102,11 +99,6 @@ packages.forEach( expectedPackageJSON.repository, ); }); - it('specifies scripts, including build', () => { - expect(packageJSON.scripts.build).toBe( - expectedPackageJSON.scripts.build, - ); - }); it('specifies if webpack can tree-shake, via sideEffects', () => { expect(packageJSON.sideEffects).toBe( Boolean(packageJSON.sideEffects),