Stop reusing the Prism result for RuboCop for now #3672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
bugfix
Graphite App
This was referenced Jul 18, 2025
KaanOzkan
approved these changes
Jul 18, 2025
st0012
approved these changes
Jul 18, 2025
vinistock
deleted the
07-18-stop_reusing_the_prism_result_for_rubocop_for_now
branch
Earlopain
added a commit
to Earlopain/ruby-lsp
that referenced
this pull request
Aug 27, 2025
RuboCop 1.80.1 contains a fix for why this was broken, so it should be safe to enable this again. Revert: Shopify#3672 Fix: rubocop/rubocop#14478
Earlopain
added a commit
to Earlopain/ruby-lsp
that referenced
this pull request
Aug 27, 2025
RuboCop 1.80.1 contains a fix for why this was broken, so it should be safe to enable this again. Revert: Shopify#3672 Fix: rubocop/rubocop#14478
Earlopain
added a commit
to Earlopain/ruby-lsp
that referenced
this pull request
Aug 27, 2025
RuboCop 1.80.1 contains a fix for why this was broken, so it should be safe to enable this again. Revert: Shopify#3672 Fix: rubocop/rubocop#14478
vinistock
pushed a commit
that referenced
this pull request
Aug 28, 2025
RuboCop 1.80.1 contains a fix for why this was broken, so it should be safe to enable this again. Revert: #3672 Fix: rubocop/rubocop#14478
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Related to #3657 and #3665. This PR "fixes" the issues by not reusing the Prism result anymore, but the real fix is on the RuboCop side.
Reusing the Prism parse result for RuboCop is a massive performance win as we avoid double-parsing the same document - both for computing diagnostics on every keypress and for formatting.
Unfortunately, we are receiving numerous reports of RuboCop crashing when the Prism result is reused, so I propose we turn this off while the RuboCop team investigates why the cops fail in this mode.
It might be easier to add some sort of experimental setting, so that people can find bugs. It seems like the problems are not related to running RuboCop in the CLI, where it sees all files in their final state, but in LSP mode when the user is in the middle of typing.