Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug related to MTA where the fly speed of jetpacks was much faster than it should be #2

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

DouweKoopmans
Copy link

fixed the mentioned bug, cleaned up a lot of the code, added a proper .gitignore and readme and setup ForgeGradle

@BlueAnanas
Copy link

@storm345 told me to look over here to get some hints since your're also working here on the problem introduced by the fly boost function of a toggle mod. Unfortunately I already fixed it in all my stable releases :-(

I have the feeling that there is some overcoding here, as my fix for the fly issue in MTA is a small +12 -3 commit, but I just can't pinpoint the reason.

  • Did you take into account that from 1.9 on vanilla client as a built in fly boost in spectator mode? It doesn't make any sense considering any mode else than creative for fly boost in future.
  • Creative mode can simply be checked via capabilities.isCreativeMode. Why register a FlySpeedRegulator ?
  • Is this maybe the result of the fact that the mod requires PlayerAPI? PlayerAPI has quite a lot of incompatibilities and isn't available for 1.9 yet - why use it at all?

@DouweKoopmans
Copy link
Author

this fix is for 1.8.x, not 1.9. in 1.8.x there isn't a fly boost in spectator mode so we add one. when PlayerAPI releases a 1.9 version fixing this will just mean removing the specator check from a few if statements.

the use of PlayerAPI definitely complicates things a lot, but unfortunately removing it as a dependency now would require rewriting a large portion of code.

@BlueAnanas
Copy link

this fix is for 1.8.x, not 1.9.

The commits for 1.8, 1.8.8 and 1.8.9 are exactly the same and fast forward merged since I'm developing in all four MC versions in parallel.

in 1.8.x there isn't a fly boost in spectator mode so we add one

Can you give me a hint where the boost in spectator mode is used? It would be one conditional to implement this on my side but I'm reluctant to have my feature sets diverge.

Good luck with PlayerAPI, hope 1.9 will be available soon.

@storm345
Copy link

How this was done, zebra, was fine and has been tested to work. Your previous versions, as discussed, did have the fly-speed-ignore bug and the code I saw from you to fix it, as discussed, would have ignored fly speed vertically. This is a fix to an old mod, not a new mod, which is part of why everything here is rather messy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants