-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix a bug related to MTA where the fly speed of jetpacks was much faster than it should be #2
base: master
Are you sure you want to change the base?
Conversation
…y speed modifier" This reverts commit 8af819b.
…e fly speed as well
when you are not in creative or spectator mode, the status hud now doesn't display the (# x boost) text when you are trying to boost
removed the appendix since this mod now supports multiple minecraft version and appending the jar with a single version would be deceiving
@storm345 told me to look over here to get some hints since your're also working here on the problem introduced by the fly boost function of a toggle mod. Unfortunately I already fixed it in all my stable releases :-( I have the feeling that there is some overcoding here, as my fix for the fly issue in MTA is a small +12 -3 commit, but I just can't pinpoint the reason.
|
this fix is for 1.8.x, not 1.9. in 1.8.x there isn't a fly boost in spectator mode so we add one. when PlayerAPI releases a 1.9 version fixing this will just mean removing the specator check from a few if statements. the use of PlayerAPI definitely complicates things a lot, but unfortunately removing it as a dependency now would require rewriting a large portion of code. |
The commits for 1.8, 1.8.8 and 1.8.9 are exactly the same and fast forward merged since I'm developing in all four MC versions in parallel.
Can you give me a hint where the boost in spectator mode is used? It would be one conditional to implement this on my side but I'm reluctant to have my feature sets diverge. Good luck with PlayerAPI, hope 1.9 will be available soon. |
How this was done, zebra, was fine and has been tested to work. Your previous versions, as discussed, did have the fly-speed-ignore bug and the code I saw from you to fix it, as discussed, would have ignored fly speed vertically. This is a fix to an old mod, not a new mod, which is part of why everything here is rather messy. |
fixed the mentioned bug, cleaned up a lot of the code, added a proper .gitignore and readme and setup ForgeGradle