Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to improve installation process #467

Closed
ghost opened this issue Nov 13, 2022 · 1 comment · Fixed by #469
Closed

Suggestion to improve installation process #467

ghost opened this issue Nov 13, 2022 · 1 comment · Fixed by #469

Comments

@ghost
Copy link

ghost commented Nov 13, 2022

Hi! hope you're doing great. Here I'll suggest one change to the project.

Installation process

Currently, the installation process requires the execution of two commands, which are:

  1. run curl to get the installation script and save in a install.sh file and
  2. run the script with the installation directory location

Even thought it's simple, This process could be simplified with just one line command. Which would make the life of everyone easier.

Example

sh -c "$(curl -fsSL https://raw.githubusercontent.com/Shougo/dein.vim/master/bin/installer.sh)"

Of course, we would need to update the installation script.

I've been writing sh & bash for years and this simplification would be a nice feature to this wholesome project
If you don't have time, I can make one and open an PR just to give you an north about what I meant. Stay safe!

@Shougo
Copy link
Owner

Shougo commented Nov 15, 2022

Sorry. I don't want to change the example.
Yes, your script is simpler. But it is intended. User should check your installation script before the execution.

I will check your installation script later.

@Shougo Shougo closed this as completed Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant