Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese Windows User (Double Byte) cannot evoke scrcpy #126

Closed
urashita opened this issue Jul 27, 2021 · 7 comments
Closed

Japanese Windows User (Double Byte) cannot evoke scrcpy #126

urashita opened this issue Jul 27, 2021 · 7 comments
Labels
analysis needed bug Something isn't working

Comments

@urashita
Copy link

I am using SideQuest and scrcpy and found that I can not evoke scrcpy in some cases.

When I use single byte user (urashita) in Windows, SideQuest is installed here
C:\Users\urashita\AppData\Local\Programs\SideQuest

When I first launched SideQuest, scrcpy was downloaded and installed here
C:\Users\urashita\AppData\Roaming\SideQuest\scrcpy

Then I could always evoke scrcpy from SideQuest.

But when I use this user "1階のPC" in Windows, SideQuest is installed here
C:\Users\1階のPC\AppData\Local\Programs\SideQuest

When I first launched SideQuest, scrcpy was downloaded and installed here
C:\Users\1階のPC\AppData\Roaming\SideQuest\scrcpy

Then I could NEVER evoke scrcpy from SideQuest.

I think there may be a reason SideQuest cannot launch scrcpy.
The most possible cause is that scrcpyBinaryPath needs double quote?

I am reading SideQuest source code and skeptical around here.
SideQuest/desktop-app/src/app/app.service.ts
line 400: this.scrcpyBinaryPath = downloadPath;

I am willing to test and check it in my PC if there were a possible fixed code.

@sidequestlegend sidequestlegend added analysis needed bug Something isn't working labels Aug 12, 2021
@sidequestlegend
Copy link
Contributor

Hi there!

I got to testing this today and after I created and setup a new user on my PC with the name 1階の I was indeed able to launch scrcpy without any problem. I am unsure of how else I can test this. Below was the scrcpy command that was output on the SideQuest console just before it opened.

"C:\Users\1階の\AppData\Roaming\SideQuest\scrcpy\scrcpy.exe" --crop 1280:720:1500:350 -b 8000000 --max-fps 0 --max-size 0 -n --window-title "SideQuest Stream" -s 1WMHH814MP0383

And here is it working:

image

@urashita
Copy link
Author

I said "1階のPC", NOT "1階の".

@urashita
Copy link
Author

urashita commented Sep 6, 2021

What is going on about this issue?

@sidequestlegend
Copy link
Contributor

sidequestlegend commented Sep 6, 2021

Hi there, it seems to me the double byte characters are "1階の" and not "PC". I did test the double byte characters and it worked just fine. Im not sure what else you want me to do here.

When you click "Start Stream" sidequest will output the full scrcpy command to the console. To view the console click the little bug icon at the top and then in the section that opens click the "console" tab. From there you can see that the command is indeed encapsulated in double quotes ( it always has been ) and you can copy that command verbatim and paste it into command prompt to try to run scrcpy manually. Can you give this a try?

@urashita
Copy link
Author

urashita commented Sep 7, 2021

Hi there, I tested as your advice and I got an interesting results.

  1. SideQuest does not open mirroring window and I copy and pasted SideQuest's command into command prompt.

C:\Users\1階のPC>"C:\Users\1階のPC\AppData\Roaming\SideQuest\scrcpy\scrcpy.exe" --crop 1600:900:2017:510 -b 8000000 --max-fps 0 --max-size 0 -n --window-title "SideQuest Stream" -s 1WMHH842XM0492
INFO: scrcpy 1.11 https://github.com/Genymobile/scrcpy
adb: error: cannot stat '.\scrcpy-server': No such file or directory
ERROR: "adb push" returned with value 1
Press any key to continue...

  1. Then I set SCRCPY_SERVER_PATH

C:\Users\1階のPC>set SCRCPY_SERVER_PATH=C:\Users\1階のPC\AppData\Roaming\SideQuest\scrcpy\scrcpy-server

C:\Users\1階のPC>"C:\Users\1階のPC\AppData\Roaming\SideQuest\scrcpy\scrcpy.exe" --crop 1600:900:2017:510 -b 8000000 --max-fps 0 --max-size 0 -n --window-title "SideQuest Stream" -s 1WMHH842XM0492
INFO: scrcpy 1.11 https://github.com/Genymobile/scrcpy
adb: error: cannot stat 'C:\Users\1�K��PC\AppData\Roaming\SideQuest\scrcpy\scrcpy-server': No such file or directory
ERROR: "adb push" returned with value 1
Press any key to continue...

  1. Finally I set SCRCPY_SERVER_PATH from single byte path

C:\Users\1階のPC>set SCRCPY_SERVER_PATH=C:\Users\urashita\AppData\Roaming\SideQuest\scrcpy\scrcpy-server

C:\Users\1階のPC>"C:\Users\1階のPC\AppData\Roaming\SideQuest\scrcpy\scrcpy.exe" --crop 1600:900:2017:510 -b 8000000 --max-fps 0 --max-size 0 -n --window-title "SideQuest Stream" -s 1WMHH842XM0492
INFO: scrcpy 1.11 https://github.com/Genymobile/scrcpy
C:\Users\urashita\AppData\Roaming\SideQuest\scrcpy\scrcpy-server: 1 files pushed. 2.3 MB/s
INFO: Initial texture: 1600x896

Then I got mirroring window.

I found that the problem is not SideQuest but scrcpy.
I will ask this issue to scrcpy project.
Thank you!

commad1

@urashita
Copy link
Author

scrcpy project will fix soon.

Genymobile/scrcpy#2619

@sidequestlegend
Copy link
Contributor

Closing as scrcpy issue. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis needed bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants