Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host/Guest and name selection timing issue #28

Open
HSZemi opened this issue May 7, 2020 · 3 comments
Open

Host/Guest and name selection timing issue #28

HSZemi opened this issue May 7, 2020 · 3 comments

Comments

@HSZemi
Copy link
Member

HSZemi commented May 7, 2020

When a player joins a draft, they are asked whether they want to be Host, Guest, or Spectator.

At that point, they technically joined the Draft as Spectator, but can upgrade to Host or Guest. Once somebody upgrades to Host or Guest, the option becomes unavailable to other users. If Host and Guest are present, further users automatically join the Draft as Spectators and do not have the option to upgrade.

After selecting Host or Guest, users are asked to set their name if they have not already done so. Only then do they try to upgrade to Host or Guest.

If another user upgrades to e.g. Host while the user who wants to upgrade to Host as well is still picking their name, the upgrade fails and the user silently stays a Spectator. That is unfortunate.

@lalitpatel
Copy link
Contributor

lalitpatel commented Jun 15, 2020

How about sharing a slightly different URL for spectators vs players? Any user landing on via the Player URL after both the Host and Guests have joined would silently join as a Spectator.

We are now sharing separate URLs for Players and Spectators. Is this till an issue that is reported often?

@HSZemi
Copy link
Member Author

HSZemi commented Jun 15, 2020

So far, I have received zero reports of that occurring.

@lalitpatel
Copy link
Contributor

I found a somewhat related issue. I do not think this has happened yet but I feel it is a possibility.

For games that are live streamed by players, they often do the drafts on stream. There is often a delay between when one captain joins the draft and the other joins it (they send the link on discord and the other player might be afk or busy etc). During that time, one of the viewers of the stream can use the draft id and to join the draft as the Guest Captain before the actual captain joins the draft and there by hijacking the draft.

Possible solution:

Should append an auto generated hard to guess secret param to draft link that is shared to players so the viewers cannot use the draft id to guess the player's link and join the draft as a player.

Example:

https://aoe2cm.net/draft/kNOoJ?secret=HbuJPx
https://aoe2cm.net/spectate/kNOoJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants